fix(test-optimization): resolve disabled git upload immediately#9338
Conversation
Overall package sizeSelf size: 6.76 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.3.1 | 122.62 kB | 438.86 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
|
BenchmarksBenchmark execution time: 2026-07-15 11:17:44 Comparing candidate commit 44cdfc4 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 2313 metrics, 45 unstable metrics.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9338 +/- ##
=======================================
Coverage 96.64% 96.64%
=======================================
Files 923 923
Lines 122844 122845 +1
Branches 21042 21128 +86
=======================================
+ Hits 118725 118728 +3
+ Misses 4119 4117 -2 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
More details
PR resolves the git-upload promise immediately when git upload is disabled, preventing 60-second timeout delays in dependent code paths (getSkippableSuites, getLibraryConfiguration). The fix is minimal and correct — calling _resolveGit() with no error when disabled is the intended behavior. New test validates the promise resolves with undefined and no HTTP requests occur.
📊 Validated against 1 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit 0a36f32 · What is Autotest? · Any feedback? Reach out in #autotest
juan-fernandez
left a comment
There was a problem hiding this comment.
this is great!
so settings and skippable-test requests waited for the 60-second fallback.
any chance we could create an integration test in any test framework (say jest) that would fail without these changes? This seems like it could have significant user impact?
Disabling git upload left readiness unresolved, so settings requests waited for the 60-second fallback.
This catches disabled uploads leaving settings and skippable requests blocked on the 60-second fallback.
0a36f32 to
44cdfc4
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
juan-fernandez
left a comment
There was a problem hiding this comment.
thanks, this was a good catch
Disabling git upload left readiness unresolved, so settings requests waited for the 60-second fallback.
Disabling git upload left readiness unresolved, so settings requests waited for the 60-second fallback.
Disabling git upload left readiness unresolved, so settings requests waited for the 60-second fallback.
Disabling git upload left readiness unresolved, so settings requests waited for the 60-second fallback.
Summary
Disabling git upload left readiness unresolved, so settings and skippable-test requests waited for the 60-second fallback.
Test plan