Skip to content

fix(test-optimization): resolve disabled git upload immediately#9338

Merged
BridgeAR merged 2 commits into
masterfrom
BridgeAR/2026-07-14-fix-disabled-git-readiness
Jul 15, 2026
Merged

fix(test-optimization): resolve disabled git upload immediately#9338
BridgeAR merged 2 commits into
masterfrom
BridgeAR/2026-07-14-fix-disabled-git-readiness

Conversation

@BridgeAR

Copy link
Copy Markdown
Member

Summary

Disabling git upload left readiness unresolved, so settings and skippable-test requests waited for the 60-second fallback.

Test plan

  • Run the CI Visibility exporter spec
  • Check changed-line and branch coverage

@dd-octo-sts

dd-octo-sts Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 6.76 MB
Deduped: 7.42 MB
No deduping: 7.42 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.3.1 | 122.62 kB | 438.86 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Jul 14, 2026

Copy link
Copy Markdown

Tests

Fix all issues with BitsAI

⚠️ Warnings

🧪 1 Test failed in 1 job

All Green | all-green   GitHub Actions

Plugin with electron >=37.0.0 (37.0.0) electron without configuration should do automatic instrumentation for fetch from without configuration   View in Datadog
No matching trace received within 1000ms.

Error: No matching trace received within 1000ms.
    at Timeout._onTimeout (packages/dd-trace/test/plugins/agent.js:383:14)
    at listOnTimeout (node:internal/timers:605:17)
    at process.processTimers (node:internal/timers:541:7)

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

🔄 Datadog auto-retried 1 job - 1 passed on retry View in Datadog

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 96.61% (+0.00%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 44cdfc4 | Docs | Datadog PR Page | Give us feedback!

@pr-commenter

pr-commenter Bot commented Jul 14, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-07-15 11:17:44

Comparing candidate commit 44cdfc4 in PR branch BridgeAR/2026-07-14-fix-disabled-git-readiness with baseline commit 3721357 in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 0 performance regressions! Performance is the same for 2313 metrics, 45 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:appsec-appsec-enabled-24

  • unstable execution_time [-208509.602µs; +207675.336µs] or [-7.846%; +7.814%]

scenario:appsec-appsec-enabled-26

  • unstable execution_time [-236.657ms; +231.680ms] or [-9.246%; +9.051%]

scenario:appsec-appsec-enabled-with-attacks-24

  • unstable execution_time [-161.479ms; +158.768ms] or [-5.229%; +5.142%]

scenario:appsec-appsec-enabled-with-attacks-26

  • unstable execution_time [-194692.752µs; +193158.585µs] or [-6.671%; +6.618%]

scenario:appsec-control-20

  • unstable execution_time [-116.142ms; +134.221ms] or [-7.056%; +8.154%]

scenario:appsec-control-24

  • unstable execution_time [-120634.556µs; +122124.989µs] or [-9.693%; +9.812%]

scenario:appsec-control-26

  • unstable execution_time [-123.874ms; +127.567ms] or [-9.974%; +10.271%]

scenario:appsec-iast-no-vulnerability-control-20

  • unstable execution_time [-17.372ms; +11.214ms] or [-6.659%; +4.299%]

scenario:child_process-shell-string-24

  • unstable cpu_usage_percentage [-7.619%; +3.666%]
  • unstable execution_time [-14.162ms; +31.679ms] or [-4.381%; +9.801%]
  • unstable throughput [-285774.307op/s; +132270.268op/s] or [-7.889%; +3.651%]

scenario:debugger-line-probe-with-snapshot-default-26

  • unstable cpu_user_time [-3.531s; +0.480s] or [-34.303%; +4.666%]
  • unstable execution_time [-3.543s; +0.506s] or [-32.038%; +4.571%]
  • unstable instructions [-31.6G instructions; +4.2G instructions] or [-36.597%; +4.896%]
  • unstable throughput [-107.286op/s; +695.217op/s] or [-3.494%; +22.644%]

scenario:debugger-line-probe-with-snapshot-minimal-24

  • unstable cpu_user_time [-1975.936ms; +3177.365ms] or [-23.853%; +38.356%]
  • unstable execution_time [-1956.537ms; +3180.837ms] or [-21.673%; +35.234%]
  • unstable instructions [-16.8G instructions; +26.7G instructions] or [-24.831%; +39.596%]
  • unstable max_rss_usage [-8.123MB; +13.198MB] or [-5.191%; +8.434%]
  • unstable throughput [-851.027op/s; +519.075op/s] or [-23.334%; +14.233%]

scenario:debugger-line-probe-with-snapshot-minimal-26

  • unstable cpu_user_time [-2625.249ms; +4171.315ms] or [-27.513%; +43.716%]
  • unstable execution_time [-2783.905ms; +4313.660ms] or [-27.119%; +42.021%]
  • unstable instructions [-23.2G instructions; +36.9G instructions] or [-29.127%; +46.321%]
  • unstable max_rss_usage [-9.809MB; +12.607MB] or [-6.165%; +7.924%]
  • unstable throughput [-831.569op/s; +548.506op/s] or [-25.697%; +16.950%]

scenario:debugger-line-probe-without-snapshot-26

  • unstable cpu_user_time [-3592.732ms; +3563.834ms] or [-34.901%; +34.621%]
  • unstable execution_time [-3657.867ms; +3605.210ms] or [-33.171%; +32.694%]
  • unstable instructions [-32392.4M instructions; +32244.2M instructions] or [-37.446%; +37.275%]
  • unstable max_rss_usage [-11190.475KB; +11672.075KB] or [-6.931%; +7.229%]
  • unstable throughput [-719.969op/s; +712.812op/s] or [-23.319%; +23.087%]

scenario:dogstatsd-with-tags-20

  • unstable cpu_user_time [-409.492ms; +264.478ms] or [-8.552%; +5.523%]
  • unstable execution_time [-413.857ms; +262.114ms] or [-8.500%; +5.384%]
  • unstable throughput [-94064.827op/s; +146989.339op/s] or [-5.454%; +8.523%]

scenario:plugin-graphql-long-with-depth-on-max-20

  • unstable cpu_user_time [-734.440ms; +723.540ms] or [-5.719%; +5.634%]
  • unstable execution_time [-749.504ms; +731.265ms] or [-5.709%; +5.570%]
  • unstable throughput [-3.359op/s; +3.443op/s] or [-5.478%; +5.614%]

scenario:plugin-mongodb-core-binary-hash-20

  • unstable execution_time [-162.464ms; +192.485ms] or [-5.273%; +6.248%]

scenario:plugin-pg-service-24

  • unstable cpu_usage_percentage [-6.596%; +4.231%]
  • unstable execution_time [-92.473ms; +148.355ms] or [-5.567%; +8.932%]
  • unstable throughput [-252818.373op/s; +157446.129op/s] or [-6.938%; +4.321%]

scenario:plugin-redis-churn-24

  • unstable cpu_user_time [-106.424ms; +68.188ms] or [-8.671%; +5.556%]
  • unstable execution_time [-106.847ms; +69.795ms] or [-8.612%; +5.626%]
  • unstable instructions [-1186.2M instructions; +730.3M instructions] or [-8.625%; +5.310%]
  • unstable throughput [-420637.197op/s; +655874.535op/s] or [-10.230%; +15.951%]

scenario:test-optimization-large-suite-20

  • unstable max_rss_usage [-3.917MB; +9.048MB] or [-4.791%; +11.068%]

@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.64%. Comparing base (3721357) to head (44cdfc4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9338   +/-   ##
=======================================
  Coverage   96.64%   96.64%           
=======================================
  Files         923      923           
  Lines      122844   122845    +1     
  Branches    21042    21128   +86     
=======================================
+ Hits       118725   118728    +3     
+ Misses       4119     4117    -2     
Flag Coverage Δ
aiguard 53.65% <ø> (-0.12%) ⬇️
aiguard-integration 57.10% <ø> (-0.01%) ⬇️
apm-bucket-0 53.88% <ø> (-0.05%) ⬇️
apm-bucket-1 58.45% <ø> (-0.05%) ⬇️
apm-bucket-2 56.18% <ø> (-0.05%) ⬇️
apm-capabilities-tracing 60.62% <100.00%> (+<0.01%) ⬆️
apm-integrations-aerospike 53.03% <ø> (-0.05%) ⬇️
apm-integrations-confluentinc-kafka-javascript 57.18% <ø> (+0.01%) ⬆️
apm-integrations-couchbase 53.37% <ø> (-0.05%) ⬇️
apm-integrations-http 58.04% <ø> (-0.04%) ⬇️
apm-integrations-kafkajs 57.83% <ø> (-0.05%) ⬇️
apm-integrations-next 54.26% <ø> (-0.05%) ⬇️
apm-integrations-prisma 54.26% <ø> (-0.05%) ⬇️
apm-integrations-tedious 53.14% <ø> (-0.05%) ⬇️
appsec 68.92% <ø> (-0.04%) ⬇️
appsec-express_fastify_graphql 65.72% <ø> (-0.04%) ⬇️
appsec-integration 51.95% <ø> (ø)
appsec-kafka_ldapjs_lodash 59.17% <ø> (-0.04%) ⬇️
appsec-mongodb-core_mongoose_mysql 62.40% <ø> (-0.04%) ⬇️
appsec-next 52.88% <ø> (-0.04%) ⬇️
appsec-node-serialize_passport_postgres 62.04% <ø> (-0.04%) ⬇️
appsec-sourcing_stripe_template 60.43% <ø> (-0.04%) ⬇️
debugger 65.68% <ø> (-0.02%) ⬇️
instrumentations-bucket-0 48.88% <ø> (-0.05%) ⬇️
instrumentations-bucket-1 55.08% <ø> (-0.05%) ⬇️
instrumentations-bucket-10 56.71% <ø> (-0.05%) ⬇️
instrumentations-bucket-11 48.87% <ø> (-0.05%) ⬇️
instrumentations-bucket-12 49.05% <ø> (-0.05%) ⬇️
instrumentations-bucket-13 48.81% <ø> (-0.05%) ⬇️
instrumentations-bucket-2 50.02% <ø> (-0.05%) ⬇️
instrumentations-bucket-3 53.99% <ø> (-0.05%) ⬇️
instrumentations-bucket-4 49.29% <ø> (-0.05%) ⬇️
instrumentations-bucket-5 53.16% <ø> (-0.05%) ⬇️
instrumentations-bucket-6 55.73% <ø> (-0.05%) ⬇️
instrumentations-bucket-7 53.63% <ø> (-0.05%) ⬇️
instrumentations-bucket-8 54.76% <ø> (-0.05%) ⬇️
instrumentations-bucket-9 56.19% <ø> (-0.04%) ⬇️
instrumentations-instrumentation-couchbase 48.27% <ø> (-0.05%) ⬇️
instrumentations-integration-esbuild 34.07% <ø> (ø)
llmobs-ai_anthropic_bedrock 57.77% <ø> (-0.04%) ⬇️
llmobs-bucket-1 57.11% <ø> (-0.04%) ⬇️
llmobs-openai 57.50% <ø> (-0.04%) ⬇️
llmobs-sdk 60.07% <ø> (-0.05%) ⬇️
llmobs-vertex-ai 54.31% <ø> (-0.05%) ⬇️
master-coverage 96.64% <100.00%> (?)
openfeature 54.70% <ø> (+<0.01%) ⬆️
openfeature-unit 49.91% <ø> (-0.05%) ⬇️
platform-core_esbuild_instrumentations-misc 38.54% <ø> (-0.03%) ⬇️
platform-integration 62.33% <ø> (ø)
platform-shimmer_unit-guardrails_webpack 37.33% <ø> (-0.03%) ⬇️
plugins-bucket-0 53.26% <ø> (-0.04%) ⬇️
plugins-bucket-1 55.20% <ø> (ø)
plugins-bucket-11 57.53% <ø> (-0.04%) ⬇️
plugins-bucket-18 57.14% <ø> (-0.05%) ⬇️
plugins-bucket-19 55.44% <ø> (-0.07%) ⬇️
plugins-bucket-20 57.66% <ø> (-0.05%) ⬇️
plugins-bucket-4 53.87% <ø> (-0.05%) ⬇️
plugins-bullmq_cassandra_cookie 57.47% <ø> (-0.05%) ⬇️
plugins-cookie-parser_crypto_dd-trace-api 52.42% <ø> (-0.05%) ⬇️
plugins-fetch_fs_generic-pool 54.67% <ø> (+0.03%) ⬆️
plugins-google-cloud-pubsub_grpc_handlebars 59.92% <ø> (-0.05%) ⬇️
plugins-hapi_hono_ioredis 55.86% <ø> (-0.05%) ⬇️
plugins-jest_knex_langgraph 51.77% <ø> (-0.05%) ⬇️
plugins-ldapjs_light-my-request_limitd-client 53.54% <ø> (-0.03%) ⬇️
plugins-lodash_mariadb_memcached 54.30% <ø> (-0.05%) ⬇️
plugins-moleculer_mongodb_mongodb-core 57.40% <ø> (-0.05%) ⬇️
plugins-mongoose_multer_mysql 54.79% <ø> (-0.05%) ⬇️
plugins-mysql2_nats_node-serialize 56.33% <ø> (-0.05%) ⬇️
plugins-opensearch_passport-http_pino 55.19% <ø> (-0.05%) ⬇️
plugins-postgres_process_pug 54.38% <ø> (-0.05%) ⬇️
plugins-redis_router_sequelize 57.19% <ø> (-0.04%) ⬇️
plugins-test-and-upstream-rhea_undici_url 57.04% <ø> (-0.07%) ⬇️
plugins-valkey_vm_winston 54.03% <ø> (+0.03%) ⬆️
plugins-ws 54.93% <ø> (-0.05%) ⬇️
profiling 58.26% <ø> (-0.04%) ⬇️
serverless-aws-sdk-aws-sdk 50.78% <ø> (-0.04%) ⬇️
serverless-aws-sdk-bedrockruntime 50.75% <ø> (-0.05%) ⬇️
serverless-aws-sdk-client 52.09% <ø> (-0.05%) ⬇️
serverless-aws-sdk-dynamodb 51.80% <ø> (-0.05%) ⬇️
serverless-aws-sdk-eventbridge 46.46% <ø> (-0.05%) ⬇️
serverless-aws-sdk-kinesis 54.79% <ø> (-0.05%) ⬇️
serverless-aws-sdk-lambda 52.87% <ø> (-0.05%) ⬇️
serverless-aws-sdk-s3 51.59% <ø> (-0.05%) ⬇️
serverless-aws-sdk-serverless-peer-service 54.82% <ø> (-0.05%) ⬇️
serverless-aws-sdk-sns 55.54% <ø> (-0.05%) ⬇️
serverless-aws-sdk-sqs 55.96% <ø> (-0.05%) ⬇️
serverless-aws-sdk-stepfunctions 51.36% <ø> (-0.05%) ⬇️
serverless-aws-sdk-util 48.54% <ø> (-0.05%) ⬇️
serverless-bucket-0 55.24% <ø> (ø)
serverless-bucket-1 56.06% <ø> (-0.05%) ⬇️
test-optimization-cucumber 72.95% <100.00%> (-0.02%) ⬇️
test-optimization-cypress 66.36% <0.00%> (+0.10%) ⬆️
test-optimization-jest 74.30% <100.00%> (-0.02%) ⬇️
test-optimization-mocha 74.69% <100.00%> (+0.06%) ⬆️
test-optimization-playwright-playwright-atr 61.50% <0.00%> (+0.02%) ⬆️
test-optimization-playwright-playwright-efd 61.69% <0.00%> (+0.03%) ⬆️
test-optimization-playwright-playwright-final-status 61.67% <0.00%> (+0.02%) ⬆️
test-optimization-playwright-playwright-impacted-tests 61.39% <0.00%> (+0.19%) ⬆️
test-optimization-playwright-playwright-reporting 61.28% <0.00%> (+0.02%) ⬆️
test-optimization-playwright-playwright-test-management 62.23% <0.00%> (-0.09%) ⬇️
test-optimization-playwright-playwright-test-span 61.42% <0.00%> (-0.02%) ⬇️
test-optimization-selenium 60.72% <0.00%> (-0.14%) ⬇️
test-optimization-testopt 59.16% <0.00%> (+0.08%) ⬆️
test-optimization-vitest 71.40% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BridgeAR
BridgeAR marked this pull request as ready for review July 14, 2026 14:22
@BridgeAR
BridgeAR requested a review from a team as a code owner July 14, 2026 14:22

@datadog-prod-us1-5 datadog-prod-us1-5 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

PR resolves the git-upload promise immediately when git upload is disabled, preventing 60-second timeout delays in dependent code paths (getSkippableSuites, getLibraryConfiguration). The fix is minimal and correct — calling _resolveGit() with no error when disabled is the intended behavior. New test validates the promise resolves with undefined and no HTTP requests occur.

Was this helpful? React 👍 or 👎

📊 Validated against 1 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit 0a36f32 · What is Autotest? · Any feedback? Reach out in #autotest

@juan-fernandez juan-fernandez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great!

so settings and skippable-test requests waited for the 60-second fallback.

any chance we could create an integration test in any test framework (say jest) that would fail without these changes? This seems like it could have significant user impact?

BridgeAR added 2 commits July 15, 2026 13:03
Disabling git upload left readiness unresolved, so settings requests waited for the 60-second fallback.
This catches disabled uploads leaving settings and skippable requests blocked on the 60-second fallback.
@BridgeAR
BridgeAR force-pushed the BridgeAR/2026-07-14-fix-disabled-git-readiness branch from 0a36f32 to 44cdfc4 Compare July 15, 2026 11:08
@juan-fernandez

Copy link
Copy Markdown
Collaborator

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: 44cdfc4a85

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@juan-fernandez juan-fernandez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this was a good catch

@BridgeAR
BridgeAR merged commit 9323e53 into master Jul 15, 2026
806 of 808 checks passed
@BridgeAR
BridgeAR deleted the BridgeAR/2026-07-14-fix-disabled-git-readiness branch July 15, 2026 12:25
dd-octo-sts Bot pushed a commit that referenced this pull request Jul 16, 2026
Disabling git upload left readiness unresolved, so settings requests waited for the 60-second fallback.
@dd-octo-sts dd-octo-sts Bot mentioned this pull request Jul 16, 2026
dd-octo-sts Bot pushed a commit that referenced this pull request Jul 16, 2026
Disabling git upload left readiness unresolved, so settings requests waited for the 60-second fallback.
@dd-octo-sts dd-octo-sts Bot mentioned this pull request Jul 16, 2026
juan-fernandez pushed a commit that referenced this pull request Jul 16, 2026
Disabling git upload left readiness unresolved, so settings requests waited for the 60-second fallback.
juan-fernandez pushed a commit that referenced this pull request Jul 16, 2026
Disabling git upload left readiness unresolved, so settings requests waited for the 60-second fallback.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants