Skip to content

ci(lint): revert editorconfig checker from npm to docker#9315

Merged
BridgeAR merged 6 commits into
masterfrom
rochdev/revert-editorconfig-npm-to-docker
Jul 14, 2026
Merged

ci(lint): revert editorconfig checker from npm to docker#9315
BridgeAR merged 6 commits into
masterfrom
rochdev/revert-editorconfig-npm-to-docker

Conversation

@rochdev

@rochdev rochdev commented Jul 13, 2026

Copy link
Copy Markdown
Member

Summary

  • Reverts the lint:editorconfig script in package.json from editorconfig-checker (npm) back to docker run --rm --volume=$PWD:/check mstruebing/editorconfig-checker
  • Reverts the lint-editorconfig CI job in project.yml to use Docker directly instead of installing Node and npm dependencies

Motivation

Installing editorconfig-checker from npm makes unauthenticated calls to the GitHub API, which causes rate limit errors in CI. The Docker-based approach pulls the image directly and avoids this issue entirely.

Test plan

  • Ran npm run lint:editorconfig locally — passes cleanly with Docker

Generated by Claude Code

Installing editorconfig-checker from npm makes unauthenticated calls to
the GitHub API, causing rate limit errors in CI. The Docker-based approach
avoids this issue.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
@dd-octo-sts

dd-octo-sts Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 6.71 MB
Deduped: 7.37 MB
No deduping: 7.37 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.3.1 | 122.62 kB | 438.86 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Unpinned `:latest` image references can break CI on upstream updates
without any repo change. Pin to the current digest for reproducible builds.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jul 13, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 96.57% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1605bd1 | Docs | Datadog PR Page | Give us feedback!

rochdev and others added 3 commits July 13, 2026 18:51
Centralises the image digest in .github/editorconfig-checker/Dockerfile
so Dependabot can update it automatically via the docker ecosystem.
Both the CI job and the local npm script build from the same Dockerfile,
eliminating the duplicated digest. Also removes the unused
editorconfig-checker npm devDependency.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
@rochdev
rochdev marked this pull request as ready for review July 13, 2026 22:56
@rochdev
rochdev requested a review from a team as a code owner July 13, 2026 22:56
@pr-commenter

pr-commenter Bot commented Jul 13, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-07-14 00:49:07

Comparing candidate commit 1605bd1 in PR branch rochdev/revert-editorconfig-npm-to-docker with baseline commit c708123 in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 0 performance regressions! Performance is the same for 2320 metrics, 38 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:appsec-appsec-enabled-24

  • unstable execution_time [-206.226ms; +209.862ms] or [-7.744%; +7.881%]

scenario:appsec-appsec-enabled-26

  • unstable execution_time [-243.728ms; +236.832ms] or [-9.518%; +9.248%]

scenario:appsec-appsec-enabled-with-attacks-24

  • unstable execution_time [-160.980ms; +156.210ms] or [-5.223%; +5.069%]

scenario:appsec-appsec-enabled-with-attacks-26

  • unstable execution_time [-190.522ms; +184.215ms] or [-6.546%; +6.329%]

scenario:appsec-control-20

  • unstable execution_time [-120.401ms; +117.651ms] or [-7.337%; +7.170%]

scenario:appsec-control-24

  • unstable execution_time [-115299.781µs; +116571.115µs] or [-9.318%; +9.421%]

scenario:appsec-control-26

  • unstable execution_time [-131.167ms; +121.839ms] or [-10.530%; +9.781%]

scenario:appsec-iast-with-vulnerability-control-20

  • unstable execution_time [-29255.486µs; +27266.185µs] or [-5.342%; +4.979%]

scenario:appsec-iast-with-vulnerability-iast-enabled-always-active-20

  • unstable execution_time [-31.332ms; +27.897ms] or [-5.680%; +5.057%]

scenario:debugger-line-probe-with-snapshot-default-24

  • unstable cpu_user_time [-1.798s; +3.997s] or [-20.160%; +44.823%]
  • unstable execution_time [-1.886s; +4.092s] or [-19.603%; +42.542%]
  • unstable instructions [-15.3G instructions; +33.9G instructions] or [-20.904%; +46.422%]
  • unstable max_rss_usage [-7.552MB; +16.772MB] or [-4.748%; +10.546%]
  • unstable throughput [-1108.062op/s; +505.415op/s] or [-31.902%; +14.551%]

scenario:debugger-line-probe-with-snapshot-minimal-24

  • unstable cpu_user_time [-2755.552ms; +2560.803ms] or [-30.425%; +28.275%]
  • unstable execution_time [-2889.432ms; +2745.823ms] or [-29.578%; +28.108%]
  • unstable instructions [-23278.5M instructions; +22079.0M instructions] or [-31.378%; +29.761%]
  • unstable max_rss_usage [-11731.828KB; +11029.428KB] or [-7.348%; +6.908%]
  • unstable throughput [-705.839op/s; +772.134op/s] or [-20.556%; +22.487%]

scenario:debugger-line-probe-with-snapshot-minimal-26

  • unstable cpu_user_time [-3.200s; +0.466s] or [-31.624%; +4.606%]
  • unstable execution_time [-3.256s; +0.519s] or [-29.985%; +4.781%]
  • unstable instructions [-28.5G instructions; +3.9G instructions] or [-33.568%; +4.580%]
  • unstable throughput [-113.814op/s; +657.804op/s] or [-3.661%; +21.160%]

scenario:debugger-line-probe-without-snapshot-26

  • unstable cpu_user_time [-1809.434ms; +575.467ms] or [-19.281%; +6.132%]
  • unstable execution_time [-1805.987ms; +578.897ms] or [-17.885%; +5.733%]
  • unstable instructions [-16.1G instructions; +5.2G instructions] or [-20.566%; +6.691%]
  • unstable throughput [-128.886op/s; +398.578op/s] or [-3.968%; +12.272%]

scenario:dogstatsd-with-tags-20

  • unstable cpu_user_time [-151.398ms; +549.243ms] or [-3.195%; +11.591%]
  • unstable execution_time [-153.616ms; +544.679ms] or [-3.190%; +11.310%]
  • unstable throughput [-188525.853op/s; +52944.618op/s] or [-10.814%; +3.037%]

scenario:plugin-claude-agent-sdk-compact-stream-scan-26

  • unstable cpu_usage_percentage [-4.078%; +6.097%]

scenario:plugin-graphql-long-with-depth-off-20

  • unstable max_rss_usage [-5.424MB; +9.173MB] or [-4.237%; +7.166%]

scenario:plugin-graphql-long-with-depth-on-max-20

  • unstable cpu_user_time [-698.287ms; +760.987ms] or [-5.424%; +5.911%]
  • unstable execution_time [-695.999ms; +767.838ms] or [-5.289%; +5.835%]
  • unstable throughput [-3.482op/s; +3.187op/s] or [-5.694%; +5.211%]

scenario:plugin-mongodb-core-plain-find-26

  • unstable execution_time [-139.003ms; +78.972ms] or [-6.656%; +3.782%]

scenario:plugin-pg-service-26

  • unstable execution_time [-32.769ms; +68.520ms] or [-3.594%; +7.515%]

scenario:test-optimization-large-suite-20

  • unstable max_rss_usage [-3.251MB; +6.771MB] or [-4.099%; +8.537%]

@BridgeAR BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be hard to understand without a comment for future changes. I could absolutely imagine myself to undo this 😅

Comment thread package.json
"lint:codeowners": "codeowners-audit",
"lint:codeowners:ci": "codeowners-audit --glob='**/*.spec.js' --glob='benchmark/sirun/**' --glob='.agents/**' --glob='.claude/**' --glob='integration-tests/**'",
"lint:editorconfig": "editorconfig-checker",
"lint:editorconfig": "docker build -q -t ec .github/editorconfig-checker && docker run --rm --volume=$PWD:/check ec",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just keep it local as before? The CI job was already changed to use the docker container and these could as such diverge anyway and using a local dev dependency seems nicer than the docker container

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both implementations diverge in how they report, so it made more sense to use the same approach since that ensures consistency both locally and in CI, and there is only 1 version to update with Dependabot, ensuring that will not diverge either.

@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.60%. Comparing base (c708123) to head (1605bd1).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9315      +/-   ##
==========================================
+ Coverage   96.59%   96.60%   +0.01%     
==========================================
  Files         919      919              
  Lines      121692   121692              
  Branches    20294    20771     +477     
==========================================
+ Hits       117549   117564      +15     
+ Misses       4143     4128      -15     
Flag Coverage Δ
aiguard 53.56% <ø> (-0.05%) ⬇️
aiguard-integration 57.01% <ø> (ø)
apm-bucket-0 53.79% <ø> (-0.05%) ⬇️
apm-bucket-1 58.07% <ø> (-0.05%) ⬇️
apm-bucket-2 56.11% <ø> (-0.05%) ⬇️
apm-capabilities-tracing 60.34% <ø> (ø)
apm-integrations-aerospike 52.94% <ø> (-0.05%) ⬇️
apm-integrations-confluentinc-kafka-javascript 57.06% <ø> (-0.05%) ⬇️
apm-integrations-couchbase 53.27% <ø> (-0.05%) ⬇️
apm-integrations-http 57.96% <ø> (-0.05%) ⬇️
apm-integrations-kafkajs 57.71% <ø> (-0.05%) ⬇️
apm-integrations-next 54.24% <ø> (-0.05%) ⬇️
apm-integrations-prisma 54.17% <ø> (-0.05%) ⬇️
apm-integrations-tedious 53.04% <ø> (-0.05%) ⬇️
appsec 69.01% <ø> (-0.03%) ⬇️
appsec-express_fastify_graphql 65.68% <ø> (-0.05%) ⬇️
appsec-integration 51.98% <ø> (ø)
appsec-kafka_ldapjs_lodash 59.09% <ø> (-0.04%) ⬇️
appsec-mongodb-core_mongoose_mysql 62.25% <ø> (-0.04%) ⬇️
appsec-next 52.85% <ø> (-0.04%) ⬇️
appsec-node-serialize_passport_postgres 61.88% <ø> (-0.04%) ⬇️
appsec-sourcing_stripe_template 60.34% <ø> (-0.04%) ⬇️
debugger 65.70% <ø> (-0.02%) ⬇️
instrumentations-bucket-0 48.75% <ø> (-0.05%) ⬇️
instrumentations-bucket-1 54.96% <ø> (-0.05%) ⬇️
instrumentations-bucket-10 56.62% <ø> (-0.05%) ⬇️
instrumentations-bucket-11 48.74% <ø> (-0.05%) ⬇️
instrumentations-bucket-12 48.85% <ø> (-0.05%) ⬇️
instrumentations-bucket-13 48.68% <ø> (-0.05%) ⬇️
instrumentations-bucket-2 49.75% <ø> (-0.05%) ⬇️
instrumentations-bucket-3 53.83% <ø> (-0.05%) ⬇️
instrumentations-bucket-4 49.16% <ø> (-0.05%) ⬇️
instrumentations-bucket-5 53.01% <ø> (-0.05%) ⬇️
instrumentations-bucket-6 55.60% <ø> (-0.05%) ⬇️
instrumentations-bucket-7 53.61% <ø> (-0.05%) ⬇️
instrumentations-bucket-8 54.64% <ø> (-0.05%) ⬇️
instrumentations-bucket-9 56.10% <ø> (-0.04%) ⬇️
instrumentations-instrumentation-couchbase 48.18% <ø> (-0.05%) ⬇️
instrumentations-integration-esbuild 33.98% <ø> (ø)
llmobs-ai_anthropic_bedrock 57.73% <ø> (-0.04%) ⬇️
llmobs-bucket-1 56.99% <ø> (-0.04%) ⬇️
llmobs-openai 57.56% <ø> (-0.04%) ⬇️
llmobs-sdk 59.95% <ø> (-0.05%) ⬇️
llmobs-vertex-ai 54.21% <ø> (-0.05%) ⬇️
master-coverage 96.60% <ø> (?)
openfeature 54.53% <ø> (-0.09%) ⬇️
openfeature-unit 49.83% <ø> (-0.05%) ⬇️
platform-core_esbuild_instrumentations-misc 38.47% <ø> (-0.03%) ⬇️
platform-integration 62.23% <ø> (+0.04%) ⬆️
platform-shimmer_unit-guardrails_webpack 37.29% <ø> (-0.03%) ⬇️
plugins-azure-event-hubs_body-parser_bullmq ?
plugins-bucket-0 53.18% <ø> (-0.05%) ⬇️
plugins-bucket-1 55.08% <ø> (?)
plugins-bucket-11 55.60% <ø> (-1.17%) ⬇️
plugins-bucket-17 ?
plugins-bucket-18 57.07% <ø> (-0.50%) ⬇️
plugins-bucket-19 55.35% <ø> (-1.83%) ⬇️
plugins-bucket-20 57.44% <ø> (-1.96%) ⬇️
plugins-bucket-3 ?
plugins-bucket-4 53.85% <ø> (?)
plugins-bullmq_cassandra_cookie 57.36% <ø> (?)
plugins-cassandra_cookie_cookie-parser ?
plugins-cookie-parser_crypto_dd-trace-api 52.32% <ø> (?)
plugins-express-session_fastify_fetch ?
plugins-fetch_fs_generic-pool 54.54% <ø> (?)
plugins-fs_generic-pool_google-cloud-pubsub ?
plugins-google-cloud-pubsub_grpc_handlebars 59.86% <ø> (?)
plugins-grpc_handlebars_hapi ?
plugins-hapi_hono_ioredis 55.86% <ø> (?)
plugins-hono_ioredis_jest ?
plugins-jest_knex_langgraph 51.67% <ø> (?)
plugins-knex_langgraph_ldapjs ?
plugins-ldapjs_light-my-request_limitd-client 53.44% <ø> (?)
plugins-light-my-request_limitd-client_lodash ?
plugins-lodash_mariadb_memcached 54.21% <ø> (?)
plugins-mariadb_memcached_mercurius ?
plugins-moleculer_mongodb_mongodb-core 57.28% <ø> (?)
plugins-mongodb_mongodb-core_mongoose ?
plugins-mongoose_multer_mysql 54.71% <ø> (?)
plugins-multer_mysql_mysql2 ?
plugins-mysql2_nats_node-serialize 56.21% <ø> (?)
plugins-nats_node-serialize_opensearch ?
plugins-opensearch_passport-http_pino 55.05% <ø> (?)
plugins-passport-http_pino_postgres ?
plugins-postgres_process_pug 54.29% <ø> (?)
plugins-process_pug_redis ?
plugins-redis_router_sequelize 57.03% <ø> (?)
plugins-test-and-upstream-rhea_undici_url 57.00% <ø> (?)
plugins-undici_url_valkey ?
plugins-valkey_vm_winston 53.92% <ø> (?)
plugins-vm_winston_ws ?
plugins-ws 54.80% <ø> (?)
profiling 58.20% <ø> (-0.04%) ⬇️
serverless-aws-sdk-aws-sdk 50.67% <ø> (-0.04%) ⬇️
serverless-aws-sdk-bedrockruntime 50.69% <ø> (-0.05%) ⬇️
serverless-aws-sdk-client 51.97% <ø> (-0.05%) ⬇️
serverless-aws-sdk-dynamodb 51.75% <ø> (-0.05%) ⬇️
serverless-aws-sdk-eventbridge 46.26% <ø> (-0.05%) ⬇️
serverless-aws-sdk-kinesis 54.71% <ø> (-0.05%) ⬇️
serverless-aws-sdk-lambda 52.79% <ø> (-0.05%) ⬇️
serverless-aws-sdk-s3 51.54% <ø> (-0.05%) ⬇️
serverless-aws-sdk-serverless-peer-service 54.73% <ø> (-0.05%) ⬇️
serverless-aws-sdk-sns 55.48% <ø> (-0.05%) ⬇️
serverless-aws-sdk-sqs 55.91% <ø> (-0.05%) ⬇️
serverless-aws-sdk-stepfunctions 51.25% <ø> (-0.05%) ⬇️
serverless-aws-sdk-util 48.48% <ø> (-0.05%) ⬇️
serverless-bucket-0 55.23% <ø> (-0.01%) ⬇️
serverless-bucket-1 56.01% <ø> (-0.05%) ⬇️
test-optimization-cucumber 72.94% <ø> (-0.02%) ⬇️
test-optimization-cypress 66.33% <ø> (+0.01%) ⬆️
test-optimization-jest 74.30% <ø> (+0.02%) ⬆️
test-optimization-mocha 74.69% <ø> (+0.06%) ⬆️
test-optimization-playwright-playwright-atr 61.57% <ø> (+0.02%) ⬆️
test-optimization-playwright-playwright-efd 61.76% <ø> (+0.09%) ⬆️
test-optimization-playwright-playwright-final-status 61.71% <ø> (-0.01%) ⬇️
test-optimization-playwright-playwright-impacted-tests 61.44% <ø> (+0.16%) ⬆️
test-optimization-playwright-playwright-reporting 61.34% <ø> (+0.02%) ⬆️
test-optimization-playwright-playwright-test-management 62.41% <ø> (-0.12%) ⬇️
test-optimization-playwright-playwright-test-span 61.47% <ø> (-0.07%) ⬇️
test-optimization-selenium 60.66% <ø> (-0.14%) ⬇️
test-optimization-testopt 59.15% <ø> (+0.08%) ⬆️
test-optimization-vitest 71.58% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rochdev

rochdev commented Jul 14, 2026

Copy link
Copy Markdown
Member Author

This will be hard to understand without a comment for future changes. I could absolutely imagine myself to undo this 😅

You already did here 😅 292a22f

@BridgeAR
BridgeAR merged commit 9f38ec1 into master Jul 14, 2026
657 checks passed
@BridgeAR
BridgeAR deleted the rochdev/revert-editorconfig-npm-to-docker branch July 14, 2026 12:37
This was referenced Jul 14, 2026
juan-fernandez pushed a commit that referenced this pull request Jul 14, 2026
Installing editorconfig-checker from npm makes unauthenticated calls to
the GitHub API, causing rate limit errors in CI. The Docker-based approach
avoids this issue.

Centralises the image digest in .github/editorconfig-checker/Dockerfile
so Dependabot can update it automatically via the docker ecosystem.
Both the CI job and the local npm script build from the same Dockerfile,
eliminating the duplicated digest. Also removes the unused
editorconfig-checker npm devDependency.
juan-fernandez pushed a commit that referenced this pull request Jul 14, 2026
Installing editorconfig-checker from npm makes unauthenticated calls to
the GitHub API, causing rate limit errors in CI. The Docker-based approach
avoids this issue.

Centralises the image digest in .github/editorconfig-checker/Dockerfile
so Dependabot can update it automatically via the docker ecosystem.
Both the CI job and the local npm script build from the same Dockerfile,
eliminating the duplicated digest. Also removes the unused
editorconfig-checker npm devDependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants