ci(lint): revert editorconfig checker from npm to docker#9315
Conversation
Installing editorconfig-checker from npm makes unauthenticated calls to the GitHub API, causing rate limit errors in CI. The Docker-based approach avoids this issue. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Overall package sizeSelf size: 6.71 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.3.1 | 122.62 kB | 438.86 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Unpinned `:latest` image references can break CI on upstream updates without any repo change. Pin to the current digest for reproducible builds. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 1605bd1 | Docs | Datadog PR Page | Give us feedback! |
Centralises the image digest in .github/editorconfig-checker/Dockerfile so Dependabot can update it automatically via the docker ecosystem. Both the CI job and the local npm script build from the same Dockerfile, eliminating the duplicated digest. Also removes the unused editorconfig-checker npm devDependency. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
BenchmarksBenchmark execution time: 2026-07-14 00:49:07 Comparing candidate commit 1605bd1 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 2320 metrics, 38 unstable metrics.
|
BridgeAR
left a comment
There was a problem hiding this comment.
This will be hard to understand without a comment for future changes. I could absolutely imagine myself to undo this 😅
| "lint:codeowners": "codeowners-audit", | ||
| "lint:codeowners:ci": "codeowners-audit --glob='**/*.spec.js' --glob='benchmark/sirun/**' --glob='.agents/**' --glob='.claude/**' --glob='integration-tests/**'", | ||
| "lint:editorconfig": "editorconfig-checker", | ||
| "lint:editorconfig": "docker build -q -t ec .github/editorconfig-checker && docker run --rm --volume=$PWD:/check ec", |
There was a problem hiding this comment.
Should we just keep it local as before? The CI job was already changed to use the docker container and these could as such diverge anyway and using a local dev dependency seems nicer than the docker container
There was a problem hiding this comment.
Both implementations diverge in how they report, so it made more sense to use the same approach since that ensures consistency both locally and in CI, and there is only 1 version to update with Dependabot, ensuring that will not diverge either.
You already did here 😅 292a22f |
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Installing editorconfig-checker from npm makes unauthenticated calls to the GitHub API, causing rate limit errors in CI. The Docker-based approach avoids this issue. Centralises the image digest in .github/editorconfig-checker/Dockerfile so Dependabot can update it automatically via the docker ecosystem. Both the CI job and the local npm script build from the same Dockerfile, eliminating the duplicated digest. Also removes the unused editorconfig-checker npm devDependency.
Installing editorconfig-checker from npm makes unauthenticated calls to the GitHub API, causing rate limit errors in CI. The Docker-based approach avoids this issue. Centralises the image digest in .github/editorconfig-checker/Dockerfile so Dependabot can update it automatically via the docker ecosystem. Both the CI job and the local npm script build from the same Dockerfile, eliminating the duplicated digest. Also removes the unused editorconfig-checker npm devDependency.
Summary
lint:editorconfigscript inpackage.jsonfromeditorconfig-checker(npm) back todocker run --rm --volume=$PWD:/check mstruebing/editorconfig-checkerlint-editorconfigCI job inproject.ymlto use Docker directly instead of installing Node and npm dependenciesMotivation
Installing
editorconfig-checkerfrom npm makes unauthenticated calls to the GitHub API, which causes rate limit errors in CI. The Docker-based approach pulls the image directly and avoids this issue entirely.Test plan
npm run lint:editorconfiglocally — passes cleanly with Docker