fix(config): handle invalid programmatic option values#9312
Conversation
Overall package sizeSelf size: 6.71 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.3.1 | 122.62 kB | 438.86 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: ede853a | Docs | Datadog PR Page | Give us feedback! |
BenchmarksBenchmark execution time: 2026-07-14 11:10:47 Comparing candidate commit ede853a in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 2305 metrics, 53 unstable metrics.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9312 +/- ##
========================================
Coverage 96.60% 96.60%
========================================
Files 919 919
Lines 121692 121823 +131
Branches 21299 20332 -967
========================================
+ Hits 117562 117692 +130
- Misses 4130 4131 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Invalid programmatic values could reach option-specific transforms and abort tracer startup. Normalize safe primitive conversions and ignore invalid inputs so lower-priority environment or default values remain active.
This prevents programmatic arrays with numeric or boolean entries from falling back to defaults.
1cac9ca to
fd5e9d8
Compare
Co-authored-by: Ruben Bridgewater <[email protected]>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ede853af3a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Invalid programmatic values could reach option-specific transforms and abort tracer startup. Normalize safe primitive conversions and ignore invalid inputs so lower-priority environment or default values remain active.
Invalid programmatic values could reach option-specific transforms and abort tracer startup. Normalize safe primitive conversions and ignore invalid inputs so lower-priority environment or default values remain active.
Summary
Invalid programmatic configuration values could reach option-specific transforms and abort tracer startup. This adds safe per-type coercion and ignores invalid inputs so lower-priority environment or default values remain active.
Refs: #9226