Skip to content

fix(appsec): log the error when the native WAF binding fails to load#9288

Merged
BridgeAR merged 2 commits into
masterfrom
ccapell/richer-log-for-native-appsec-load-error
Jul 13, 2026
Merged

fix(appsec): log the error when the native WAF binding fails to load#9288
BridgeAR merged 2 commits into
masterfrom
ccapell/richer-log-for-native-appsec-load-error

Conversation

@CarlesDD

@CarlesDD CarlesDD commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

When WAFManager._loadDDWAF fails to load @datadog/native-appsec (missing prebuild, incompatible arch/libc, corrupted binary, etc.), it now passes the caught error to log.error instead of logging only a generic static message. This matches the existing pattern used elsewhere (like here)

Motivation

The current log line ('[ASM] AppSec could not load native package. In-app WAF features will not be available.') discards the original error object, so the real root cause (why the binding failed to load) is invisible with DD_TRACE_DEBUG enabled. Customers and support only see that the WAF didn't load, not why. This came up while investigating recurring WAF init failures across several customer environments during the June 2026 site-up review, where this was the identified "quick win" to reduce blindness on this class of issue.

Additional Notes

  • No behavior change beyond the log call: the error is still re-thrown after logging, Reporter.reportWafInit is still called the same way.
  • Added test coverage in waf_manager.spec.js asserting log.error is called with the original error and that the error is still thrown.
  • No new public API, no config changes, no breaking changes.

@dd-octo-sts

dd-octo-sts Bot commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 6.71 MB
Deduped: 7.37 MB
No deduping: 7.37 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.3.1 | 122.62 kB | 438.86 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter

pr-commenter Bot commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-07-13 10:01:38

Comparing candidate commit 227e856 in PR branch ccapell/richer-log-for-native-appsec-load-error with baseline commit 66bce78 in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 0 performance regressions! Performance is the same for 2307 metrics, 51 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:appsec-appsec-enabled-24

  • unstable execution_time [-222.064ms; +206.802ms] or [-8.321%; +7.749%]

scenario:appsec-appsec-enabled-26

  • unstable execution_time [-238.161ms; +235.146ms] or [-9.312%; +9.194%]

scenario:appsec-appsec-enabled-with-attacks-26

  • unstable execution_time [-164.226ms; +190.509ms] or [-5.698%; +6.610%]

scenario:appsec-control-20

  • unstable execution_time [-121.809ms; +124.099ms] or [-7.442%; +7.582%]

scenario:appsec-control-24

  • unstable execution_time [-116160.200µs; +117441.333µs] or [-9.371%; +9.475%]

scenario:appsec-control-26

  • unstable execution_time [-121905.948µs; +120274.748µs] or [-9.891%; +9.759%]

scenario:appsec-iast-no-vulnerability-control-20

  • unstable execution_time [-24.609ms; +6.014ms] or [-9.323%; +2.278%]

scenario:appsec-iast-no-vulnerability-iast-enabled-always-active-20

  • unstable execution_time [-11.376ms; +17.572ms] or [-4.469%; +6.903%]

scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-20

  • unstable execution_time [-14.761ms; +11.206ms] or [-5.766%; +4.377%]

scenario:appsec-iast-with-vulnerability-control-20

  • unstable execution_time [-30.753ms; +38.435ms] or [-5.583%; +6.978%]

scenario:debugger-line-probe-with-snapshot-default-24

  • unstable cpu_user_time [-2243.722ms; +2275.632ms] or [-25.001%; +25.357%]
  • unstable execution_time [-2271.344ms; +2275.805ms] or [-23.443%; +23.489%]
  • unstable instructions [-19167.6M instructions; +19281.8M instructions] or [-26.066%; +26.221%]
  • unstable max_rss_usage [-8816.774KB; +9050.374KB] or [-5.545%; +5.692%]
  • unstable throughput [-638.013op/s; +635.401op/s] or [-18.661%; +18.585%]

scenario:debugger-line-probe-with-snapshot-default-26

  • unstable cpu_user_time [-1778.077ms; +579.111ms] or [-18.921%; +6.162%]
  • unstable execution_time [-1795.600ms; +625.699ms] or [-17.731%; +6.178%]
  • unstable instructions [-16.0G instructions; +5.2G instructions] or [-20.502%; +6.675%]
  • unstable throughput [-145.425op/s; +393.962op/s] or [-4.490%; +12.163%]

scenario:debugger-line-probe-with-snapshot-minimal-24

  • unstable instructions [-3768.2M instructions; +3393.2M instructions] or [-5.785%; +5.210%]

scenario:debugger-line-probe-with-snapshot-minimal-26

  • unstable cpu_user_time [-2.111s; +4.579s] or [-21.132%; +45.832%]
  • unstable execution_time [-2.077s; +4.584s] or [-19.403%; +42.822%]
  • unstable instructions [-18.8G instructions; +40.6G instructions] or [-22.540%; +48.649%]
  • unstable max_rss_usage [-6.588MB; +14.019MB] or [-4.103%; +8.730%]
  • unstable throughput [-998.250op/s; +446.488op/s] or [-32.013%; +14.318%]

scenario:debugger-line-probe-without-snapshot-24

  • unstable cpu_user_time [-3005.854ms; +1897.247ms] or [-32.012%; +20.206%]
  • unstable execution_time [-3051.759ms; +1924.346ms] or [-30.229%; +19.061%]
  • unstable instructions [-25.8G instructions; +16.0G instructions] or [-33.412%; +20.693%]
  • unstable max_rss_usage [-12.563MB; +8.086MB] or [-7.799%; +5.020%]
  • unstable throughput [-556.943op/s; +849.850op/s] or [-16.695%; +25.475%]

scenario:debugger-line-probe-without-snapshot-26

  • unstable cpu_user_time [-2707.386ms; +4026.348ms] or [-25.616%; +38.096%]
  • unstable execution_time [-2659.661ms; +4024.739ms] or [-23.490%; +35.547%]
  • unstable instructions [-25.0G instructions; +36.5G instructions] or [-28.171%; +41.127%]
  • unstable max_rss_usage [-8.920MB; +12.782MB] or [-5.474%; +7.845%]
  • unstable throughput [-882.462op/s; +559.949op/s] or [-29.613%; +18.790%]

scenario:dogstatsd-with-tags-20

  • unstable cpu_user_time [-173.344ms; +439.691ms] or [-3.489%; +8.850%]
  • unstable execution_time [-171.225ms; +434.891ms] or [-3.394%; +8.622%]
  • unstable throughput [-141360.124op/s; +63325.027op/s] or [-8.537%; +3.824%]

scenario:plugin-claude-agent-sdk-compact-stream-scan-20

  • unstable cpu_usage_percentage [-5.190%; +5.181%]

scenario:plugin-claude-agent-sdk-compact-stream-scan-26

  • unstable cpu_usage_percentage [-5.398%; +6.006%]

scenario:plugin-graphql-long-with-depth-on-max-20

  • unstable cpu_user_time [-758.237ms; +743.668ms] or [-5.906%; +5.792%]
  • unstable execution_time [-770.275ms; +749.829ms] or [-5.869%; +5.713%]
  • unstable throughput [-3.441op/s; +3.572op/s] or [-5.610%; +5.823%]

scenario:plugin-memcached-hashring-20

  • unstable cpu_user_time [-1360.969ms; +455.668ms] or [-26.135%; +8.750%]
  • unstable execution_time [-1371.981ms; +462.267ms] or [-26.298%; +8.861%]
  • unstable instructions [-10.0G instructions; +3.2G instructions] or [-16.783%; +5.437%]
  • unstable throughput [-251193.476op/s; +678293.836op/s] or [-3.229%; +8.720%]

scenario:plugin-pg-service-26

  • unstable cpu_usage_percentage [-10.354%; +6.774%]
  • unstable execution_time [-102.712ms; +170.360ms] or [-11.273%; +18.697%]
  • unstable throughput [-792884.906op/s; +461548.675op/s] or [-11.770%; +6.851%]

scenario:test-optimization-large-suite-20

  • unstable max_rss_usage [-3847.784KB; +4138.451KB] or [-4.853%; +5.219%]

@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented Jul 10, 2026 •
edited by datadog-prod-us1-3 Bot
Loading

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 96.53% (-0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 227e856 | Docs | Datadog PR Page | Give us feedback!

@codecov

codecov Bot commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.57%. Comparing base (66bce78) to head (227e856).

Additional details and impacted files 
@@           Coverage Diff            @@
##           master    #9288    +/-   ##
========================================
  Coverage   96.57%   96.57%            
========================================
  Files         918      918            
  Lines      121577   121577            
  Branches    21074    20703   -371     
========================================
  Hits       117407   117407            
  Misses       4170     4170
Flag Coverage Δ
aiguard 53.56% <ø> (-0.05%) ⬇️
aiguard-integration 57.01% <ø> (ø)
apm-bucket-0 53.79% <ø> (-0.05%) ⬇️
apm-bucket-1 58.08% <ø> (-0.05%) ⬇️
apm-bucket-2 56.11% <ø> (-0.05%) ⬇️
apm-capabilities-tracing 60.32% <ø> (ø)
apm-integrations-aerospike 52.94% <ø> (-0.05%) ⬇️
apm-integrations-confluentinc-kafka-javascript 57.06% <ø> (-0.05%) ⬇️
apm-integrations-couchbase 53.27% <ø> (-0.05%) ⬇️
apm-integrations-http 57.96% <0.00%> (-0.05%) ⬇️
apm-integrations-kafkajs 57.71% <ø> (-0.06%) ⬇️
apm-integrations-next 54.24% <ø> (-0.05%) ⬇️
apm-integrations-prisma 54.17% <ø> (-0.05%) ⬇️
apm-integrations-tedious 53.04% <ø> (-0.05%) ⬇️
appsec 68.96% <100.00%> (-0.04%) ⬇️
appsec-express_fastify_graphql 65.59% <0.00%> (-0.05%) ⬇️
appsec-integration 45.59% <0.00%> (ø)
appsec-kafka_ldapjs_lodash 59.09% <ø> (-0.05%) ⬇️
appsec-mongodb-core_mongoose_mysql 62.25% <0.00%> (-0.04%) ⬇️
appsec-next 52.85% <0.00%> (-0.04%) ⬇️
appsec-node-serialize_passport_postgres 61.88% <0.00%> (-0.04%) ⬇️
appsec-sourcing_stripe_template 60.34% <0.00%> (-0.04%) ⬇️
debugger 65.73% <ø> (-0.02%) ⬇️
instrumentations-bucket-0 48.75% <ø> (-0.05%) ⬇️
instrumentations-bucket-1 54.96% <ø> (-0.05%) ⬇️
instrumentations-bucket-10 56.63% <0.00%> (-0.05%) ⬇️
instrumentations-bucket-11 48.74% <ø> (-0.05%) ⬇️
instrumentations-bucket-12 48.84% <ø> (-0.05%) ⬇️
instrumentations-bucket-13 48.68% <ø> (-0.05%) ⬇️
instrumentations-bucket-2 49.74% <ø> (-0.05%) ⬇️
instrumentations-bucket-3 53.83% <ø> (-0.05%) ⬇️
instrumentations-bucket-4 49.16% <ø> (-0.05%) ⬇️
instrumentations-bucket-5 53.01% <ø> (-0.05%) ⬇️
instrumentations-bucket-6 55.60% <ø> (-0.05%) ⬇️
instrumentations-bucket-7 53.61% <ø> (-0.05%) ⬇️
instrumentations-bucket-8 54.64% <ø> (-0.05%) ⬇️
instrumentations-bucket-9 56.10% <0.00%> (-0.04%) ⬇️
instrumentations-instrumentation-couchbase 48.18% <ø> (-0.05%) ⬇️
instrumentations-integration-esbuild 33.96% <ø> (ø)
llmobs-ai_anthropic_bedrock 57.73% <ø> (-0.04%) ⬇️
llmobs-bucket-1 56.80% <ø> (-0.04%) ⬇️
llmobs-openai 57.56% <ø> (-0.04%) ⬇️
llmobs-sdk 59.95% <ø> (-0.05%) ⬇️
llmobs-vertex-ai 54.21% <ø> (-0.05%) ⬇️
master-coverage 96.57% <100.00%> (?)
openfeature 54.62% <ø> (ø)
openfeature-unit 49.83% <ø> (-0.05%) ⬇️
platform-core_esbuild_instrumentations-misc 38.46% <ø> (-0.03%) ⬇️
platform-integration 62.24% <ø> (ø)
platform-shimmer_unit-guardrails_webpack 37.29% <ø> (-0.03%) ⬇️
plugins-bucket-0 53.18% <ø> (-0.05%) ⬇️
plugins-bucket-1 55.09% <ø> (ø)
plugins-bucket-11 55.60% <ø> (-0.05%) ⬇️
plugins-bucket-18 57.08% <ø> (-0.05%) ⬇️
plugins-bucket-19 55.36% <ø> (-0.05%) ⬇️
plugins-bucket-20 57.44% <ø> (-0.05%) ⬇️
plugins-bucket-4 53.85% <ø> (-0.05%) ⬇️
plugins-bullmq_cassandra_cookie 57.39% <ø> (-0.05%) ⬇️
plugins-cookie-parser_crypto_dd-trace-api 52.32% <ø> (-0.05%) ⬇️
plugins-fetch_fs_generic-pool 54.46% <ø> (-0.13%) ⬇️
plugins-google-cloud-pubsub_grpc_handlebars 59.87% <ø> (-0.05%) ⬇️
plugins-hapi_hono_ioredis 55.86% <ø> (-0.05%) ⬇️
plugins-jest_knex_langgraph 51.67% <ø> (-0.05%) ⬇️
plugins-ldapjs_light-my-request_limitd-client 53.42% <ø> (-0.05%) ⬇️
plugins-lodash_mariadb_memcached 54.21% <ø> (-0.05%) ⬇️
plugins-moleculer_mongodb_mongodb-core 57.29% <ø> (-0.05%) ⬇️
plugins-mongoose_multer_mysql 54.71% <ø> (-0.05%) ⬇️
plugins-mysql2_nats_node-serialize 56.21% <ø> (-0.05%) ⬇️
plugins-opensearch_passport-http_pino 55.05% <ø> (-0.05%) ⬇️
plugins-postgres_process_pug 54.29% <ø> (-0.05%) ⬇️
plugins-redis_router_sequelize 57.03% <ø> (-0.03%) ⬇️
plugins-test-and-upstream-rhea_undici_url 57.01% <ø> (-0.07%) ⬇️
plugins-valkey_vm_winston 53.92% <ø> (+0.03%) ⬆️
plugins-ws 54.80% <ø> (-0.05%) ⬇️
profiling 58.20% <ø> (-0.05%) ⬇️
serverless-aws-sdk-aws-sdk 50.67% <ø> (-0.04%) ⬇️
serverless-aws-sdk-bedrockruntime 50.69% <ø> (-0.05%) ⬇️
serverless-aws-sdk-client 51.97% <ø> (-0.05%) ⬇️
serverless-aws-sdk-dynamodb 51.78% <ø> (-0.05%) ⬇️
serverless-aws-sdk-eventbridge 46.25% <ø> (-0.05%) ⬇️
serverless-aws-sdk-kinesis 54.71% <ø> (-0.05%) ⬇️
serverless-aws-sdk-lambda 52.79% <ø> (-0.05%) ⬇️
serverless-aws-sdk-s3 51.53% <ø> (-0.05%) ⬇️
serverless-aws-sdk-serverless-peer-service 54.73% <ø> (-0.05%) ⬇️
serverless-aws-sdk-sns 55.48% <ø> (-0.05%) ⬇️
serverless-aws-sdk-sqs 55.91% <ø> (-0.05%) ⬇️
serverless-aws-sdk-stepfunctions 51.25% <ø> (-0.05%) ⬇️
serverless-aws-sdk-util 48.48% <ø> (-0.05%) ⬇️
serverless-bucket-0 55.23% <ø> (ø)
serverless-bucket-1 56.01% <ø> (-0.05%) ⬇️
test-optimization-cucumber 72.96% <ø> (-0.02%) ⬇️
test-optimization-cypress 66.39% <ø> (+0.06%) ⬆️
test-optimization-jest 73.89% <ø> (-0.05%) ⬇️
test-optimization-mocha 74.31% <ø> (+0.04%) ⬆️
test-optimization-playwright-playwright-atr 61.57% <ø> (-0.02%) ⬇️
test-optimization-playwright-playwright-efd 61.76% <ø> (-0.01%) ⬇️
test-optimization-playwright-playwright-final-status 61.72% <ø> (+0.05%) ⬆️
test-optimization-playwright-playwright-impacted-tests 61.44% <ø> (+0.15%) ⬆️
test-optimization-playwright-playwright-reporting 61.34% <ø> (-0.02%) ⬇️
test-optimization-playwright-playwright-test-management 62.25% <ø> (-0.13%) ⬇️
test-optimization-playwright-playwright-test-span 61.48% <ø> (-0.08%) ⬇️
test-optimization-selenium 60.67% <ø> (-0.12%) ⬇️
test-optimization-testopt 59.16% <ø> (+0.08%) ⬆️
test-optimization-vitest 71.58% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CarlesDD CarlesDD self-assigned this Jul 13, 2026
@CarlesDD
CarlesDD marked this pull request as ready for review July 13, 2026 09:46
@CarlesDD
CarlesDD requested a review from a team as a code owner July 13, 2026 09:46
@BridgeAR
BridgeAR merged commit 5eeb77f into master Jul 13, 2026
657 checks passed
@BridgeAR
BridgeAR deleted the ccapell/richer-log-for-native-appsec-load-error branch July 13, 2026 17:10
dd-octo-sts Bot pushed a commit that referenced this pull request Jul 14, 2026
@CarlesDD @BridgeAR
fix(appsec): log the error when the native WAF binding fails to load (#…
4180cab 
…9288)
@dd-octo-sts dd-octo-sts Bot mentioned this pull request Jul 14, 2026
Closed
dd-octo-sts Bot pushed a commit that referenced this pull request Jul 14, 2026
@CarlesDD @BridgeAR
fix(appsec): log the error when the native WAF binding fails to load (#…
fe9f4a2 
…9288)
This was referenced Jul 14, 2026
Closed
Merged
Merged
juan-fernandez pushed a commit that referenced this pull request Jul 14, 2026
@CarlesDD @juan-fernandez
fix(appsec): log the error when the native WAF binding fails to load (#…
067dac2 
…9288)
juan-fernandez pushed a commit that referenced this pull request Jul 14, 2026
@CarlesDD @juan-fernandez
fix(appsec): log the error when the native WAF binding fails to load (#…
ccf8646 
…9288)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees

@CarlesDD CarlesDD

Labels

appsec semver-patch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CarlesDD @BridgeAR