Skip to content

fix(ssi): run ssi in current proposal branch#9223

Merged
pabloerhard merged 1 commit into
masterfrom
pabloerhard/fix-ssi
Jul 9, 2026
Merged

fix(ssi): run ssi in current proposal branch#9223
pabloerhard merged 1 commit into
masterfrom
pabloerhard/fix-ssi

Conversation

@pabloerhard

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR fixes the SSI test guard. Previously, SSI tests only ran on master because CI_MERGE_REQUEST_LABELS and CI_MERGE_REQUEST_SOURCE_BRANCH_NAME are only available during GitLab merge requests. Since this is a GitHub merge, those variables are not available, causing the condition to always evaluate to false.

Because labels are not currently accessible by gitlab in GitHub merges, running SSI tests using the run-ssi-tests label is not supported at the moment.

Motivation

Additional Notes

@dd-octo-sts

dd-octo-sts Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 6.55 MB
Deduped: 7.21 MB
No deduping: 7.21 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.3.0 | 117.14 kB | 432.47 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.61%. Comparing base (9bcb78f) to head (15fe02a).
⚠️ Report is 25 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9223      +/-   ##
==========================================
+ Coverage   93.59%   93.61%   +0.01%     
==========================================
  Files         900      900              
  Lines       52679    52679              
  Branches    12405    12405              
==========================================
+ Hits        49306    49316      +10     
+ Misses       3373     3363      -10     
Flag Coverage Δ
aiguard 34.98% <ø> (-0.08%) ⬇️
aiguard-integration 41.98% <ø> (ø)
apm-bucket-0 34.84% <ø> (-0.08%) ⬇️
apm-bucket-1 40.51% <ø> (-0.07%) ⬇️
apm-bucket-2 37.50% <ø> (-0.07%) ⬇️
apm-capabilities-tracing 48.95% <ø> (ø)
apm-integrations-aerospike 33.13% <ø> (-0.08%) ⬇️
apm-integrations-confluentinc-kafka-javascript 40.03% <ø> (-0.17%) ⬇️
apm-integrations-couchbase 33.24% <ø> (-0.24%) ⬇️
apm-integrations-http 42.05% <ø> (-0.07%) ⬇️
apm-integrations-kafkajs 40.26% <ø> (-0.08%) ⬇️
apm-integrations-next 29.63% <ø> (-0.08%) ⬇️
apm-integrations-prisma 35.18% <ø> (-0.07%) ⬇️
apm-integrations-tedious 34.04% <ø> (-0.08%) ⬇️
appsec 57.83% <ø> (-0.06%) ⬇️
appsec-express_fastify_graphql 53.83% <ø> (-0.09%) ⬇️
appsec-integration 35.61% <ø> (ø)
appsec-kafka_ldapjs_lodash 43.75% <ø> (-0.07%) ⬇️
appsec-mongodb-core_mongoose_mysql 48.90% <ø> (-0.06%) ⬇️
appsec-next 28.05% <ø> (-0.07%) ⬇️
appsec-node-serialize_passport_postgres 48.09% <ø> (-0.06%) ⬇️
appsec-sourcing_stripe_template 45.64% <ø> (-0.18%) ⬇️
debugger 44.68% <ø> (+0.04%) ⬆️
instrumentations-bucket-0 28.16% <ø> (-0.08%) ⬇️
instrumentations-bucket-1 37.57% <ø> (-0.07%) ⬇️
instrumentations-bucket-10 40.51% <ø> (-0.07%) ⬇️
instrumentations-bucket-11 27.96% <ø> (-0.08%) ⬇️
instrumentations-bucket-12 28.79% <ø> (-0.08%) ⬇️
instrumentations-bucket-13 27.79% <ø> (-0.08%) ⬇️
instrumentations-bucket-2 30.36% <ø> (-0.08%) ⬇️
instrumentations-bucket-3 36.06% <ø> (-0.08%) ⬇️
instrumentations-bucket-4 28.57% <ø> (-0.08%) ⬇️
instrumentations-bucket-5 36.42% <ø> (-0.07%) ⬇️
instrumentations-bucket-6 38.42% <ø> (-0.08%) ⬇️
instrumentations-bucket-7 36.16% <ø> (-0.07%) ⬇️
instrumentations-bucket-8 37.11% <ø> (-0.07%) ⬇️
instrumentations-bucket-9 39.61% <ø> (-0.07%) ⬇️
instrumentations-instrumentation-couchbase 46.48% <ø> (ø)
instrumentations-integration-esbuild 24.46% <ø> (ø)
llmobs-ai_anthropic_bedrock 39.68% <ø> (-0.07%) ⬇️
llmobs-google-genai_langchain_vertex-ai 36.98% <ø> (-0.18%) ⬇️
llmobs-openai 39.74% <ø> (-0.07%) ⬇️
llmobs-sdk 43.59% <ø> (-0.08%) ⬇️
master-coverage 93.61% <ø> (?)
openfeature 37.94% <ø> (ø)
openfeature-unit 50.47% <ø> (ø)
platform-core_esbuild_instrumentations-misc 22.92% <ø> (ø)
platform-integration 47.59% <ø> (+0.01%) ⬆️
platform-shimmer_unit-guardrails_webpack 18.44% <ø> (ø)
plugins-bucket-0 36.52% <ø> (-0.07%) ⬇️
plugins-bucket-1 39.78% <ø> (ø)
plugins-bucket-11 38.63% <ø> (-0.08%) ⬇️
plugins-bucket-17 39.22% <ø> (-0.07%) ⬇️
plugins-bucket-18 42.17% <ø> (-0.07%) ⬇️
plugins-bucket-19 39.97% <ø> (-0.07%) ⬇️
plugins-bucket-20 43.43% <ø> (-0.07%) ⬇️
plugins-bucket-4 37.88% <ø> (-0.07%) ⬇️
plugins-bullmq_cassandra_cookie 39.93% <ø> (-0.07%) ⬇️
plugins-cookie-parser_crypto_dd-trace-api 33.22% <ø> (-0.08%) ⬇️
plugins-fetch_fs_generic-pool 36.21% <ø> (-0.08%) ⬇️
plugins-google-cloud-pubsub_grpc_handlebars 43.08% <ø> (-0.07%) ⬇️
plugins-hapi_hono_ioredis 37.94% <ø> (-0.07%) ⬇️
plugins-jest_knex_langgraph 32.61% <ø> (-0.08%) ⬇️
plugins-ldapjs_light-my-request_limitd-client 27.86% <ø> (-0.08%) ⬇️
plugins-lodash_mariadb_memcached 35.17% <ø> (-0.08%) ⬇️
plugins-mongodb_mongodb-core_mongoose 36.46% <ø> (-0.07%) ⬇️
plugins-multer_mysql_mysql2 35.15% <ø> (-0.08%) ⬇️
plugins-nats_node-serialize_opensearch 37.31% <ø> (-0.08%) ⬇️
plugins-passport-http_pino_postgres 35.53% <ø> (-0.08%) ⬇️
plugins-process_pug_redis 34.26% <ø> (-0.09%) ⬇️
plugins-undici_url_valkey 35.90% <ø> (-0.20%) ⬇️
plugins-vm_winston_ws 37.72% <ø> (-0.08%) ⬇️
profiling 43.83% <ø> (-0.07%) ⬇️
serverless-aws-sdk-aws-sdk 33.32% <ø> (-0.07%) ⬇️
serverless-aws-sdk-bedrockruntime 32.19% <ø> (-0.07%) ⬇️
serverless-aws-sdk-client 37.16% <ø> (ø)
serverless-aws-sdk-dynamodb 34.13% <ø> (-0.07%) ⬇️
serverless-aws-sdk-eventbridge 27.36% <ø> (-0.07%) ⬇️
serverless-aws-sdk-kinesis 37.55% <ø> (-0.07%) ⬇️
serverless-aws-sdk-lambda 34.64% <ø> (-0.07%) ⬇️
serverless-aws-sdk-s3 32.63% <ø> (-0.07%) ⬇️
serverless-aws-sdk-serverless-peer-service 39.65% <ø> (-0.08%) ⬇️
serverless-aws-sdk-sns 38.40% <ø> (-0.07%) ⬇️
serverless-aws-sdk-sqs 38.14% <ø> (-0.07%) ⬇️
serverless-aws-sdk-stepfunctions 33.22% <ø> (-0.07%) ⬇️
serverless-aws-sdk-util 47.95% <ø> (ø)
serverless-bucket-0 39.63% <ø> (ø)
serverless-lambda 34.34% <ø> (-0.09%) ⬇️
test-optimization-cucumber 52.41% <ø> (+0.17%) ⬆️
test-optimization-cypress 50.05% <ø> (+0.06%) ⬆️
test-optimization-jest 55.51% <ø> (+0.07%) ⬆️
test-optimization-mocha 53.48% <ø> (+0.08%) ⬆️
test-optimization-playwright-playwright-atr 43.43% <ø> (+0.08%) ⬆️
test-optimization-playwright-playwright-efd 43.71% <ø> (+0.08%) ⬆️
test-optimization-playwright-playwright-final-status 43.83% <ø> (+0.08%) ⬆️
test-optimization-playwright-playwright-impacted-tests 43.26% <ø> (ø)
test-optimization-playwright-playwright-reporting 43.37% <ø> (+0.08%) ⬆️
test-optimization-playwright-playwright-test-management 44.83% <ø> (+0.08%) ⬆️
test-optimization-playwright-playwright-test-span 44.63% <ø> (+0.08%) ⬆️
test-optimization-selenium 45.41% <ø> (+0.06%) ⬆️
test-optimization-testopt 46.74% <ø> (+0.08%) ⬆️
test-optimization-vitest 52.67% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-official

datadog-official Bot commented Jul 6, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 87.78% (+0.02%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 15fe02a | Docs | Datadog PR Page | Give us feedback!

@pr-commenter

pr-commenter Bot commented Jul 6, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-07-06 18:08:21

Comparing candidate commit 15fe02a in PR branch pabloerhard/fix-ssi with baseline commit 9bcb78f in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 0 performance regressions! Performance is the same for 2253 metrics, 33 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:appsec-appsec-enabled-24

  • unstable execution_time [-183254.592µs; +181868.992µs] or [-6.952%; +6.899%]

scenario:appsec-appsec-enabled-26

  • unstable execution_time [-209.077ms; +202.853ms] or [-8.333%; +8.084%]

scenario:appsec-appsec-enabled-with-attacks-26

  • unstable execution_time [-162.198ms; +145.361ms] or [-5.637%; +5.052%]

scenario:appsec-control-20

  • unstable execution_time [-116.450ms; +104.834ms] or [-7.122%; +6.412%]

scenario:appsec-control-24

  • unstable execution_time [-106839.000µs; +107117.733µs] or [-8.779%; +8.802%]

scenario:appsec-control-26

  • unstable execution_time [-102.622ms; +115.673ms] or [-8.555%; +9.643%]

scenario:debugger-line-probe-with-snapshot-default-24

  • unstable cpu_user_time [-1506.262ms; +490.378ms] or [-18.485%; +6.018%]
  • unstable execution_time [-1540.803ms; +518.623ms] or [-17.435%; +5.868%]
  • unstable instructions [-13.1G instructions; +4.0G instructions] or [-19.605%; +6.005%]
  • unstable throughput [-156.904op/s; +450.769op/s] or [-4.229%; +12.149%]

scenario:debugger-line-probe-with-snapshot-default-26

  • unstable cpu_user_time [-2.838s; +0.394s] or [-28.420%; +3.944%]
  • unstable execution_time [-2.894s; +0.399s] or [-27.052%; +3.726%]
  • unstable instructions [-25.6G instructions; +3.2G instructions] or [-30.725%; +3.806%]
  • unstable throughput [-87.715op/s; +626.754op/s] or [-2.805%; +20.043%]

scenario:debugger-line-probe-with-snapshot-minimal-24

  • unstable cpu_user_time [-1781.940ms; +3778.280ms] or [-18.019%; +38.206%]
  • unstable execution_time [-1.810s; +3.828s] or [-17.100%; +36.171%]
  • unstable instructions [-14.8G instructions; +31.8G instructions] or [-18.264%; +39.371%]
  • unstable max_rss_usage [-8.155MB; +16.149MB] or [-4.996%; +9.893%]
  • unstable throughput [-1066.208op/s; +491.815op/s] or [-33.450%; +15.430%]

scenario:debugger-line-probe-without-snapshot-24

  • unstable cpu_user_time [-1774.024ms; +3347.373ms] or [-21.743%; +41.026%]
  • unstable execution_time [-1836.196ms; +3404.678ms] or [-20.773%; +38.517%]
  • unstable instructions [-15.1G instructions; +28.3G instructions] or [-22.666%; +42.650%]
  • unstable max_rss_usage [-8.455MB; +11.834MB] or [-5.350%; +7.487%]
  • unstable throughput [-964.683op/s; +464.700op/s] or [-25.763%; +12.410%]

scenario:debugger-line-probe-without-snapshot-26

  • unstable cpu_user_time [-2977.501ms; +3002.078ms] or [-30.178%; +30.427%]
  • unstable execution_time [-3079.916ms; +3110.899ms] or [-29.124%; +29.417%]
  • unstable instructions [-26293.8M instructions; +26489.5M instructions] or [-31.885%; +32.123%]
  • unstable max_rss_usage [-8669.378KB; +8415.778KB] or [-5.363%; +5.206%]
  • unstable throughput [-688.960op/s; +675.493op/s] or [-21.652%; +21.229%]

scenario:dogstatsd-with-tags-20

  • unstable cpu_user_time [-471.163ms; +220.962ms] or [-9.568%; +4.487%]
  • unstable execution_time [-472.215ms; +222.586ms] or [-9.449%; +4.454%]
  • unstable throughput [-77195.023op/s; +161214.372op/s] or [-4.594%; +9.593%]

scenario:test-optimization-large-suite-20

  • unstable max_rss_usage [-5397.736KB; +6720.736KB] or [-6.577%; +8.189%]

@pabloerhard
pabloerhard marked this pull request as ready for review July 8, 2026 15:50
@pabloerhard
pabloerhard requested a review from a team as a code owner July 8, 2026 15:50

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 15fe02aa10

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread .gitlab-ci.yml
@pabloerhard
pabloerhard merged commit 4398f17 into master Jul 9, 2026
653 checks passed
@pabloerhard
pabloerhard deleted the pabloerhard/fix-ssi branch July 9, 2026 16:56
@dd-octo-sts dd-octo-sts Bot mentioned this pull request Jul 10, 2026
@dd-octo-sts dd-octo-sts Bot mentioned this pull request Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants