fix(vitest): report typecheck tests#9176
Conversation
Overall package sizeSelf size: 6.45 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.2.0 | 104.26 kB | 843.44 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 9e5c56e | Docs | Datadog PR Page | Give us feedback! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9176 +/- ##
==========================================
+ Coverage 93.74% 93.77% +0.03%
==========================================
Files 895 895
Lines 51399 51538 +139
Branches 11980 12020 +40
==========================================
+ Hits 48182 48329 +147
+ Misses 3217 3209 -8 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2026-07-02 10:17:30 Comparing candidate commit 9e5c56e in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 2261 metrics, 25 unstable metrics.
|
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 083be8b61b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 017227b4a9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
97dc11d to
c7e9531
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97dc11df84
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
c7e9531 to
9dd7d68
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9dd7d68b86
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
9dd7d68 to
f50197c
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f50197ce26
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
f50197c to
8b2481a
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8b2481a42c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
8b2481a to
0d6b5cb
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0d6b5cb801
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
0d6b5cb to
a5116ab
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
The typecheck reporting feature emits suite and test events but omits session and module events required by downstream Test Optimization services. This causes typecheck test results to drop in processing pipelines that expect complete event sequences. The PR passes local typecheck runs but fails CI integration tests that verify event completeness.
📊 Validated against 1 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit a5116ab · What is Autotest? · Any feedback? Reach out in #autotest
a5116ab to
9e5c56e
Compare
|
/datadog autotest review |
There was a problem hiding this comment.
More details
Typecheck reporting implementation is sound. The code correctly wraps Vitest's Typechecker.prepareResults to emit CI Visibility events for typecheck-only tests, properly handles nested test names, and applies all Test Optimization metadata (Known Tests, Test Management, Impacted Tests) consistently with the existing pattern used for regular tests. No behavioral regressions detected across test state transitions, nested suite handling, or Test Management semantics.
📊 Validated against 15 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit 9e5c56e · What is Autotest? · Any feedback? Reach out in #autotest
What does this PR do?
Adds Vitest typecheck reporting for Test Optimization by wrapping
Typechecker.prepareResultsin the main Vitest instrumentation and emitting suite/test events for.test-d.tstasks.The reporting path supports Vitest 3.2.x and 4.x typecheck flows, preserves nested test names, reports typecheck failures with
TypeCheckErrormetadata, and applies Known Tests, Impacted Tests, and Test Management metadata to typecheck tasks.Motivation
Vitest typecheck-only runs do not execute through the normal
@vitest/runnerworker path. They can report session/module events while missing per-suite and per-test events, which makes typecheck commands look unsupported in Test Optimization.