Skip to content

docs(agents): clarify internal import ordering rule#9172

Merged
BridgeAR merged 1 commit into
masterfrom
ccapell/fix-agents-import-order
Jul 2, 2026
Merged

docs(agents): clarify internal import ordering rule#9172
BridgeAR merged 1 commit into
masterfrom
ccapell/fix-agents-import-order

Conversation

@CarlesDD

@CarlesDD CarlesDD commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Clarifies the internal import ordering rule in AGENTS.md. The previous wording ("by path proximity, then alpha") was ambiguous, it didn't specify whether proximity meant closer-first or furthest-first, which is the opposite of what the import/order ESLint rule enforces.

Motivation

The ambiguity caused a lint failure in a separate PR: imports were written closer-first following an intuitive reading of "proximity", but the linter requires furthest-first. The updated wording makes the direction explicit and aligns with the actual ESLint configuration.

Additional Notes

The authoritative source remains ESLint configuration: the import/order rule groups parent paths (../) before sibling paths (./) by default, which is what "furthest first" reflects in practice.

@dd-octo-sts

dd-octo-sts Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 6.43 MB
Deduped: 7.49 MB
No deduping: 7.49 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.2.0 | 104.26 kB | 843.44 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jul 1, 2026

Copy link
Copy Markdown

Tests

Fix all issues with BitsAI

⚠️ Warnings

🧪 1 Test failed in 1 job

All Green | all-green   GitHub Actions

Dynamic Instrumentation captureExpressions deadline behavior "before all" hook for "adds notCapturedReason for expressions after deadline is reached" from deadline behavior   View in Datadog
Timeout of 300000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/dd-trace-js/dd-trace-js/integration-tests/debugger/capture-expressions-time-budget.spec.js)

Error: Timeout of 300000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/dd-trace-js/dd-trace-js/integration-tests/debugger/capture-expressions-time-budget.spec.js)

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 88.03% (+0.01%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 71c44c8 | Docs | Datadog PR Page | Give us feedback!

@CarlesDD
CarlesDD marked this pull request as ready for review July 1, 2026 12:27
@CarlesDD
CarlesDD requested a review from a team as a code owner July 1, 2026 12:27
@pr-commenter

pr-commenter Bot commented Jul 1, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-07-01 12:30:58

Comparing candidate commit 71c44c8 in PR branch ccapell/fix-agents-import-order with baseline commit 79b87ef in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 0 performance regressions! Performance is the same for 2266 metrics, 20 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:appsec-appsec-enabled-24

  • unstable execution_time [-192.563ms; +182.594ms] or [-7.292%; +6.915%]

scenario:appsec-appsec-enabled-26

  • unstable execution_time [-204823.035µs; +204046.568µs] or [-8.170%; +8.139%]

scenario:appsec-appsec-enabled-with-attacks-26

  • unstable execution_time [-153.027ms; +156.244ms] or [-5.318%; +5.430%]

scenario:appsec-control-20

  • unstable execution_time [-143.302ms; +173.177ms] or [-8.183%; +9.889%]

scenario:appsec-control-24

  • unstable execution_time [-101231.811µs; +101125.177µs] or [-8.322%; +8.313%]

scenario:appsec-control-26

  • unstable execution_time [-113146.601µs; +114038.701µs] or [-9.367%; +9.441%]

scenario:debugger-line-probe-with-snapshot-default-24

  • unstable cpu_user_time [-2741.833ms; +2780.561ms] or [-32.163%; +32.617%]
  • unstable execution_time [-2767.161ms; +2814.157ms] or [-30.069%; +30.580%]
  • unstable instructions [-23278.4M instructions; +23713.8M instructions] or [-33.492%; +34.118%]
  • unstable max_rss_usage [-9761.901KB; +10063.501KB] or [-6.083%; +6.271%]
  • unstable throughput [-803.586op/s; +802.284op/s] or [-21.927%; +21.892%]

scenario:debugger-line-probe-without-snapshot-24

  • unstable cpu_user_time [-2604.936ms; +3831.080ms] or [-28.790%; +42.341%]
  • unstable execution_time [-2598.292ms; +3865.490ms] or [-26.660%; +39.663%]
  • unstable instructions [-22.6G instructions; +33.1G instructions] or [-30.530%; +44.594%]
  • unstable max_rss_usage [-9.295MB; +14.210MB] or [-5.721%; +8.746%]
  • unstable throughput [-1122.096op/s; +752.691op/s] or [-32.052%; +21.500%]

scenario:dogstatsd-with-tags-20

  • unstable cpu_user_time [-357325.726µs; +355549.559µs] or [-7.442%; +7.405%]
  • unstable execution_time [-352.928ms; +358.859ms] or [-7.236%; +7.358%]
  • unstable throughput [-123775.497op/s; +120398.085op/s] or [-7.186%; +6.990%]

scenario:plugin-graphql-long-with-depth-off-20

  • unstable max_rss_usage [-6152.855KB; +7655.712KB] or [-4.763%; +5.926%]

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.72%. Comparing base (79b87ef) to head (71c44c8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9172   +/-   ##
=======================================
  Coverage   93.71%   93.72%           
=======================================
  Files         895      895           
  Lines       51324    51324           
  Branches    11947    11947           
=======================================
+ Hits        48100    48101    +1     
+ Misses       3224     3223    -1     
Flag Coverage Δ
aiguard 34.87% <ø> (-0.08%) ⬇️
aiguard-integration 41.79% <ø> (ø)
apm-bucket-0 34.84% <ø> (-0.08%) ⬇️
apm-bucket-1 40.33% <ø> (-0.07%) ⬇️
apm-bucket-2 37.34% <ø> (-0.07%) ⬇️
apm-capabilities-tracing 48.68% <ø> (ø)
apm-integrations-aerospike 33.12% <ø> (-0.08%) ⬇️
apm-integrations-confluentinc-kafka-javascript 40.02% <ø> (-0.08%) ⬇️
apm-integrations-couchbase 33.24% <ø> (-0.24%) ⬇️
apm-integrations-http 41.95% <ø> (-0.07%) ⬇️
apm-integrations-kafkajs 40.25% <ø> (-0.08%) ⬇️
apm-integrations-next 29.46% <ø> (-0.07%) ⬇️
apm-integrations-prisma 35.03% <ø> (-0.07%) ⬇️
apm-integrations-tedious 33.89% <ø> (-0.08%) ⬇️
appsec 57.69% <ø> (-0.05%) ⬇️
appsec-express_fastify_graphql 53.67% <ø> (-0.06%) ⬇️
appsec-integration 36.57% <ø> (ø)
appsec-kafka_ldapjs_lodash 43.66% <ø> (+0.02%) ⬆️
appsec-mongodb-core_mongoose_mysql 48.74% <ø> (-0.06%) ⬇️
appsec-next 28.00% <ø> (-0.07%) ⬇️
appsec-node-serialize_passport_postgres 47.91% <ø> (-0.06%) ⬇️
appsec-sourcing_stripe_template 45.47% <ø> (-0.06%) ⬇️
debugger 44.42% <ø> (ø)
instrumentations-bucket-0 28.15% <ø> (-0.08%) ⬇️
instrumentations-bucket-1 37.40% <ø> (-0.07%) ⬇️
instrumentations-bucket-10 40.35% <ø> (-0.07%) ⬇️
instrumentations-bucket-11 27.95% <ø> (-0.08%) ⬇️
instrumentations-bucket-12 28.67% <ø> (-0.08%) ⬇️
instrumentations-bucket-13 27.78% <ø> (-0.08%) ⬇️
instrumentations-bucket-2 30.23% <ø> (-0.07%) ⬇️
instrumentations-bucket-3 35.90% <ø> (-0.07%) ⬇️
instrumentations-bucket-4 28.56% <ø> (-0.08%) ⬇️
instrumentations-bucket-5 36.28% <ø> (-0.07%) ⬇️
instrumentations-bucket-6 38.25% <ø> (-0.08%) ⬇️
instrumentations-bucket-7 36.01% <ø> (-0.07%) ⬇️
instrumentations-bucket-8 36.95% <ø> (-0.07%) ⬇️
instrumentations-bucket-9 39.45% <ø> (-0.07%) ⬇️
instrumentations-instrumentation-couchbase 46.48% <ø> (ø)
instrumentations-integration-esbuild 25.15% <ø> (ø)
llmobs-ai_anthropic_bedrock 39.53% <ø> (-0.07%) ⬇️
llmobs-google-genai_langchain_vertex-ai 36.97% <ø> (-0.06%) ⬇️
llmobs-openai 39.58% <ø> (-0.07%) ⬇️
llmobs-sdk 43.59% <ø> (-0.08%) ⬇️
master-coverage 93.72% <ø> (?)
openfeature 37.77% <ø> (+<0.01%) ⬆️
openfeature-unit 50.39% <ø> (ø)
platform-core_esbuild_instrumentations-misc 23.59% <ø> (ø)
platform-integration 47.42% <ø> (ø)
platform-shimmer_unit-guardrails_webpack 19.13% <ø> (ø)
plugins-bucket-0 36.37% <ø> (-0.07%) ⬇️
plugins-bucket-1 39.60% <ø> (ø)
plugins-bucket-11 38.46% <ø> (-0.08%) ⬇️
plugins-bucket-17 39.15% <ø> (-0.07%) ⬇️
plugins-bucket-18 42.01% <ø> (-0.06%) ⬇️
plugins-bucket-19 39.56% <ø> (-0.07%) ⬇️
plugins-bucket-20 43.23% <ø> (-0.09%) ⬇️
plugins-bucket-4 37.71% <ø> (-0.07%) ⬇️
plugins-bullmq_cassandra_cookie 39.76% <ø> (-0.07%) ⬇️
plugins-cookie-parser_crypto_dd-trace-api 33.22% <ø> (-0.08%) ⬇️
plugins-fetch_fs_generic-pool 36.05% <ø> (-0.07%) ⬇️
plugins-google-cloud-pubsub_grpc_handlebars 43.10% <ø> (-0.07%) ⬇️
plugins-hapi_hono_ioredis 37.78% <ø> (-0.07%) ⬇️
plugins-jest_knex_langgraph 32.60% <ø> (-0.08%) ⬇️
plugins-ldapjs_light-my-request_limitd-client 27.85% <ø> (-0.08%) ⬇️
plugins-lodash_mariadb_memcached 35.17% <ø> (-0.08%) ⬇️
plugins-mongodb_mongodb-core_mongoose 36.31% <ø> (-0.07%) ⬇️
plugins-multer_mysql_mysql2 35.14% <ø> (-0.08%) ⬇️
plugins-nats_node-serialize_opensearch 37.14% <ø> (-0.08%) ⬇️
plugins-passport-http_pino_postgres 35.53% <ø> (-0.08%) ⬇️
plugins-process_pug_redis 34.26% <ø> (-0.08%) ⬇️
plugins-undici_url_valkey 35.75% <ø> (-0.07%) ⬇️
plugins-vm_winston_ws 37.55% <ø> (-0.08%) ⬇️
profiling 43.64% <ø> (-0.05%) ⬇️
serverless-aws-sdk-aws-sdk 33.29% <ø> (-0.07%) ⬇️
serverless-aws-sdk-bedrockruntime 32.16% <ø> (-0.07%) ⬇️
serverless-aws-sdk-client 37.16% <ø> (ø)
serverless-aws-sdk-dynamodb 34.14% <ø> (-0.07%) ⬇️
serverless-aws-sdk-eventbridge 27.25% <ø> (-0.07%) ⬇️
serverless-aws-sdk-kinesis 37.40% <ø> (-0.07%) ⬇️
serverless-aws-sdk-lambda 34.59% <ø> (-0.07%) ⬇️
serverless-aws-sdk-s3 32.59% <ø> (-0.07%) ⬇️
serverless-aws-sdk-serverless-peer-service 39.47% <ø> (-0.08%) ⬇️
serverless-aws-sdk-sns 38.25% <ø> (-0.07%) ⬇️
serverless-aws-sdk-sqs 38.00% <ø> (-0.07%) ⬇️
serverless-aws-sdk-stepfunctions 33.18% <ø> (-0.07%) ⬇️
serverless-aws-sdk-util 47.95% <ø> (ø)
serverless-bucket-0 39.46% <ø> (ø)
serverless-lambda 34.33% <ø> (-0.09%) ⬇️
test-optimization-cucumber 52.30% <ø> (+0.11%) ⬆️
test-optimization-cypress 49.41% <ø> (+0.06%) ⬆️
test-optimization-jest 55.34% <ø> (+0.04%) ⬆️
test-optimization-mocha 53.38% <ø> (+0.08%) ⬆️
test-optimization-playwright-playwright-atr 43.33% <ø> (+0.08%) ⬆️
test-optimization-playwright-playwright-efd 43.61% <ø> (+0.08%) ⬆️
test-optimization-playwright-playwright-final-status 43.73% <ø> (+0.08%) ⬆️
test-optimization-playwright-playwright-impacted-tests 43.16% <ø> (ø)
test-optimization-playwright-playwright-reporting 43.26% <ø> (-0.15%) ⬇️
test-optimization-playwright-playwright-test-management 44.72% <ø> (+0.08%) ⬆️
test-optimization-playwright-playwright-test-span 44.51% <ø> (+0.07%) ⬆️
test-optimization-selenium 45.26% <ø> (+0.06%) ⬆️
test-optimization-testopt 48.02% <ø> (+0.08%) ⬆️
test-optimization-vitest 50.73% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BridgeAR BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@BridgeAR
BridgeAR merged commit 2b301ed into master Jul 2, 2026
866 of 868 checks passed
@BridgeAR
BridgeAR deleted the ccapell/fix-agents-import-order branch July 2, 2026 00:47
This was referenced Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants