Skip to content

test(oracledb): bound connect and query timeouts in the ESM integration fixture#9105

Merged
BridgeAR merged 2 commits into
masterfrom
BridgeAR/2026-06-26-oracledb-integration-calltimeout
Jul 1, 2026
Merged

test(oracledb): bound connect and query timeouts in the ESM integration fixture#9105
BridgeAR merged 2 commits into
masterfrom
BridgeAR/2026-06-26-oracledb-integration-calltimeout

Conversation

@BridgeAR

Copy link
Copy Markdown
Member

Summary

The ESM integration fixture (server.mjs) connected with no client-side timeout, so a stalled Oracle round-trip hung the subprocess until the 20s mocha per-test timeout fired with no diagnosable error. CI hit this intermittently — five of six sibling ESM subprocesses connected and ran the query in ~0.5s while one wedged for the full window, surfacing as Error: Timeout of 20000ms exceeded with no attribution.

connect_timeout bounds the connect phase and connection.callTimeout bounds each query round-trip, so a stalled session now throws (NJS-123 for a wedged round-trip, a connect error for a wedged connect) well inside the test budget. A flake becomes a fast, attributable failure.

Test plan

  • oracledb plugin integration job stays green, with the happy-path ESM variants still completing well under the new 10s/15s client timeouts.

Refs: oracle/node-oracledb#1592

…on fixture

The ESM integration fixture connected with no client-side timeout, so a stalled
Oracle round-trip hung the subprocess until the 20s mocha per-test timeout fired
with no diagnosable error. CI hit this intermittently: five of six sibling ESM
subprocesses connected and ran the query in ~0.5s while one wedged for the full
window. connect_timeout bounds the connect phase and callTimeout bounds each
query round-trip, so a stalled session now throws (NJS-123 / a connect error)
well inside the budget and the test fails fast and attributable instead of as a
generic timeout.

Refs: oracle/node-oracledb#1592
@dd-octo-sts

dd-octo-sts Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 6.39 MB
Deduped: 7.46 MB
No deduping: 7.46 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.2.0 | 104.26 kB | 843.44 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jun 26, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 87.98% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 232a685 | Docs | Datadog PR Page | Give us feedback!

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.69%. Comparing base (27dcc31) to head (232a685).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9105   +/-   ##
=======================================
  Coverage   93.69%   93.69%           
=======================================
  Files         889      889           
  Lines       50856    50856           
  Branches    11830    11830           
=======================================
+ Hits        47647    47649    +2     
+ Misses       3209     3207    -2     
Flag Coverage Δ
aiguard 34.88% <ø> (-0.08%) ⬇️
aiguard-integration 41.79% <ø> (ø)
apm-bucket-0 34.85% <ø> (-0.08%) ⬇️
apm-bucket-1 40.34% <ø> (-0.07%) ⬇️
apm-bucket-2 37.35% <ø> (-0.07%) ⬇️
apm-capabilities-tracing 48.29% <ø> (ø)
apm-integrations-aerospike 33.13% <ø> (-0.08%) ⬇️
apm-integrations-confluentinc-kafka-javascript 40.04% <ø> (-0.08%) ⬇️
apm-integrations-couchbase 33.25% <ø> (-0.35%) ⬇️
apm-integrations-http 42.04% <ø> (-0.07%) ⬇️
apm-integrations-kafkajs 40.27% <ø> (-0.07%) ⬇️
apm-integrations-next 29.47% <ø> (-0.11%) ⬇️
apm-integrations-prisma 35.04% <ø> (-0.07%) ⬇️
apm-integrations-tedious 33.90% <ø> (-0.08%) ⬇️
appsec 57.33% <ø> (-0.12%) ⬇️
appsec-express_fastify_graphql 53.77% <ø> (-0.04%) ⬇️
appsec-integration 36.25% <ø> (ø)
appsec-kafka_ldapjs_lodash 43.60% <ø> (-0.07%) ⬇️
appsec-mongodb-core_mongoose_mysql 48.81% <ø> (-0.06%) ⬇️
appsec-next 28.01% <ø> (-0.07%) ⬇️
appsec-node-serialize_passport_postgres 48.01% <ø> (-0.06%) ⬇️
appsec-sourcing_stripe_template 45.56% <ø> (-0.06%) ⬇️
debugger 44.42% <ø> (ø)
instrumentations-bucket-0 28.16% <ø> (-0.08%) ⬇️
instrumentations-bucket-1 37.41% <ø> (-0.07%) ⬇️
instrumentations-bucket-10 40.44% <ø> (-0.07%) ⬇️
instrumentations-bucket-11 27.96% <ø> (-0.08%) ⬇️
instrumentations-bucket-12 28.67% <ø> (-0.08%) ⬇️
instrumentations-bucket-13 27.79% <ø> (-0.08%) ⬇️
instrumentations-bucket-2 30.24% <ø> (-0.07%) ⬇️
instrumentations-bucket-3 35.91% <ø> (-0.07%) ⬇️
instrumentations-bucket-4 28.07% <ø> (-0.08%) ⬇️
instrumentations-bucket-5 36.28% <ø> (-0.07%) ⬇️
instrumentations-bucket-6 38.26% <ø> (-0.08%) ⬇️
instrumentations-bucket-7 36.01% <ø> (-0.07%) ⬇️
instrumentations-bucket-8 36.96% <ø> (-0.07%) ⬇️
instrumentations-bucket-9 39.53% <ø> (-0.07%) ⬇️
instrumentations-instrumentation-couchbase 46.54% <ø> (ø)
instrumentations-integration-esbuild 24.87% <ø> (ø)
llmobs-ai_anthropic_bedrock 39.54% <ø> (-0.07%) ⬇️
llmobs-google-genai_langchain_vertex-ai 36.86% <ø> (-0.18%) ⬇️
llmobs-openai 39.59% <ø> (-0.07%) ⬇️
llmobs-sdk 43.60% <ø> (-0.08%) ⬇️
master-coverage 93.69% <ø> (?)
openfeature 37.76% <ø> (ø)
openfeature-unit 50.39% <ø> (ø)
platform-core_esbuild_instrumentations-misc 23.36% <ø> (ø)
platform-integration 47.43% <ø> (ø)
platform-shimmer_unit-guardrails_webpack 18.89% <ø> (ø)
plugins-bucket-0 36.34% <ø> (-0.07%) ⬇️
plugins-bucket-1 39.61% <ø> (ø)
plugins-bucket-11 38.47% <ø> (-0.08%) ⬇️
plugins-bucket-17 39.16% <ø> (-0.07%) ⬇️
plugins-bucket-18 42.01% <ø> (-0.07%) ⬇️
plugins-bucket-19 39.57% <ø> (-0.07%) ⬇️
plugins-bucket-20 43.26% <ø> (-0.10%) ⬇️
plugins-bucket-4 37.72% <ø> (-0.07%) ⬇️
plugins-bullmq_cassandra_cookie 39.77% <ø> (-0.07%) ⬇️
plugins-cookie-parser_crypto_dd-trace-api 33.23% <ø> (-0.08%) ⬇️
plugins-fetch_fs_generic-pool 36.06% <ø> (-0.07%) ⬇️
plugins-google-cloud-pubsub_grpc_handlebars 43.11% <ø> (-0.08%) ⬇️
plugins-hapi_hono_ioredis 37.79% <ø> (-0.07%) ⬇️
plugins-jest_knex_langgraph 32.61% <ø> (-0.08%) ⬇️
plugins-ldapjs_light-my-request_limitd-client 27.85% <ø> (-0.08%) ⬇️
plugins-lodash_mariadb_memcached 35.18% <ø> (-0.08%) ⬇️
plugins-mongodb_mongodb-core_mongoose 36.32% <ø> (-0.07%) ⬇️
plugins-multer_mysql_mysql2 35.15% <ø> (-0.08%) ⬇️
plugins-nats_node-serialize_opensearch 37.16% <ø> (-0.08%) ⬇️
plugins-passport-http_pino_postgres 35.54% <ø> (-0.08%) ⬇️
plugins-process_pug_redis 34.27% <ø> (-0.08%) ⬇️
plugins-undici_url_valkey 35.89% <ø> (-0.07%) ⬇️
plugins-vm_winston_ws 37.56% <ø> (-0.08%) ⬇️
profiling 43.62% <ø> (-0.07%) ⬇️
serverless-aws-sdk-aws-sdk 33.30% <ø> (-0.07%) ⬇️
serverless-aws-sdk-bedrockruntime 32.17% <ø> (-0.07%) ⬇️
serverless-aws-sdk-client 37.21% <ø> (ø)
serverless-aws-sdk-dynamodb 34.15% <ø> (-0.07%) ⬇️
serverless-aws-sdk-eventbridge 27.25% <ø> (-0.07%) ⬇️
serverless-aws-sdk-kinesis 37.41% <ø> (-0.07%) ⬇️
serverless-aws-sdk-lambda 34.60% <ø> (-0.07%) ⬇️
serverless-aws-sdk-s3 32.60% <ø> (-0.07%) ⬇️
serverless-aws-sdk-serverless-peer-service 39.47% <ø> (-0.08%) ⬇️
serverless-aws-sdk-sns 38.26% <ø> (-0.19%) ⬇️
serverless-aws-sdk-sqs 38.01% <ø> (-0.07%) ⬇️
serverless-aws-sdk-stepfunctions 33.19% <ø> (-0.07%) ⬇️
serverless-aws-sdk-util 47.95% <ø> (ø)
serverless-bucket-0 39.47% <ø> (ø)
serverless-lambda 34.33% <ø> (-0.09%) ⬇️
test-optimization-cucumber 52.57% <ø> (+0.11%) ⬆️
test-optimization-cypress 49.62% <ø> (+0.07%) ⬆️
test-optimization-jest 55.64% <ø> (+0.07%) ⬆️
test-optimization-mocha 53.66% <ø> (+0.08%) ⬆️
test-optimization-playwright-playwright-atr 43.59% <ø> (+0.08%) ⬆️
test-optimization-playwright-playwright-efd 43.87% <ø> (+0.08%) ⬆️
test-optimization-playwright-playwright-final-status 43.93% <ø> (+0.08%) ⬆️
test-optimization-playwright-playwright-impacted-tests 43.41% <ø> (ø)
test-optimization-playwright-playwright-reporting 43.50% <ø> (+0.08%) ⬆️
test-optimization-playwright-playwright-test-management 44.94% <ø> (+0.09%) ⬆️
test-optimization-playwright-playwright-test-span 44.78% <ø> (+0.07%) ⬆️
test-optimization-selenium 45.52% <ø> (+0.06%) ⬆️
test-optimization-testopt 48.28% <ø> (+0.08%) ⬆️
test-optimization-vitest 50.96% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter

pr-commenter Bot commented Jun 26, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-06-27 16:49:26

Comparing candidate commit 232a685 in PR branch BridgeAR/2026-06-26-oracledb-integration-calltimeout with baseline commit 27dcc31 in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 0 performance regressions! Performance is the same for 2253 metrics, 33 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:appsec-appsec-enabled-20

  • unstable execution_time [-185.136ms; +193.965ms] or [-4.974%; +5.211%]

scenario:appsec-appsec-enabled-24

  • unstable execution_time [-183.300ms; +186.146ms] or [-6.973%; +7.081%]

scenario:appsec-appsec-enabled-26

  • unstable execution_time [-209.654ms; +205.088ms] or [-8.336%; +8.154%]

scenario:appsec-appsec-enabled-with-attacks-26

  • unstable execution_time [-156725.438µs; +156370.238µs] or [-5.448%; +5.436%]

scenario:appsec-control-20

  • unstable execution_time [-153.421ms; +175.469ms] or [-8.798%; +10.062%]

scenario:appsec-control-24

  • unstable execution_time [-105553.859µs; +104921.759µs] or [-8.704%; +8.651%]

scenario:appsec-control-26

  • unstable execution_time [-118.467ms; +103.273ms] or [-9.880%; +8.613%]

scenario:debugger-line-probe-with-snapshot-default-26

  • unstable cpu_user_time [-3241.329ms; +4665.321ms] or [-30.186%; +43.448%]
  • unstable execution_time [-3306.755ms; +4741.611ms] or [-28.863%; +41.387%]
  • unstable instructions [-28.5G instructions; +41.4G instructions] or [-31.636%; +45.912%]
  • unstable max_rss_usage [-9.473MB; +15.074MB] or [-5.807%; +9.240%]
  • unstable throughput [-964.465op/s; +708.754op/s] or [-32.390%; +23.803%]

scenario:debugger-line-probe-with-snapshot-minimal-24

  • unstable cpu_user_time [-1653.704ms; +549.028ms] or [-20.864%; +6.927%]
  • unstable execution_time [-1669.236ms; +554.473ms] or [-19.423%; +6.452%]
  • unstable instructions [-13.8G instructions; +4.5G instructions] or [-21.529%; +6.990%]
  • unstable throughput [-165.412op/s; +489.483op/s] or [-4.306%; +12.742%]

scenario:debugger-line-probe-without-snapshot-24

  • unstable cpu_user_time [-1717.133ms; +537.255ms] or [-21.613%; +6.762%]
  • unstable execution_time [-1723.274ms; +542.830ms] or [-20.011%; +6.303%]
  • unstable instructions [-14.6G instructions; +4.7G instructions] or [-22.585%; +7.351%]
  • unstable throughput [-157.245op/s; +506.175op/s] or [-4.098%; +13.193%]

scenario:debugger-line-probe-without-snapshot-26

  • unstable cpu_user_time [-2102.123ms; +3396.761ms] or [-22.423%; +36.232%]
  • unstable execution_time [-2091.156ms; +3391.739ms] or [-20.777%; +33.700%]
  • unstable instructions [-18.2G instructions; +29.8G instructions] or [-23.372%; +38.242%]
  • unstable max_rss_usage [-6.506MB; +10.197MB] or [-4.107%; +6.438%]
  • unstable throughput [-740.645op/s; +448.901op/s] or [-22.685%; +13.749%]

scenario:dogstatsd-with-tags-20

  • unstable cpu_user_time [-224.922ms; +468.356ms] or [-4.559%; +9.493%]
  • unstable execution_time [-223.609ms; +465.355ms] or [-4.465%; +9.292%]
  • unstable throughput [-157748.177op/s; +77989.044op/s] or [-9.411%; +4.653%]

scenario:plugin-aws-sdk-lambda-inject-with-context-24

  • unstable cpu_user_time [-149.049ms; +290.192ms] or [-3.883%; +7.560%]
  • unstable execution_time [-148.867ms; +289.025ms] or [-3.855%; +7.484%]
  • unstable throughput [-35958.701op/s; +18321.267op/s] or [-6.900%; +3.515%]

scenario:plugin-graphql-long-with-depth-on-max-20

  • unstable max_rss_usage [-34.558MB; +4.974MB] or [-18.464%; +2.658%]

scenario:test-optimization-large-suite-20

  • unstable max_rss_usage [-4.460MB; +7.620MB] or [-5.495%; +9.388%]

@BridgeAR
BridgeAR marked this pull request as ready for review June 26, 2026 21:49
@BridgeAR
BridgeAR requested a review from a team as a code owner June 26, 2026 21:49
@BridgeAR
BridgeAR requested review from crysmags and removed request for a team June 26, 2026 21:49
@BridgeAR
BridgeAR merged commit 6b3abfd into master Jul 1, 2026
1076 of 1077 checks passed
@BridgeAR
BridgeAR deleted the BridgeAR/2026-06-26-oracledb-integration-calltimeout branch July 1, 2026 22:10
dd-octo-sts Bot pushed a commit that referenced this pull request Jul 2, 2026
…on fixture (#9105)

The ESM integration fixture connected with no client-side timeout, so a stalled
Oracle round-trip hung the subprocess until the 20s mocha per-test timeout fired
with no diagnosable error. CI hit this intermittently: five of six sibling ESM
subprocesses connected and ran the query in ~0.5s while one wedged for the full
window. connect_timeout bounds the connect phase and callTimeout bounds each
query round-trip, so a stalled session now throws (NJS-123 / a connect error)
well inside the budget and the test fails fast and attributable instead of as a
generic timeout.

Refs: oracle/node-oracledb#1592
This was referenced Jul 2, 2026
rochdev pushed a commit that referenced this pull request Jul 2, 2026
…on fixture (#9105)

The ESM integration fixture connected with no client-side timeout, so a stalled
Oracle round-trip hung the subprocess until the 20s mocha per-test timeout fired
with no diagnosable error. CI hit this intermittently: five of six sibling ESM
subprocesses connected and ran the query in ~0.5s while one wedged for the full
window. connect_timeout bounds the connect phase and callTimeout bounds each
query round-trip, so a stalled session now throws (NJS-123 / a connect error)
well inside the budget and the test fails fast and attributable instead of as a
generic timeout.

Refs: oracle/node-oracledb#1592
rochdev pushed a commit that referenced this pull request Jul 2, 2026
…on fixture (#9105)

The ESM integration fixture connected with no client-side timeout, so a stalled
Oracle round-trip hung the subprocess until the 20s mocha per-test timeout fired
with no diagnosable error. CI hit this intermittently: five of six sibling ESM
subprocesses connected and ran the query in ~0.5s while one wedged for the full
window. connect_timeout bounds the connect phase and callTimeout bounds each
query round-trip, so a stalled session now throws (NJS-123 / a connect error)
well inside the budget and the test fails fast and attributable instead of as a
generic timeout.

Refs: oracle/node-oracledb#1592
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants