chore(engines)!: bump engines field for v6#9104
Conversation
Overall package sizeSelf size: 6.43 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.2.0 | 104.26 kB | 843.44 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 916f093 | Docs | Datadog PR Page | Give us feedback! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 17eed0cbaa
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "homepage": "https://github.com/DataDog/dd-trace-js#readme", | ||
| "engines": { | ||
| "node": ">=18" | ||
| "node": ">=22" |
There was a problem hiding this comment.
Restore Cypress latest coverage on the oldest supported Node
With this engine floor, .github/actions/node/setup/action.yml resolves version: oldest from the first number in package.json, so oldest becomes Node 22. The integration-cypress matrix still excludes version: oldest with cypress-version: latest based on the old Node 18 limitation (.github/workflows/test-optimization.yml:388-390), while the Cypress specs allow latest for DD_MAJOR === 6 when NODE_MAJOR > 18 (for example integration-tests/cypress/cypress-reporting.spec.js:53-63). This means v6 CI stops exercising Cypress latest on the minimum supported Node version; remove or adjust that exclusion when bumping the floor.
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9104 +/- ##
=======================================
Coverage 93.73% 93.73%
=======================================
Files 892 892
Lines 51238 51238
Branches 11923 11923
=======================================
Hits 48027 48027
Misses 3211 3211 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2026-06-30 18:35:40 Comparing candidate commit 916f093 in PR branch Found 4 performance improvements and 0 performance regressions! Performance is the same for 2209 metrics, 73 unstable metrics.
|
What does this PR do?
This PR bumps the engines field to 22 for v6.
Motivation
Additional Notes