Skip to content

ci(release): fix branch-diff Infinity crash on scientific notation SHAs#9101

Merged
rochdev merged 1 commit into
masterfrom
rochdev/fix-release-proposal-sha-coercion
Jun 26, 2026
Merged

ci(release): fix branch-diff Infinity crash on scientific notation SHAs#9101
rochdev merged 1 commit into
masterfrom
rochdev/fix-release-proposal-sha-coercion

Conversation

@rochdev

@rochdev rochdev commented Jun 26, 2026

Copy link
Copy Markdown
Member

Summary

  • branch-diff --format=sha returns abbreviated SHAs (e.g. 980e663509) that can match JavaScript's scientific notation float syntax
  • branch-diff uses minimist to parse CLI args, which auto-coerces such positional arguments to numbers — 980e663509 becomes Infinity
  • This causes git merge-base v5.x Infinity to fail with exit code 128
  • Fix: expand upperBoundSha to its full 40-char SHA via git rev-parse before passing it as a positional argument back to branch-diff; a full SHA almost always contains a hex letter (a-f) past position 10, breaking minimist's float regex

Triggered by the release proposal CI run: https://github.com/DataDog/dd-trace-js/actions/runs/28264161038/job/83746751389

Test plan

  • Re-run the Release Proposal workflow for v5 and verify it completes successfully

🤖 Generated with Claude Code

Abbreviated SHAs from `branch-diff --format=sha` that match JavaScript's
float syntax (e.g. `980e663509` = 980 × 10^663509) get coerced to
`Infinity` by minimist, causing `git merge-base v5.x Infinity` to fail.

Fix by expanding `upperBoundSha` to its full 40-char form via `git rev-parse`
before passing it as a positional argument to branch-diff. A full SHA almost
certainly contains a hex letter (a-f) past position 10, breaking minimist's
float-detection regex.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
@dd-octo-sts

dd-octo-sts Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 6.37 MB
Deduped: 7.43 MB
No deduping: 7.43 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.2.0 | 104.26 kB | 843.44 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.67%. Comparing base (980e663) to head (12aef3c).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9101      +/-   ##
==========================================
+ Coverage   93.00%   93.67%   +0.67%     
==========================================
  Files         889      889              
  Lines       50885    50885              
  Branches    10023    10023              
==========================================
+ Hits        47325    47669     +344     
+ Misses       3560     3216     -344     
Flag Coverage Δ
aiguard-integration-active 41.52% <ø> (-0.13%) ⬇️
aiguard-integration-latest 41.66% <ø> (+<0.01%) ⬆️
aiguard-integration-maintenance 41.73% <ø> (+<0.01%) ⬆️
aiguard-macos 34.55% <ø> (-0.08%) ⬇️
aiguard-ubuntu 34.70% <ø> (-0.08%) ⬇️
aiguard-windows 34.38% <ø> (-0.08%) ⬇️
apm-capabilities-tracing-macos 48.27% <ø> (ø)
apm-capabilities-tracing-ubuntu-active 48.44% <ø> (-0.01%) ⬇️
apm-capabilities-tracing-ubuntu-latest 48.27% <ø> (ø)
apm-capabilities-tracing-ubuntu-maintenance 48.49% <ø> (ø)
apm-capabilities-tracing-ubuntu-oldest 48.50% <ø> (+<0.01%) ⬆️
apm-capabilities-tracing-windows 48.27% <ø> (+<0.01%) ⬆️
apm-integrations-aerospike-18-gte.5.2.0 33.08% <ø> (-0.08%) ⬇️
apm-integrations-aerospike-20-gte.5.5.0 33.10% <ø> (-0.08%) ⬇️
apm-integrations-aerospike-22-gte.5.12.1 33.11% <ø> (-0.08%) ⬇️
apm-integrations-aerospike-22-gte.6.0.0 33.11% <ø> (-0.08%) ⬇️
apm-integrations-aerospike-eol- 42.41% <ø> (ø)
apm-integrations-child-process 34.01% <ø> (-0.08%) ⬇️
apm-integrations-confluentinc-kafka-javascript-18 39.97% <ø> (-0.08%) ⬇️
apm-integrations-confluentinc-kafka-javascript-20 39.99% <ø> (-0.08%) ⬇️
apm-integrations-confluentinc-kafka-javascript-22 39.99% <ø> (-0.08%) ⬇️
apm-integrations-confluentinc-kafka-javascript-24 39.89% <ø> (-0.08%) ⬇️
apm-integrations-couchbase-eol 33.14% <ø> (-0.08%) ⬇️
apm-integrations-couchbase-oldest 33.26% <ø> (?)
apm-integrations-dns 32.95% <ø> (-0.08%) ⬇️
apm-integrations-elasticsearch 34.13% <ø> (-0.07%) ⬇️
apm-integrations-http-latest 41.89% <ø> (-0.07%) ⬇️
apm-integrations-http-maintenance 41.98% <ø> (-0.07%) ⬇️
apm-integrations-http-oldest 41.91% <ø> (-0.07%) ⬇️
apm-integrations-http2 38.85% <ø> (-0.24%) ⬇️
apm-integrations-kafkajs-latest 40.12% <ø> (+0.02%) ⬆️
apm-integrations-kafkajs-oldest 40.11% <ø> (-0.17%) ⬇️
apm-integrations-net 33.63% <ø> (-0.08%) ⬇️
apm-integrations-next-11.1.4 36.36% <ø> (ø)
apm-integrations-next-12.3.7 36.36% <ø> (ø)
apm-integrations-next-13.0.0 29.12% <ø> (-0.08%) ⬇️
apm-integrations-next-13.2.0 29.12% <ø> (-0.08%) ⬇️
apm-integrations-next-13.5.11 29.29% <ø> (-0.04%) ⬇️
apm-integrations-next-14.0.0 29.18% <ø> (-0.11%) ⬇️
apm-integrations-next-14.2.35 29.18% <ø> (-0.08%) ⬇️
apm-integrations-next-14.2.6 29.22% <ø> (-0.04%) ⬇️
apm-integrations-next-14.2.7 29.18% <ø> (-0.08%) ⬇️
apm-integrations-next-15.0.0 29.18% <ø> (-0.11%) ⬇️
apm-integrations-next-15.4.0 29.25% <ø> (-0.11%) ⬇️
apm-integrations-next-latest 29.29% <ø> (-0.07%) ⬇️
apm-integrations-oracledb 33.96% <ø> (-0.08%) ⬇️
apm-integrations-prisma-18-gte.6.16.0.and.lt.7.0.0 34.77% <ø> (-0.08%) ⬇️
apm-integrations-prisma-latest-all 34.21% <ø> (-0.07%) ⬇️
apm-integrations-restify 35.60% <ø> (-0.08%) ⬇️
apm-integrations-sharedb 32.54% <ø> (-0.08%) ⬇️
apm-integrations-tedious 33.88% <ø> (-0.08%) ⬇️
appsec-express 51.18% <ø> (-0.08%) ⬇️
appsec-fastify 47.99% <ø> (-0.06%) ⬇️
appsec-graphql 47.68% <ø> (-0.05%) ⬇️
appsec-integration-active 36.07% <ø> (ø)
appsec-integration-latest 36.07% <ø> (ø)
appsec-integration-maintenance 36.13% <ø> (ø)
appsec-integration-oldest 36.13% <ø> (ø)
appsec-kafka 40.22% <ø> (-0.07%) ⬇️
appsec-ldapjs 39.76% <ø> (-0.07%) ⬇️
appsec-lodash 39.67% <ø> (-0.07%) ⬇️
appsec-macos 57.04% <ø> (?)
appsec-mongodb-core 43.83% <ø> (-0.06%) ⬇️
appsec-mongoose 44.68% <ø> (-0.05%) ⬇️
appsec-mysql 47.01% <ø> (-0.06%) ⬇️
appsec-next-latest-11.1.4 27.42% <ø> (-0.07%) ⬇️
appsec-next-latest-12.3.7 27.47% <ø> (ø)
appsec-next-latest-13.0.0 29.20% <ø> (-0.08%) ⬇️
appsec-next-latest-13.2.0 29.23% <ø> (-0.08%) ⬇️
appsec-next-latest-13.5.11 29.31% <ø> (-0.08%) ⬇️
appsec-next-latest-14.0.0 29.25% <ø> (-0.08%) ⬇️
appsec-next-latest-14.2.35 29.25% <ø> (-0.08%) ⬇️
appsec-next-latest-14.2.6 29.25% <ø> (-0.08%) ⬇️
appsec-next-latest-14.2.7 29.25% <ø> (-0.08%) ⬇️
appsec-next-latest-15.0.0 29.25% <ø> (-0.08%) ⬇️
appsec-next-latest-latest 29.28% <ø> (-0.08%) ⬇️
appsec-next-oldest-11.1.4 27.54% <ø> (+<0.01%) ⬆️
appsec-next-oldest-12.3.7 29.26% <ø> (-0.08%) ⬇️
appsec-next-oldest-13.0.0 29.26% <ø> (-0.08%) ⬇️
appsec-next-oldest-13.2.0 29.52% <ø> (-0.08%) ⬇️
appsec-next-oldest-13.5.11 29.61% <ø> (?)
appsec-next-oldest-14.0.0 29.55% <ø> (-0.08%) ⬇️
appsec-next-oldest-14.2.35 29.55% <ø> (-0.08%) ⬇️
appsec-next-oldest-14.2.6 29.55% <ø> (-0.08%) ⬇️
appsec-next-oldest-14.2.7 29.55% <ø> (-0.08%) ⬇️
appsec-next-oldest-15.0.0 29.55% <ø> (-0.08%) ⬇️
appsec-next-oldest-latest 27.67% <ø> (ø)
appsec-node-serialize 38.97% <ø> (-0.07%) ⬇️
appsec-passport 42.58% <ø> (-0.07%) ⬇️
appsec-postgres 46.82% <ø> (-0.06%) ⬇️
appsec-sourcing 38.45% <ø> (-0.07%) ⬇️
appsec-stripe 40.48% <ø> (-0.08%) ⬇️
appsec-template 39.26% <ø> (-0.07%) ⬇️
appsec-ubuntu 57.14% <ø> (-0.06%) ⬇️
appsec-windows 56.88% <ø> (-0.15%) ⬇️
debugger-ubuntu-active 43.83% <ø> (ø)
debugger-ubuntu-latest 43.83% <ø> (ø)
debugger-ubuntu-maintenance 43.96% <ø> (ø)
debugger-ubuntu-oldest 44.30% <ø> (+0.04%) ⬆️
instrumentations-instrumentation-ai 45.50% <ø> (ø)
instrumentations-instrumentation-aws-sdk 45.08% <ø> (ø)
instrumentations-instrumentation-bluebird 27.65% <ø> (-0.08%) ⬇️
instrumentations-instrumentation-body-parser 35.63% <ø> (-0.07%) ⬇️
instrumentations-instrumentation-child_process 33.31% <ø> (-0.08%) ⬇️
instrumentations-instrumentation-connect 48.45% <ø> (ø)
instrumentations-instrumentation-cookie-parser 29.54% <ø> (-0.07%) ⬇️
instrumentations-instrumentation-couchbase-18 46.20% <ø> (ø)
instrumentations-instrumentation-couchbase-eol 46.20% <ø> (ø)
instrumentations-instrumentation-crypto 27.61% <ø> (-0.08%) ⬇️
instrumentations-instrumentation-express 29.74% <ø> (-0.07%) ⬇️
instrumentations-instrumentation-express-mongo-sanitize 29.65% <ø> (-0.07%) ⬇️
instrumentations-instrumentation-express-multi-version 41.81% <ø> (ø)
instrumentations-instrumentation-express-session 35.45% <ø> (-0.07%) ⬇️
instrumentations-instrumentation-fastify 48.41% <ø> (ø)
instrumentations-instrumentation-fetch 45.18% <ø> (ø)
instrumentations-instrumentation-fs 27.33% <ø> (-0.08%) ⬇️
instrumentations-instrumentation-generic-pool 27.52% <ø> (ø)
instrumentations-instrumentation-hono 28.85% <ø> (-0.08%) ⬇️
instrumentations-instrumentation-http 37.87% <ø> (-0.08%) ⬇️
instrumentations-instrumentation-http-client-options 37.48% <ø> (-0.08%) ⬇️
instrumentations-instrumentation-kafkajs 49.13% <ø> (ø)
instrumentations-instrumentation-knex 27.63% <ø> (-0.08%) ⬇️
instrumentations-instrumentation-koa 46.08% <ø> (ø)
instrumentations-instrumentation-light-my-request 35.27% <ø> (-0.07%) ⬇️
instrumentations-instrumentation-mongoose 28.74% <ø> (-0.07%) ⬇️
instrumentations-instrumentation-multer 35.31% <ø> (-0.07%) ⬇️
instrumentations-instrumentation-mysql2 33.42% <ø> (-0.08%) ⬇️
instrumentations-instrumentation-openai-lifecycle 46.18% <ø> (ø)
instrumentations-instrumentation-otel-sdk-trace 25.57% <ø> (ø)
instrumentations-instrumentation-passport 39.22% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-passport-http 38.92% <ø> (-0.07%) ⬇️
instrumentations-instrumentation-passport-local 39.37% <ø> (-0.07%) ⬇️
instrumentations-instrumentation-pg 33.16% <ø> (-0.08%) ⬇️
instrumentations-instrumentation-promise 27.60% <ø> (-0.08%) ⬇️
instrumentations-instrumentation-promise-js 27.59% <ø> (-0.08%) ⬇️
instrumentations-instrumentation-q 27.62% <ø> (-0.08%) ⬇️
instrumentations-instrumentation-restify 47.70% <ø> (ø)
instrumentations-instrumentation-router 43.70% <ø> (ø)
instrumentations-instrumentation-stripe 28.13% <ø> (-0.08%) ⬇️
instrumentations-instrumentation-url 27.45% <ø> (-0.08%) ⬇️
instrumentations-instrumentation-when 27.61% <ø> (-0.08%) ⬇️
instrumentations-instrumentation-zlib 27.50% <ø> (-0.08%) ⬇️
instrumentations-integration-esbuild-0.16.12-active 24.71% <ø> (ø)
instrumentations-integration-esbuild-0.16.12-latest 24.71% <ø> (ø)
instrumentations-integration-esbuild-0.16.12-maintenance 18.77% <ø> (ø)
instrumentations-integration-esbuild-0.16.12-oldest 18.76% <ø> (?)
instrumentations-integration-esbuild-latest-active 24.71% <ø> (ø)
instrumentations-integration-esbuild-latest-latest 24.71% <ø> (ø)
instrumentations-integration-esbuild-latest-maintenance 18.77% <ø> (ø)
instrumentations-integration-esbuild-latest-oldest 18.76% <ø> (ø)
llmobs-ai 35.21% <ø> (?)
llmobs-anthropic 36.58% <ø> (-0.07%) ⬇️
llmobs-bedrock 36.12% <ø> (-0.07%) ⬇️
llmobs-google-genai 36.01% <ø> (-0.07%) ⬇️
llmobs-langchain 35.56% <ø> (-0.06%) ⬇️
llmobs-openai-latest 39.45% <ø> (-0.07%) ⬇️
llmobs-openai-oldest 39.53% <ø> (-0.07%) ⬇️
llmobs-sdk-active 43.45% <ø> (-0.08%) ⬇️
llmobs-sdk-latest 43.45% <ø> (-0.08%) ⬇️
llmobs-sdk-maintenance 43.55% <ø> (-0.08%) ⬇️
llmobs-sdk-oldest 43.54% <ø> (?)
llmobs-vertex-ai 35.69% <ø> (-0.07%) ⬇️
master-coverage 93.67% <ø> (?)
openfeature-macos 37.41% <ø> (-0.01%) ⬇️
openfeature-ubuntu 37.55% <ø> (ø)
openfeature-unit-active 49.88% <ø> (ø)
openfeature-unit-latest 49.88% <ø> (ø)
openfeature-unit-maintenance 50.23% <ø> (ø)
openfeature-unit-oldest 50.23% <ø> (ø)
openfeature-windows 37.30% <ø> (+0.04%) ⬆️
platform-core 46.43% <ø> (ø)
platform-esbuild 18.72% <ø> (ø)
platform-instrumentations-misc 29.24% <ø> (ø)
platform-integration-active 47.18% <ø> (ø)
platform-integration-latest 47.16% <ø> (+0.04%) ⬆️
platform-integration-maintenance 46.96% <ø> (ø)
platform-integration-oldest 47.23% <ø> (+0.01%) ⬆️
platform-shimmer 47.45% <ø> (ø)
platform-unit-guardrails 44.40% <ø> (ø)
platform-webpack 18.37% <ø> (ø)
plugins-aws-durable-execution-sdk-js 32.85% <ø> (-0.07%) ⬇️
plugins-axios 35.40% <ø> (-0.02%) ⬇️
plugins-azure-cosmos 35.92% <ø> (-0.08%) ⬇️
plugins-azure-event-hubs 34.77% <ø> (ø)
plugins-azure-service-bus 35.31% <ø> (ø)
plugins-body-parser 36.41% <ø> (ø)
plugins-bullmq 39.37% <ø> (-0.08%) ⬇️
plugins-cassandra 33.57% <ø> (-0.08%) ⬇️
plugins-cookie 40.74% <ø> (ø)
plugins-cookie-parser 40.57% <ø> (ø)
plugins-crypto 42.71% <ø> (ø)
plugins-dd-trace-api 33.16% <ø> (-0.08%) ⬇️
plugins-express-mongo-sanitize 40.62% <ø> (ø)
plugins-express-session 40.48% <ø> (ø)
plugins-fastify 37.73% <ø> (-0.07%) ⬇️
plugins-fetch 34.51% <ø> (-0.07%) ⬇️
plugins-fs 33.59% <ø> (-0.08%) ⬇️
plugins-generic-pool 40.05% <ø> (ø)
plugins-google-cloud-pubsub 41.25% <ø> (-0.07%) ⬇️
plugins-grpc 36.44% <ø> (-0.07%) ⬇️
plugins-handlebars 40.62% <ø> (ø)
plugins-hapi 35.73% <ø> (-0.08%) ⬇️
plugins-hono 35.84% <ø> (-0.08%) ⬇️
plugins-ioredis 34.22% <ø> (-0.08%) ⬇️
plugins-jest 27.03% <ø> (?)
plugins-knex 40.09% <ø> (ø)
plugins-langgraph 32.30% <ø> (-0.08%) ⬇️
plugins-ldapjs 39.05% <ø> (ø)
plugins-light-my-request 40.19% <ø> (ø)
plugins-limitd-client 27.95% <ø> (?)
plugins-lodash 40.23% <ø> (ø)
plugins-mariadb 34.84% <ø> (-0.08%) ⬇️
plugins-memcached 33.61% <ø> (?)
plugins-microgateway-core 34.69% <ø> (-0.08%) ⬇️
plugins-modelcontextprotocol-sdk 32.26% <ø> (-0.08%) ⬇️
plugins-moleculer 36.50% <ø> (-0.08%) ⬇️
plugins-mongodb 35.80% <ø> (-0.07%) ⬇️
plugins-mongodb-core 35.33% <ø> (-0.08%) ⬇️
plugins-mongoose 34.49% <ø> (-0.07%) ⬇️
plugins-multer 40.54% <ø> (ø)
plugins-mysql 34.54% <ø> (-0.08%) ⬇️
plugins-mysql2 34.87% <ø> (-0.10%) ⬇️
plugins-nats 36.22% <ø> (-0.08%) ⬇️
plugins-node-serialize 40.46% <ø> (ø)
plugins-opensearch 33.51% <ø> (-0.23%) ⬇️
plugins-passport-http 40.36% <ø> (ø)
plugins-pino 29.84% <ø> (-0.08%) ⬇️
plugins-postgres 34.59% <ø> (-0.08%) ⬇️
plugins-process 42.71% <ø> (ø)
plugins-pug 40.74% <ø> (ø)
plugins-redis 34.18% <ø> (-0.08%) ⬇️
plugins-router 38.11% <ø> (-0.08%) ⬇️
plugins-sequelize 40.01% <ø> (ø)
plugins-test-and-upstream-amqp10 33.76% <ø> (-0.08%) ⬇️
plugins-test-and-upstream-amqplib 39.04% <ø> (-0.08%) ⬇️
plugins-test-and-upstream-apollo 34.77% <ø> (-0.07%) ⬇️
plugins-test-and-upstream-avsc 33.65% <ø> (-0.08%) ⬇️
plugins-test-and-upstream-bunyan 29.06% <ø> (-0.08%) ⬇️
plugins-test-and-upstream-connect 36.23% <ø> (-0.08%) ⬇️
plugins-test-and-upstream-graphql 36.01% <ø> (-0.07%) ⬇️
plugins-test-and-upstream-koa 35.79% <ø> (-0.08%) ⬇️
plugins-test-and-upstream-protobufjs 33.88% <ø> (-0.08%) ⬇️
plugins-test-and-upstream-rhea 38.98% <ø> (-0.08%) ⬇️
plugins-undici 34.94% <ø> (-0.07%) ⬇️
plugins-url 42.71% <ø> (ø)
plugins-valkey 33.71% <ø> (-0.08%) ⬇️
plugins-vm 42.71% <ø> (ø)
plugins-winston 29.72% <ø> (-0.08%) ⬇️
plugins-ws 36.98% <ø> (-0.08%) ⬇️
profiling-macos 43.05% <ø> (-0.02%) ⬇️
profiling-ubuntu 43.43% <ø> (-0.07%) ⬇️
profiling-windows 41.06% <ø> (-0.07%) ⬇️
serverless-aws-sdk-latest-aws-sdk 33.10% <ø> (-0.07%) ⬇️
serverless-aws-sdk-latest-bedrockruntime 31.96% <ø> (-0.07%) ⬇️
serverless-aws-sdk-latest-client 36.39% <ø> (ø)
serverless-aws-sdk-latest-dynamodb 33.95% <ø> (-0.02%) ⬇️
serverless-aws-sdk-latest-eventbridge 27.13% <ø> (-0.07%) ⬇️
serverless-aws-sdk-latest-kinesis 37.13% <ø> (-0.07%) ⬇️
serverless-aws-sdk-latest-lambda 34.39% <ø> (-0.07%) ⬇️
serverless-aws-sdk-latest-s3 32.36% <ø> (-0.07%) ⬇️
serverless-aws-sdk-latest-serverless-peer-service 39.24% <ø> (-0.08%) ⬇️
serverless-aws-sdk-latest-sns 38.05% <ø> (-0.07%) ⬇️
serverless-aws-sdk-latest-sqs 37.82% <ø> (-0.07%) ⬇️
serverless-aws-sdk-latest-stepfunctions 32.98% <ø> (-0.07%) ⬇️
serverless-aws-sdk-latest-util 46.83% <ø> (ø)
serverless-aws-sdk-oldest-aws-sdk 33.20% <ø> (-0.07%) ⬇️
serverless-aws-sdk-oldest-bedrockruntime 32.05% <ø> (-0.07%) ⬇️
serverless-aws-sdk-oldest-client 36.96% <ø> (ø)
serverless-aws-sdk-oldest-dynamodb 33.99% <ø> (-0.12%) ⬇️
serverless-aws-sdk-oldest-eventbridge 27.21% <ø> (?)
serverless-aws-sdk-oldest-kinesis 37.30% <ø> (-0.07%) ⬇️
serverless-aws-sdk-oldest-lambda 34.49% <ø> (-0.07%) ⬇️
serverless-aws-sdk-oldest-s3 32.49% <ø> (?)
serverless-aws-sdk-oldest-serverless-peer-service 39.33% <ø> (-0.08%) ⬇️
serverless-aws-sdk-oldest-sns 38.15% <ø> (-0.07%) ⬇️
serverless-aws-sdk-oldest-sqs 37.89% <ø> (-0.07%) ⬇️
serverless-aws-sdk-oldest-stepfunctions 33.08% <ø> (-0.07%) ⬇️
serverless-aws-sdk-oldest-util 47.59% <ø> (ø)
serverless-azure-durable-functions 36.76% <ø> (ø)
serverless-azure-functions-eventhubs 38.33% <ø> (ø)
serverless-azure-functions-servicebus 38.39% <ø> (ø)
serverless-lambda 34.30% <ø> (-0.09%) ⬇️
test-optimization-cucumber-latest-7.0.0 49.79% <ø> (+0.11%) ⬆️
test-optimization-cucumber-latest-latest 52.48% <ø> (+0.11%) ⬆️
test-optimization-cucumber-oldest-7.0.0 49.87% <ø> (+0.11%) ⬆️
test-optimization-cypress-latest-12.0.0-commonJS 49.12% <ø> (+0.68%) ⬆️
test-optimization-cypress-latest-12.0.0-esm 49.15% <ø> (+0.07%) ⬆️
test-optimization-cypress-latest-14.5.4-commonJS 48.98% <ø> (+0.20%) ⬆️
test-optimization-cypress-latest-14.5.4-esm 49.00% <ø> (+1.77%) ⬆️
test-optimization-cypress-latest-latest-commonJS 49.45% <ø> (+0.07%) ⬆️
test-optimization-cypress-latest-latest-esm 49.48% <ø> (+0.07%) ⬆️
test-optimization-cypress-oldest-12.0.0-commonJS 49.21% <ø> (+1.78%) ⬆️
test-optimization-cypress-oldest-12.0.0-esm 49.24% <ø> (+1.78%) ⬆️
test-optimization-cypress-oldest-14.5.4-commonJS 49.06% <ø> (+0.07%) ⬆️
test-optimization-cypress-oldest-14.5.4-esm 49.09% <ø> (+0.07%) ⬆️
test-optimization-jest-latest-latest 55.19% <ø> (+2.61%) ⬆️
test-optimization-jest-latest-oldest 54.13% <ø> (+0.14%) ⬆️
test-optimization-jest-oldest-latest 55.24% <ø> (+0.07%) ⬆️
test-optimization-jest-oldest-oldest 54.14% <ø> (+0.07%) ⬆️
test-optimization-mocha-latest-latest 53.43% <ø> (+0.08%) ⬆️
test-optimization-mocha-latest-oldest 51.02% <ø> (+0.08%) ⬆️
test-optimization-mocha-oldest-latest 53.53% <ø> (+0.08%) ⬆️
test-optimization-mocha-oldest-oldest 51.03% <ø> (+0.10%) ⬆️
test-optimization-playwright-latest-latest-playwright-active-test-span 44.15% <ø> (?)
test-optimization-playwright-latest-latest-playwright-atr 42.96% <ø> (+0.10%) ⬆️
test-optimization-playwright-latest-latest-playwright-efd 43.38% <ø> (+0.08%) ⬆️
test-optimization-playwright-latest-latest-playwright-final-status 43.42% <ø> (+0.10%) ⬆️
test-optimization-playwright-latest-latest-playwright-impacted-tests 42.92% <ø> (ø)
test-optimization-playwright-latest-latest-playwright-reporting 43.00% <ø> (+0.08%) ⬆️
test-optimization-playwright-latest-latest-playwright-test-management 44.44% <ø> (+0.09%) ⬆️
test-optimization-playwright-latest-oldest-playwright-active-test-span 44.11% <ø> (?)
test-optimization-playwright-latest-oldest-playwright-atr 43.02% <ø> (+0.10%) ⬆️
test-optimization-playwright-latest-oldest-playwright-efd 43.31% <ø> (+0.08%) ⬆️
test-optimization-playwright-latest-oldest-playwright-final-status 43.38% <ø> (+0.13%) ⬆️
test-optimization-playwright-latest-oldest-playwright-impacted-tests 42.85% <ø> (ø)
test-optimization-playwright-latest-oldest-playwright-reporting 42.80% <ø> (+0.08%) ⬆️
test-optimization-playwright-latest-oldest-playwright-test-management 44.39% <ø> (+0.12%) ⬆️
test-optimization-playwright-oldest-latest-playwright-active-test-span 44.37% <ø> (+0.08%) ⬆️
test-optimization-playwright-oldest-latest-playwright-atr 43.04% <ø> (+0.08%) ⬆️
test-optimization-playwright-oldest-latest-playwright-efd 43.43% <ø> (+0.08%) ⬆️
test-optimization-playwright-oldest-latest-playwright-final-status 43.50% <ø> (+0.06%) ⬆️
test-optimization-playwright-oldest-latest-playwright-impacted-tests 42.99% <ø> (ø)
test-optimization-playwright-oldest-latest-playwright-reporting 43.06% <ø> (+0.08%) ⬆️
test-optimization-playwright-oldest-latest-playwright-test-management 44.52% <ø> (+0.08%) ⬆️
test-optimization-playwright-oldest-oldest-playwright-active-test-span 44.19% <ø> (?)
test-optimization-playwright-oldest-oldest-playwright-atr 43.11% <ø> (+0.10%) ⬆️
test-optimization-playwright-oldest-oldest-playwright-efd 43.37% <ø> (+0.08%) ⬆️
test-optimization-playwright-oldest-oldest-playwright-final-status 43.46% <ø> (+0.10%) ⬆️
test-optimization-playwright-oldest-oldest-playwright-impacted-tests 42.93% <ø> (ø)
test-optimization-playwright-oldest-oldest-playwright-reporting 42.86% <ø> (?)
test-optimization-playwright-oldest-oldest-playwright-test-management 44.48% <ø> (?)
test-optimization-selenium-latest 45.42% <ø> (?)
test-optimization-selenium-oldest 45.01% <ø> (+0.07%) ⬆️
test-optimization-testopt-active 48.14% <ø> (+0.12%) ⬆️
test-optimization-testopt-latest 48.13% <ø> (+0.12%) ⬆️
test-optimization-testopt-maintenance 48.01% <ø> (+0.13%) ⬆️
test-optimization-testopt-oldest 49.30% <ø> (+0.09%) ⬆️
test-optimization-vitest-latest 50.79% <ø> (+1.15%) ⬆️
test-optimization-vitest-oldest 48.07% <ø> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Jun 26, 2026

Copy link
Copy Markdown

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 1 Pipeline job failed

DataDog/apm-reliability/dd-trace-js | create-multiarch-lib-injection-image   View in Datadog   GitLab

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 12aef3c | Docs | Datadog PR Page | Give us feedback!

@rochdev
rochdev marked this pull request as ready for review June 26, 2026 21:03
@rochdev
rochdev requested a review from a team as a code owner June 26, 2026 21:03
@pr-commenter

pr-commenter Bot commented Jun 26, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-06-26 21:08:16

Comparing candidate commit 12aef3c in PR branch rochdev/fix-release-proposal-sha-coercion with baseline commit 980e663 in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 0 performance regressions! Performance is the same for 2256 metrics, 30 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:appsec-appsec-enabled-20

  • unstable execution_time [-190.212ms; +187.304ms] or [-5.143%; +5.064%]

scenario:appsec-appsec-enabled-24

  • unstable execution_time [-184.988ms; +180.402ms] or [-7.026%; +6.851%]

scenario:appsec-appsec-enabled-26

  • unstable execution_time [-175.300ms; +232.300ms] or [-7.032%; +9.319%]

scenario:appsec-control-20

  • unstable execution_time [-157.643ms; +155.279ms] or [-8.990%; +8.855%]

scenario:appsec-control-24

  • unstable execution_time [-104.523ms; +101.962ms] or [-8.624%; +8.412%]

scenario:appsec-control-26

  • unstable execution_time [-118710.567µs; +119465.300µs] or [-9.798%; +9.860%]

scenario:debugger-line-probe-with-snapshot-default-26

  • unstable cpu_user_time [-2979.558ms; +2923.487ms] or [-29.878%; +29.316%]
  • unstable execution_time [-2994.643ms; +2949.300ms] or [-28.100%; +27.675%]
  • unstable instructions [-26178.0M instructions; +26135.3M instructions] or [-31.524%; +31.473%]
  • unstable max_rss_usage [-9797.928KB; +9121.928KB] or [-6.079%; +5.659%]
  • unstable throughput [-647.363op/s; +664.098op/s] or [-20.608%; +21.140%]

scenario:debugger-line-probe-with-snapshot-minimal-24

  • unstable cpu_user_time [-1970.364ms; +3085.095ms] or [-24.890%; +38.971%]
  • unstable execution_time [-1969.117ms; +3118.207ms] or [-22.927%; +36.306%]
  • unstable instructions [-16.8G instructions; +26.6G instructions] or [-26.047%; +41.300%]
  • unstable max_rss_usage [-7.147MB; +11.585MB] or [-4.528%; +7.339%]
  • unstable throughput [-907.919op/s; +576.045op/s] or [-23.591%; +14.968%]

scenario:debugger-line-probe-without-snapshot-24

  • unstable cpu_user_time [-452.021ms; +729.235ms] or [-6.038%; +9.741%]
  • unstable execution_time [-487.180ms; +759.144ms] or [-5.972%; +9.305%]
  • unstable instructions [-3.9G instructions; +6.1G instructions] or [-6.466%; +10.064%]
  • unstable throughput [-324.156op/s; +208.097op/s] or [-8.199%; +5.264%]

scenario:dogstatsd-with-tags-20

  • unstable cpu_user_time [-484.377ms; +247.568ms] or [-9.657%; +4.936%]
  • unstable execution_time [-483.096ms; +250.550ms] or [-9.495%; +4.924%]
  • unstable throughput [-85523.194op/s; +165857.781op/s] or [-5.181%; +10.047%]

scenario:plugin-graphql-long-with-depth-and-collapse-off-24

  • unstable cpu_user_time [-454.164ms; +213.874ms] or [-10.105%; +4.759%]
  • unstable execution_time [-490.643ms; +220.547ms] or [-10.258%; +4.611%]
  • unstable max_rss_usage [-64.692MB; +18.941MB] or [-11.987%; +3.510%]
  • unstable throughput [-2.102op/s; +4.729op/s] or [-4.704%; +10.584%]

scenario:plugin-graphql-long-with-depth-off-20

  • unstable max_rss_usage [-7.116MB; +16.792MB] or [-4.784%; +11.288%]

scenario:sampling-rate-limited-20

  • unstable cpu_user_time [-66.137ms; +103.539ms] or [-4.649%; +7.278%]
  • unstable execution_time [-67.735ms; +101.832ms] or [-4.748%; +7.137%]

@rochdev
rochdev enabled auto-merge (squash) June 26, 2026 21:08
@rochdev
rochdev merged commit 3489ad8 into master Jun 26, 2026
958 of 959 checks passed
@rochdev
rochdev deleted the rochdev/fix-release-proposal-sha-coercion branch June 26, 2026 21:09
This was referenced Jun 26, 2026
rochdev added a commit that referenced this pull request Jul 2, 2026
rochdev added a commit that referenced this pull request Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants