bench(integrations): tune dns/graphql/http/net/aws-sdk/propagation; drop bluebird and q#8734
Merged
Merged
Conversation
Contributor
Overall package sizeSelf size: 6.09 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.1 | 82.56 kB | 817.39 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 35b66fc | Docs | Datadog PR Page | Give us feedback! |
BridgeAR
force-pushed
the
BridgeAR/2026-05-31-bench-integrations
branch
from
May 31, 2026 19:21
71d6519 to
f0066f4
Compare
BenchmarksBenchmark execution time: 2026-06-03 16:31:04 Comparing candidate commit 35b66fc in PR branch Found 16 performance improvements and 69 performance regressions! Performance is the same for 1334 metrics, 48 unstable metrics. scenario:net-with-tracer-20
scenario:net-with-tracer-22
scenario:net-with-tracer-24
scenario:plugin-aws-sdk-extract-response-body-20
scenario:plugin-aws-sdk-extract-response-body-22
scenario:plugin-aws-sdk-extract-response-body-24
scenario:plugin-dns-with-tracer-20
scenario:plugin-dns-with-tracer-22
scenario:plugin-dns-with-tracer-24
scenario:plugin-graphql-long-with-depth-and-collapse-off-20
scenario:plugin-graphql-long-with-depth-and-collapse-off-22
scenario:plugin-graphql-long-with-depth-and-collapse-off-24
scenario:plugin-graphql-long-with-depth-off-20
scenario:plugin-graphql-long-with-depth-off-22
scenario:plugin-graphql-long-with-depth-off-24
scenario:plugin-graphql-long-with-depth-on-max-20
scenario:plugin-graphql-long-with-depth-on-max-22
scenario:plugin-graphql-long-with-depth-on-max-24
scenario:plugin-http-client-with-tracer-20
scenario:plugin-http-client-with-tracer-22
scenario:plugin-http-client-with-tracer-24
scenario:plugin-http-server-querystring-obfuscation-20
scenario:plugin-http-server-querystring-obfuscation-22
scenario:plugin-http-server-querystring-obfuscation-24
scenario:plugin-http-server-with-tracer-20
scenario:plugin-http-server-with-tracer-22
scenario:plugin-http-server-with-tracer-24
|
BridgeAR
force-pushed
the
BridgeAR/2026-05-31-bench-integrations
branch
from
June 1, 2026 11:41
f0066f4 to
f5e0be3
Compare
BridgeAR
marked this pull request as ready for review
June 1, 2026 12:13
BridgeAR
requested review from
khanayan123 and
wconti27
and removed request for
a team
June 1, 2026 12:13
BridgeAR
force-pushed
the
BridgeAR/2026-05-31-bench-integrations
branch
from
June 2, 2026 14:26
f5e0be3 to
a54d611
Compare
Base automatically changed from
BridgeAR/2026-05-31-benchmark-platform-job
to
master
June 2, 2026 18:34
rochdev
previously approved these changes
Jun 3, 2026
BridgeAR
force-pushed
the
BridgeAR/2026-05-31-bench-integrations
branch
from
June 3, 2026 11:08
a5b2b17 to
1e369aa
Compare
Bring the integration sirun benches under the per-variant runtime budget and retire the bluebird/q benches: 1. dns and http lower their sirun repeat counts (20 -> 10, 20 -> 15); the graphql-long variants lower their query counts so each targets ~1 minute, with the startup-guard share staying under the ceiling. 2. dns/graphql/http/net/aws-sdk/propagation fixtures drive the instrumentation hot path rather than fixture construction. 3. bluebird and q benches are removed, along with their PLUGINS install entry and CODEOWNERS lines. 4. Leftover baseline keys are dropped from the debugger and llmobs metas.
BridgeAR
force-pushed
the
BridgeAR/2026-05-31-bench-integrations
branch
from
June 3, 2026 16:14
1e369aa to
35b66fc
Compare
rochdev
approved these changes
Jun 3, 2026
BridgeAR
enabled auto-merge (squash)
June 3, 2026 16:21
bengl
reviewed
Jun 3, 2026
| "baseline": "control", | ||
| "env": { "WITH_TRACER": "1", "WITH_DEPTH_AND_COLLAPSE": "4,0" } | ||
| }, | ||
| "with-depth-and-collapse-on": { |
Collaborator
There was a problem hiding this comment.
Why is this variant removed?
Member
Author
There was a problem hiding this comment.
It was a duplicate. Collapse is active by default.
Merged
crysmags
added a commit
that referenced
this pull request
Jun 9, 2026
…nch rework The earlier revert (90a60ba) used a stale local master ref and pulled an older version of these files. Master has since picked up #8787 (profiler workload + llmobs guard + shortened benches) and #8734 (integration tuning) which both touch these paths, so the branch went CONFLICTING and Actions stopped triggering on new commits. Pulls in origin/master's current shape for both meta.json (3 variants, adjusted query counts) and index.js (startup guard + assert + the no-WITH_ASYNC_HOOKS path). No graphql plugin code is affected. Co-Authored-By: Claude Opus 4.7 <[email protected]>
BridgeAR
added a commit
that referenced
this pull request
Jun 11, 2026
…rop bluebird and q (#8734) Bring the integration sirun benches under the per-variant runtime budget and retire the bluebird/q benches: 1. dns and http lower their sirun repeat counts (20 -> 10, 20 -> 15); the graphql-long variants lower their query counts so each targets ~1 minute, with the startup-guard share staying under the ceiling. 2. dns/graphql/http/net/aws-sdk/propagation fixtures drive the instrumentation hot path rather than fixture construction. 3. bluebird and q benches are removed, along with their PLUGINS install entry and CODEOWNERS lines. 4. Leftover baseline keys are dropped from the debugger and llmobs metas.
tlhunter
pushed a commit
that referenced
this pull request
Jun 18, 2026
…rop bluebird and q (#8734) Bring the integration sirun benches under the per-variant runtime budget and retire the bluebird/q benches: 1. dns and http lower their sirun repeat counts (20 -> 10, 20 -> 15); the graphql-long variants lower their query counts so each targets ~1 minute, with the startup-guard share staying under the ceiling. 2. dns/graphql/http/net/aws-sdk/propagation fixtures drive the instrumentation hot path rather than fixture construction. 3. bluebird and q benches are removed, along with their PLUGINS install entry and CODEOWNERS lines. 4. Leftover baseline keys are dropped from the debugger and llmobs metas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tunes the dns, graphql-long, http, net, aws-sdk, and propagation benches (loop counts, HTTP keep-alive, env-driven iterations), and removes the bluebird and q benches -- redundant userland-promise hops that don't catch tracer regressions.
Test plan