refactor(test-optimization)!: raise Jest minimum version to 28.0.0#8246
Conversation
Overall package sizeSelf size: 5.7 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.1 | 82.56 kB | 817.39 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
This comment has been minimized.
This comment has been minimized.
BenchmarksBenchmark execution time: 2026-05-04 12:48:32 Comparing candidate commit 095f7e8 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1752 metrics, 92 unstable metrics. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
f59c96a to
095f7e8
Compare
… fail `gh api graphql -f variables="$variables"` does not parse the value as JSON; gh forwards it as a string and GitHub responds with the misleading `Variable $input of type CreateCommitOnBranchInput! was provided invalid value` instead of accepting the request. The `supported-integrations-push` job has been silently broken since it landed; the most recent failure is run 25309510001 on PR #8246. The same broken pattern lives in `update-3rdparty-licenses`, where the push step rarely fires so nobody noticed. Build the full `{query, variables}` body with `jq -nc` and pipe it to `gh api graphql --input -`. Reproduced locally on gh 2.89 that the new pattern returns proper `NOT_FOUND` / `STALE_DATA` errors when the SHA doesn't match, instead of the type-validation noise. Drive-by: `update-3rdparty-licenses` also had `jq -c` instead of `jq -nc`, which silently produces empty output on a runner since there is no piped stdin — a second latent bug in the same shell snippet. The new pattern uses `-nc` everywhere, so the two workflows stay in lockstep.
… fail `gh api graphql -f variables="$variables"` forwards the value as a string instead of parsing it as JSON; GitHub returns the misleading `Variable $input ... was provided invalid value`. Latest failure: run 25309510001 on PR #8246. The same pattern lives in `update-3rdparty-licenses`; that job's push step rarely fires so nobody noticed. Drive-by fix: `update-3rdparty-licenses` also had `jq -c` instead of `jq -nc`, silently producing empty output on a runner with no stdin.
#8252) `gh api graphql -f variables="$variables"` forwards the value as a string instead of parsing it as JSON; GitHub returns the misleading `Variable $input ... was provided invalid value`. Latest failure: run 25309510001 on PR #8246. The same pattern lives in `update-3rdparty-licenses`; that job's push step rarely fires so nobody noticed. Drive-by fix: `update-3rdparty-licenses` also had `jq -c` instead of `jq -nc`, silently producing empty output on a runner with no stdin.
#8252) `gh api graphql -f variables="$variables"` forwards the value as a string instead of parsing it as JSON; GitHub returns the misleading `Variable $input ... was provided invalid value`. Latest failure: run 25309510001 on PR #8246. The same pattern lives in `update-3rdparty-licenses`; that job's push step rarely fires so nobody noticed. Drive-by fix: `update-3rdparty-licenses` also had `jq -c` instead of `jq -nc`, silently producing empty output on a runner with no stdin.
What does this PR do?
Raises the minimum supported Jest version to
>=28.0.0for dd-trace v6 while keeping v5 support at>=24.8.0.Updates the Test Optimization Jest matrix to use the
oldestselector, maps that selector to28.0.0on v6 and24.8.0on v5, and installsjest-environment-jsdomfor Jest versions that require it.Motivation
Jest 28 supports the advanced Test Optimization behavior needed for v6, while v5 will continue supporting older Jest versions. Users running v5 with Jest
<28.0.0will see a deprecation warning so they can upgrade before v6.