fix race condition in all-green script causing invalid summary#7836
fix race condition in all-green script causing invalid summary#7836
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7836 +/- ##
=======================================
Coverage 80.48% 80.48%
=======================================
Files 749 749
Lines 32457 32457
=======================================
Hits 26124 26124
Misses 6333 6333 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Overall package sizeSelf size: 5.04 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.0 | 81.15 kB | 815.98 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BenchmarksBenchmark execution time: 2026-03-23 14:11:40 Comparing candidate commit 4e75c42 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 230 metrics, 30 unstable metrics. |
| completed_at: run.completed_at ?? ' ', | ||
| })) | ||
|
|
||
| console.table(runs) |
There was a problem hiding this comment.
Could we limit the logging to entries that are not successful? It would otherwise be very verbose
There was a problem hiding this comment.
That would hide information that could be useful for debugging. What if the entry you want is missing? Was it successful? Otherwise where is it?
There was a problem hiding this comment.
Could always split them by status but that can be improved later.
There was a problem hiding this comment.
Not a fan, while I see your point and guess we can look into it again a bit later
There was a problem hiding this comment.
Yeah for now I just made it consistent with the existing summary. We can improve the UI in a future PR.
* fix race condition in all-green script causing invalid output * add console logging of the summary
* fix race condition in all-green script causing invalid output * add console logging of the summary
2 participants
What does this PR do?
Fix race condition in all-green script causing invalid summary. I also added the summary to the console output so that it can be used outside of GitHub.
Motivation
Previously it would wait for the interval after a check before throwing if the maximum number of retries was reached. If anything was not done by the time the timeout was reached but was done after the interval, it would show as completed in the summary.
Additional Notes
There is still technically a race condition since the data needs to be collected again in a different way to produce the summary, but it's now in milliseconds instead of in minutes.