Skip to content

fix npm prepare when node env is set to production#7805

Merged
BridgeAR merged 1 commit intomasterfrom
fix-npm-prepare-node-env
Mar 17, 2026
Merged

fix npm prepare when node env is set to production#7805
BridgeAR merged 1 commit intomasterfrom
fix-npm-prepare-node-env

Conversation

@rochdev
Copy link
Copy Markdown
Member

@rochdev rochdev commented Mar 17, 2026

What does this PR do?

Fix npm prepare when NODE_ENV is set to production.

Motivation

The prepare script runs a new install in a subfolder which always requires dev dependencies to be present to work.

Additional Notes

Technically this means they are prod dependencies, but keeping them as dev dependencies provides a clear distinction with the dependencies that will be vendored.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 17, 2026

Overall package size

Self size: 4.97 MB
Deduped: 5.81 MB
No deduping: 5.81 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.0 | 81.15 kB | 815.98 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.23%. Comparing base (6dac2bd) to head (a526c94).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7805       +/-   ##
===========================================
+ Coverage   70.06%   80.23%   +10.17%     
===========================================
  Files         706      748       +42     
  Lines       30237    32404     +2167     
===========================================
+ Hits        21185    26000     +4815     
+ Misses       9052     6404     -2648     
Flag Coverage Δ
aiguard-macos 39.08% <ø> (-0.10%) ⬇️
aiguard-ubuntu 39.20% <ø> (-0.10%) ⬇️
aiguard-windows 38.93% <ø> (-0.10%) ⬇️
apm-capabilities-tracing-macos 48.90% <ø> (ø)
apm-capabilities-tracing-ubuntu 48.93% <ø> (?)
apm-capabilities-tracing-windows 48.67% <ø> (ø)
apm-integrations-child-process 38.38% <ø> (?)
apm-integrations-couchbase-18 37.30% <ø> (?)
apm-integrations-couchbase-eol 37.76% <ø> (?)
apm-integrations-oracledb 37.61% <ø> (?)
appsec-express 55.17% <ø> (?)
appsec-fastify 51.52% <ø> (?)
appsec-graphql 51.71% <ø> (-0.07%) ⬇️
appsec-kafka 44.26% <ø> (?)
appsec-ldapjs 43.91% <ø> (-0.08%) ⬇️
appsec-lodash 43.57% <ø> (-0.08%) ⬇️
appsec-macos 58.10% <ø> (-0.07%) ⬇️
appsec-mongodb-core 48.68% <ø> (-0.08%) ⬇️
appsec-mongoose 49.35% <ø> (-0.08%) ⬇️
appsec-mysql 50.78% <ø> (?)
appsec-node-serialize 43.09% <ø> (?)
appsec-passport 47.53% <ø> (-0.09%) ⬇️
appsec-postgres 50.50% <ø> (?)
appsec-sourcing 42.50% <ø> (-0.08%) ⬇️
appsec-template 43.26% <ø> (-0.08%) ⬇️
appsec-ubuntu 58.18% <ø> (?)
appsec-windows 57.94% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-bluebird 32.26% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-body-parser 40.40% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-child_process 37.70% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-cookie-parser 34.24% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-express 34.55% <ø> (?)
instrumentations-instrumentation-express-mongo-sanitize 34.37% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-express-session 40.03% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-fs 31.88% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-generic-pool 29.52% <ø> (ø)
instrumentations-instrumentation-http 39.67% <ø> (?)
instrumentations-instrumentation-knex 32.26% <ø> (?)
instrumentations-instrumentation-mongoose 33.39% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-multer 40.15% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-mysql2 38.16% <ø> (?)
instrumentations-instrumentation-passport 43.95% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-passport-http 43.62% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-passport-local 44.15% <ø> (?)
instrumentations-instrumentation-pg 37.59% <ø> (?)
instrumentations-instrumentation-promise 32.19% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-promise-js 32.20% <ø> (?)
instrumentations-instrumentation-q 32.24% <ø> (?)
instrumentations-instrumentation-url 32.16% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-when 32.21% <ø> (?)
llmobs-ai 42.14% <ø> (?)
llmobs-anthropic 40.18% <ø> (?)
llmobs-bedrock 39.14% <ø> (?)
llmobs-google-genai 39.67% <ø> (-0.09%) ⬇️
llmobs-langchain 39.93% <ø> (?)
llmobs-openai 43.85% <ø> (?)
llmobs-vertex-ai 39.93% <ø> (-0.09%) ⬇️
platform-core 31.47% <ø> (ø)
platform-esbuild 34.42% <ø> (ø)
platform-instrumentations-misc 48.41% <ø> (?)
platform-shimmer 37.56% <ø> (?)
platform-unit-guardrails 32.89% <ø> (?)
plugins-azure-durable-functions 25.74% <ø> (?)
plugins-azure-event-hubs 25.90% <ø> (ø)
plugins-azure-service-bus 25.26% <ø> (?)
plugins-bullmq 44.16% <ø> (?)
plugins-cassandra 37.65% <ø> (-0.23%) ⬇️
plugins-cookie 26.96% <ø> (?)
plugins-cookie-parser 26.75% <ø> (?)
plugins-crypto 26.73% <ø> (?)
plugins-dd-trace-api 38.21% <ø> (-0.10%) ⬇️
plugins-express-mongo-sanitize 26.89% <ø> (?)
plugins-express-session 26.70% <ø> (?)
plugins-fastify 42.12% <ø> (?)
plugins-fetch 38.21% <ø> (-0.09%) ⬇️
plugins-fs 38.48% <ø> (?)
plugins-generic-pool 25.94% <ø> (?)
plugins-google-cloud-pubsub 45.32% <ø> (-0.09%) ⬇️
plugins-grpc 40.79% <ø> (?)
plugins-handlebars 26.94% <ø> (?)
plugins-hapi 40.03% <ø> (?)
plugins-hono 40.29% <ø> (-0.10%) ⬇️
plugins-ioredis 38.29% <ø> (?)
plugins-knex 26.57% <ø> (?)
plugins-langgraph 38.34% <ø> (-0.10%) ⬇️
plugins-ldapjs 24.43% <ø> (?)
plugins-light-my-request 26.30% <ø> (?)
plugins-limitd-client 32.54% <ø> (?)
plugins-lodash 26.03% <ø> (?)
plugins-mariadb 39.34% <ø> (?)
plugins-memcached 38.01% <ø> (?)
plugins-microgateway-core 39.10% <ø> (?)
plugins-moleculer 40.38% <ø> (?)
plugins-mongodb 39.03% <ø> (?)
plugins-mongodb-core 38.86% <ø> (?)
plugins-mongoose 38.73% <ø> (?)
plugins-multer 26.70% <ø> (?)
plugins-mysql 39.02% <ø> (?)
plugins-mysql2 39.12% <ø> (?)
plugins-node-serialize 27.00% <ø> (?)
plugins-opensearch 37.47% <ø> (?)
plugins-passport-http 26.76% <ø> (?)
plugins-postgres 35.45% <ø> (?)
plugins-process 26.73% <ø> (?)
plugins-pug 26.96% <ø> (?)
plugins-redis 38.75% <ø> (?)
plugins-router 42.84% <ø> (?)
plugins-sequelize 25.55% <ø> (?)
plugins-test-and-upstream-amqp10 38.37% <ø> (+0.04%) ⬆️
plugins-test-and-upstream-amqplib 43.73% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-apollo 39.00% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-avsc 38.52% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-bunyan 33.80% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-connect 40.69% <ø> (?)
plugins-test-and-upstream-graphql 39.98% <ø> (?)
plugins-test-and-upstream-koa 40.28% <ø> (?)
plugins-test-and-upstream-protobufjs 38.75% <ø> (?)
plugins-test-and-upstream-rhea 43.91% <ø> (?)
plugins-undici 38.98% <ø> (?)
plugins-url 26.73% <ø> (?)
plugins-valkey 37.96% <ø> (?)
plugins-vm 26.73% <ø> (?)
plugins-winston 33.99% <ø> (?)
plugins-ws 41.74% <ø> (?)
profiling-macos 39.77% <ø> (-0.10%) ⬇️
profiling-ubuntu 39.89% <ø> (?)
profiling-windows 41.47% <ø> (-0.10%) ⬇️
serverless-azure-functions-client 25.62% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Mar 17, 2026

Benchmarks

Benchmark execution time: 2026-03-17 13:56:55

Comparing candidate commit a526c94 in PR branch fix-npm-prepare-node-env with baseline commit 6dac2bd in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 232 metrics, 28 unstable metrics.

@rochdev rochdev force-pushed the fix-npm-prepare-node-env branch from 6983fa3 to a526c94 Compare March 17, 2026 13:44
@rochdev rochdev marked this pull request as ready for review March 17, 2026 14:47
@rochdev rochdev requested a review from a team as a code owner March 17, 2026 14:47
@BridgeAR BridgeAR merged commit c0701db into master Mar 17, 2026
787 of 788 checks passed
@BridgeAR BridgeAR deleted the fix-npm-prepare-node-env branch March 17, 2026 19:22
@dd-octo-sts dd-octo-sts bot mentioned this pull request Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants