Skip to content

[test optimization] Add missing features to cucumber parallel mode #7787

Merged
juan-fernandez merged 4 commits intomasterfrom
juan-fernandez/cucumber-parallel-mode-fixes
Mar 17, 2026
Merged

[test optimization] Add missing features to cucumber parallel mode #7787
juan-fernandez merged 4 commits intomasterfrom
juan-fernandez/cucumber-parallel-mode-fixes

Conversation

@juan-fernandez
Copy link
Copy Markdown
Collaborator

What does this PR do?

Enables ITR suite skipping and test management (disable, quarantine, attempt-to-fix) in Cucumber's parallel mode.

Motivation

These features were either gated off by capability checks or missing config passthrough to workers, even though the underlying code already supported them.

Additional Notes

  • ITR suite skipping already worked — the main process filters pickles before dispatching to workers. Only the capability gate (UNSUPPORTED_TIA_FRAMEWORKS_PARALLEL_MODE) was preventing activation. Removed 'cucumber' from that set.
  • Test management (disable, quarantine, attempt-to-fix) required passing testManagementTests, testManagementAttemptToFixRetries, and isTestManagementTestsEnabled to workers via worldParameters in the startWorker hook, and reading them in the worker initialize hook.
  • Updated the capabilities test to reflect that TIA is now supported in parallel mode.
  • Added integration tests for disable and quarantine in parallel mode with separate worker processes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 16, 2026

Overall package size

Self size: 4.98 MB
Deduped: 5.82 MB
No deduping: 5.82 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.0 | 81.15 kB | 815.98 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 16, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.30%. Comparing base (7754521) to head (4749602).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...ackages/datadog-instrumentations/src/mocha/main.js 0.00% 2 Missing ⚠️
packages/dd-trace/src/plugins/ci_plugin.js 0.00% 2 Missing ⚠️
packages/dd-trace/src/plugins/util/test.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7787      +/-   ##
==========================================
- Coverage   80.30%   80.30%   -0.01%     
==========================================
  Files         743      743              
  Lines       32318    32317       -1     
==========================================
- Hits        25954    25953       -1     
  Misses       6364     6364              
Flag Coverage Δ
aiguard-macos 39.08% <ø> (-0.10%) ⬇️
aiguard-ubuntu 39.20% <ø> (-0.10%) ⬇️
aiguard-windows 38.93% <ø> (-0.10%) ⬇️
apm-capabilities-tracing-macos 48.95% <0.00%> (-0.01%) ⬇️
apm-capabilities-tracing-ubuntu 48.98% <0.00%> (-0.01%) ⬇️
apm-capabilities-tracing-windows 48.72% <0.00%> (+0.05%) ⬆️
apm-integrations-child-process 38.38% <ø> (-0.10%) ⬇️
apm-integrations-couchbase-18 37.33% <ø> (-0.07%) ⬇️
apm-integrations-couchbase-eol 37.77% <ø> (-0.10%) ⬇️
apm-integrations-oracledb 37.61% <ø> (-0.10%) ⬇️
appsec-express 55.18% <ø> (-0.09%) ⬇️
appsec-fastify 51.52% <ø> (-0.07%) ⬇️
appsec-graphql 51.72% <ø> (-0.07%) ⬇️
appsec-kafka 44.25% <ø> (-0.08%) ⬇️
appsec-ldapjs 43.91% <ø> (-0.08%) ⬇️
appsec-lodash 43.57% <ø> (-0.08%) ⬇️
appsec-macos 58.11% <0.00%> (-0.07%) ⬇️
appsec-mongodb-core 48.69% <ø> (-0.08%) ⬇️
appsec-mongoose 49.35% <ø> (-0.08%) ⬇️
appsec-mysql 50.88% <ø> (+0.03%) ⬆️
appsec-node-serialize 43.09% <ø> (-0.08%) ⬇️
appsec-passport 47.53% <ø> (-0.09%) ⬇️
appsec-postgres 50.51% <ø> (-0.07%) ⬇️
appsec-sourcing 42.50% <ø> (-0.08%) ⬇️
appsec-template 43.26% <ø> (-0.08%) ⬇️
appsec-ubuntu 58.19% <0.00%> (-0.07%) ⬇️
appsec-windows 57.95% <0.00%> (-0.07%) ⬇️
instrumentations-instrumentation-bluebird 32.26% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-body-parser 40.40% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-child_process 37.70% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-cookie-parser 34.24% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-express 34.55% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-express-mongo-sanitize 34.37% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-express-session 40.04% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-fs 31.88% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-generic-pool 29.51% <0.00%> (-0.02%) ⬇️
instrumentations-instrumentation-http 39.67% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-knex 32.26% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-mongoose 33.39% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-multer 40.15% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-mysql2 38.16% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-passport 43.96% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-passport-http 43.62% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-passport-local 44.16% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-pg 37.60% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-promise 32.19% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-promise-js 32.20% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-q 32.24% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-url 32.16% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-when 32.21% <ø> (-0.10%) ⬇️
llmobs-ai 42.14% <ø> (-0.09%) ⬇️
llmobs-anthropic 40.18% <ø> (-0.09%) ⬇️
llmobs-bedrock 39.14% <ø> (-0.08%) ⬇️
llmobs-google-genai 39.68% <ø> (-0.09%) ⬇️
llmobs-langchain 39.91% <ø> (-0.08%) ⬇️
llmobs-openai 43.86% <ø> (-0.09%) ⬇️
llmobs-vertex-ai 39.93% <ø> (-0.09%) ⬇️
platform-core 31.47% <ø> (ø)
platform-esbuild 34.42% <ø> (ø)
platform-instrumentations-misc 48.35% <ø> (ø)
platform-shimmer 37.56% <ø> (ø)
platform-unit-guardrails 32.89% <ø> (ø)
plugins-azure-durable-functions 25.62% <ø> (ø)
plugins-azure-event-hubs 25.79% <ø> (ø)
plugins-azure-service-bus 25.15% <ø> (ø)
plugins-bullmq 44.16% <ø> (-0.10%) ⬇️
plugins-cassandra 37.65% <ø> (-0.23%) ⬇️
plugins-cookie 26.84% <ø> (ø)
plugins-cookie-parser 26.63% <ø> (ø)
plugins-crypto 26.73% <ø> (ø)
plugins-dd-trace-api 38.21% <ø> (-0.10%) ⬇️
plugins-express-mongo-sanitize 26.78% <ø> (ø)
plugins-express-session 26.59% <ø> (ø)
plugins-fastify 42.12% <ø> (-0.09%) ⬇️
plugins-fetch 38.21% <ø> (-0.09%) ⬇️
plugins-fs 38.48% <ø> (-0.10%) ⬇️
plugins-generic-pool 25.83% <ø> (ø)
plugins-google-cloud-pubsub 45.32% <ø> (-0.09%) ⬇️
plugins-grpc 40.79% <ø> (-0.09%) ⬇️
plugins-handlebars 26.82% <ø> (ø)
plugins-hapi 40.03% <ø> (-0.10%) ⬇️
plugins-hono 40.29% <ø> (-0.10%) ⬇️
plugins-ioredis 38.29% <ø> (-0.10%) ⬇️
plugins-knex 26.46% <ø> (ø)
plugins-ldapjs 24.32% <ø> (ø)
plugins-light-my-request 26.19% <ø> (ø)
plugins-limitd-client 32.54% <ø> (-0.10%) ⬇️
plugins-lodash 25.92% <ø> (ø)
plugins-mariadb 39.34% <ø> (-0.10%) ⬇️
plugins-memcached 38.01% <ø> (-0.10%) ⬇️
plugins-microgateway-core 39.10% <ø> (-0.10%) ⬇️
plugins-moleculer 40.39% <ø> (-0.09%) ⬇️
plugins-mongodb 39.03% <ø> (-0.10%) ⬇️
plugins-mongodb-core 38.86% <ø> (-0.10%) ⬇️
plugins-mongoose 38.73% <ø> (-0.10%) ⬇️
plugins-multer 26.59% <ø> (ø)
plugins-mysql 39.02% <ø> (-0.25%) ⬇️
plugins-mysql2 39.12% <ø> (-0.10%) ⬇️
plugins-node-serialize 26.89% <ø> (ø)
plugins-opensearch 37.61% <ø> (+0.04%) ⬆️
plugins-passport-http 26.64% <ø> (ø)
plugins-postgres 35.46% <0.00%> (-0.09%) ⬇️
plugins-process 26.73% <ø> (ø)
plugins-pug 26.84% <ø> (ø)
plugins-redis 38.75% <ø> (-0.10%) ⬇️
plugins-router 42.98% <ø> (-0.10%) ⬇️
plugins-sequelize 25.43% <ø> (ø)
plugins-test-and-upstream-amqp10 38.37% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-amqplib 43.74% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-apollo 39.00% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-avsc 38.52% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-bunyan 33.80% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-connect 40.69% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-graphql 39.98% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-koa 40.28% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-protobufjs 38.75% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-rhea 43.92% <ø> (-0.10%) ⬇️
plugins-undici 38.98% <ø> (-0.09%) ⬇️
plugins-url 26.73% <ø> (ø)
plugins-valkey 37.96% <ø> (-0.10%) ⬇️
plugins-vm 26.73% <ø> (ø)
plugins-winston 33.99% <ø> (-0.24%) ⬇️
plugins-ws 41.74% <ø> (-0.10%) ⬇️
profiling-macos 39.77% <ø> (-0.10%) ⬇️
profiling-ubuntu 39.89% <ø> (-0.10%) ⬇️
profiling-windows 41.08% <ø> (-0.10%) ⬇️
serverless-azure-functions-client 25.50% <ø> (ø)
serverless-azure-functions-eventhubs 25.50% <ø> (ø)
serverless-azure-functions-servicebus 25.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Mar 16, 2026

Benchmarks

Benchmark execution time: 2026-03-16 17:34:35

Comparing candidate commit 4749602 in PR branch juan-fernandez/cucumber-parallel-mode-fixes with baseline commit 7754521 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 232 metrics, 28 unstable metrics.

Suite skipping already works in parallel mode — the main process filters
pickles before dispatching to workers. Only the capability gate was
preventing it from being activated. Remove 'cucumber' from
UNSUPPORTED_TIA_FRAMEWORKS_PARALLEL_MODE.

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
@juan-fernandez juan-fernandez force-pushed the juan-fernandez/cucumber-parallel-mode-fixes branch from aafa0f5 to 837d8af Compare March 16, 2026 13:06
@datadog-datadog-prod-us1

This comment has been minimized.

Pass testManagementTests and testManagementAttemptToFixRetries config
from the main process to parallel workers via worldParameters. Remove
'cucumber' from UNSUPPORTED_TIA_FRAMEWORKS_PARALLEL_MODE since ITR
suite skipping already worked (pickles filtered in the main process).

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
@juan-fernandez juan-fernandez force-pushed the juan-fernandez/cucumber-parallel-mode-fixes branch from 837d8af to 18a3c48 Compare March 16, 2026 13:39
@juan-fernandez juan-fernandez marked this pull request as ready for review March 16, 2026 13:50
@juan-fernandez juan-fernandez requested a review from a team as a code owner March 16, 2026 13:50
gnufede
gnufede previously approved these changes Mar 16, 2026
@juan-fernandez juan-fernandez requested a review from gnufede March 17, 2026 08:44
@juan-fernandez juan-fernandez merged commit 804902b into master Mar 17, 2026
790 checks passed
@juan-fernandez juan-fernandez deleted the juan-fernandez/cucumber-parallel-mode-fixes branch March 17, 2026 09:00
@dd-octo-sts dd-octo-sts bot mentioned this pull request Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants