[test optimization] Fix jest test assertion#7774
Merged
Conversation
Resolves the TODO at jest.spec.js:2933 — verify that when a new test retried by Early Flake Detection fails some attempts, the process exit code remains 0. Also converts the test from done-callback to async/await style. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Contributor
Overall package sizeSelf size: 4.96 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.0 | 81.15 kB | 815.98 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7774 +/- ##
=======================================
Coverage 80.43% 80.43%
=======================================
Files 741 741
Lines 32173 32173
=======================================
Hits 25877 25877
Misses 6296 6296 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2026-03-13 13:05:36 Comparing candidate commit 0b27582 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 228 metrics, 32 unstable metrics. |
juan-fernandez
changed the title
jest test sessionjest test assertion
anmarchenko
approved these changes
Mar 13, 2026
BridgeAR
approved these changes
Mar 13, 2026
dd-octo-sts bot
pushed a commit
that referenced
this pull request
Mar 14, 2026
Resolves the TODO at jest.spec.js:2933 — verify that when a new test retried by Early Flake Detection fails some attempts, the process exit code remains 0. Also converts the test from done-callback to async/await style. Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]>
Merged
CarlesDD
pushed a commit
that referenced
this pull request
Mar 16, 2026
Resolves the TODO at jest.spec.js:2933 — verify that when a new test retried by Early Flake Detection fails some attempts, the process exit code remains 0. Also converts the test from done-callback to async/await style. Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add exit code assertion which is already working
Motivation
Remove TODO