[test optimization] Fix TIA in parallel mocha #7773
Merged
juan-fernandez merged 3 commits intomasterfrom Mar 16, 2026
Merged
Conversation
Contributor
Overall package sizeSelf size: 4.98 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.0 | 81.15 kB | 815.98 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BenchmarksBenchmark execution time: 2026-03-16 12:42:58 Comparing candidate commit 5ace8b3 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 228 metrics, 32 unstable metrics. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7773 +/- ##
==========================================
- Coverage 80.34% 80.30% -0.05%
==========================================
Files 743 743
Lines 32296 32312 +16
==========================================
- Hits 25948 25947 -1
- Misses 6348 6365 +17 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
juan-fernandez
force-pushed
the
juan-fernandez/mocha-parallel-atr-and-atf
branch
from
6ad2e8a to
7d0fe01
Compare
juan-fernandez
force-pushed
the
juan-fernandez/mocha-parallel-itr-suite-skipping
branch
from
95d02d7 to
d723325
Compare
juan-fernandez
force-pushed
the
juan-fernandez/mocha-parallel-itr-suite-skipping
branch
from
d723325 to
449748c
Compare
Base automatically changed from
juan-fernandez/mocha-parallel-atr-and-atf
to
master
March 16, 2026 12:29
Filter files in ParallelBufferedRunner.run before dispatching to workers, instead of mutating runner.suite.suites (which is empty in parallel mode). Populate skippedSuites so the itr:skipped-suites channel emits proper skip spans for filtered files. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Now that ITR suite skipping works in parallel mode, remove the capability gate so the backend knows Mocha supports TIA in parallel. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
All capabilities are now identical between serial and parallel mode, so remove the isParallel branching from the capabilities assertions. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
juan-fernandez
force-pushed
the
juan-fernandez/mocha-parallel-itr-suite-skipping
branch
from
449748c to
5ace8b3
Compare
gnufede
approved these changes
Mar 16, 2026
juan-fernandez
deleted the
juan-fernandez/mocha-parallel-itr-suite-skipping
branch
Merged
juan-fernandez
added a commit
that referenced
this pull request
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enables ITR suite skipping in Mocha's parallel mode by filtering the file list before dispatching to workers.
Motivation
Suite skipping was the last feature gated off for parallel mode. The remote config was already available before workers start (via
getExecutionConfigurationin theParallelBufferedRunner.runhook), but the serial-mode skipping mechanism — mutatingrunner.suite.suites— doesn't apply in parallel mode because suites aren't loaded in the main process.Additional Notes
filesarray before callingrun.apply, rather than removing loaded suites fromrunner.suite.suites.skippedSuitesis populated beforerun.applyso theitr:skipped-suiteschannel emits proper skip spans for filtered files on thestartevent.unskippableSuitesis populated fromfilesbefore config is fetched, matching the serial mode pattern.!isParallel &&gate onisSuitesSkippingEnabledand the!isParallelguard onitrSkippedSuitesCh.publish.