Fix `DD_CIVISIBILITY_AGENTLESS_ENABLED` configuration by juan-fernandez · Pull Request #7743 · DataDog/dd-trace-js

juan-fernandez · 2026-03-11T08:43:46Z

What does this PR do?

If DD_CIVISIBILITY_AGENTLESS_ENABLED is set to true, the library should communicate using the agentless protocol, regardless of whether apm.socket is defined in the machine.

Motivation

Fixes #7722

codecov · 2026-03-11T08:44:24Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.39%. Comparing base (f9c9c98) to head (a90fa92).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #7743   +/-   ##
=======================================
  Coverage   80.39%   80.39%           
=======================================
  Files         741      741           
  Lines       32087    32087           
=======================================
  Hits        25796    25796           
  Misses       6291     6291

Flag	Coverage Δ
aiguard-macos	`38.88% <ø> (-0.10%)`	⬇️
aiguard-ubuntu	`38.99% <ø> (-0.10%)`	⬇️
aiguard-windows	`38.72% <ø> (-0.10%)`	⬇️
apm-capabilities-tracing-macos	`48.90% <ø> (ø)`
apm-capabilities-tracing-ubuntu	`48.94% <ø> (ø)`
apm-capabilities-tracing-windows	`48.67% <ø> (ø)`
apm-integrations-child-process	`38.44% <ø> (-0.10%)`	⬇️
apm-integrations-couchbase-18	`37.35% <ø> (-0.10%)`	⬇️
apm-integrations-couchbase-eol	`37.82% <ø> (+0.04%)`	⬆️
apm-integrations-oracledb	`37.66% <ø> (-0.10%)`	⬇️
appsec-express	`55.13% <ø> (-0.08%)`	⬇️
appsec-fastify	`51.49% <ø> (-0.07%)`	⬇️
appsec-graphql	`51.67% <ø> (-0.08%)`	⬇️
appsec-kafka	`44.20% <ø> (-0.16%)`	⬇️
appsec-ldapjs	`43.90% <ø> (-0.08%)`	⬇️
appsec-lodash	`43.56% <ø> (-0.08%)`	⬇️
appsec-macos	`58.16% <ø> (-0.07%)`	⬇️
appsec-mongodb-core	`48.56% <ø> (-0.19%)`	⬇️
appsec-mongoose	`49.34% <ø> (-0.08%)`	⬇️
appsec-mysql	`50.73% <ø> (-0.07%)`	⬇️
appsec-node-serialize	`43.08% <ø> (-0.08%)`	⬇️
appsec-passport	`47.47% <ø> (-0.09%)`	⬇️
appsec-postgres	`50.49% <ø> (-0.07%)`	⬇️
appsec-sourcing	`42.48% <ø> (-0.08%)`	⬇️
appsec-template	`43.24% <ø> (-0.08%)`	⬇️
appsec-ubuntu	`58.24% <ø> (-0.07%)`	⬇️
appsec-windows	`58.00% <ø> (-0.09%)`	⬇️
instrumentations-instrumentation-bluebird	`32.30% <ø> (-0.10%)`	⬇️
instrumentations-instrumentation-body-parser	`40.38% <ø> (-0.09%)`	⬇️
instrumentations-instrumentation-child_process	`37.75% <ø> (-0.10%)`	⬇️
instrumentations-instrumentation-cookie-parser	`34.28% <ø> (-0.09%)`	⬇️
instrumentations-instrumentation-express	`34.60% <ø> (-0.09%)`	⬇️
instrumentations-instrumentation-express-mongo-sanitize	`34.41% <ø> (-0.09%)`	⬇️
instrumentations-instrumentation-express-session	`40.01% <ø> (-0.09%)`	⬇️
instrumentations-instrumentation-fs	`31.92% <ø> (-0.10%)`	⬇️
instrumentations-instrumentation-generic-pool	`29.89% <ø> (ø)`
instrumentations-instrumentation-http	`39.73% <ø> (-0.10%)`	⬇️
instrumentations-instrumentation-knex	`32.30% <ø> (-0.10%)`	⬇️
instrumentations-instrumentation-mongoose	`33.43% <ø> (-0.10%)`	⬇️
instrumentations-instrumentation-multer	`40.13% <ø> (-0.09%)`	⬇️
instrumentations-instrumentation-mysql2	`38.21% <ø> (-0.10%)`	⬇️
instrumentations-instrumentation-passport	`43.88% <ø> (-0.09%)`	⬇️
instrumentations-instrumentation-passport-http	`43.55% <ø> (-0.09%)`	⬇️
instrumentations-instrumentation-passport-local	`44.09% <ø> (-0.09%)`	⬇️
instrumentations-instrumentation-pg	`37.65% <ø> (-0.10%)`	⬇️
instrumentations-instrumentation-promise	`32.23% <ø> (-0.10%)`	⬇️
instrumentations-instrumentation-promise-js	`32.24% <ø> (-0.10%)`	⬇️
instrumentations-instrumentation-q	`32.28% <ø> (-0.10%)`	⬇️
instrumentations-instrumentation-url	`32.20% <ø> (-0.10%)`	⬇️
instrumentations-instrumentation-when	`32.25% <ø> (-0.10%)`	⬇️
llmobs-ai	`42.20% <ø> (-0.09%)`	⬇️
llmobs-anthropic	`40.18% <ø> (-0.09%)`	⬇️
llmobs-bedrock	`39.17% <ø> (-0.08%)`	⬇️
llmobs-google-genai	`39.73% <ø> (-0.09%)`	⬇️
llmobs-langchain	`40.07% <ø> (+0.03%)`	⬆️
llmobs-openai	`43.91% <ø> (-0.09%)`	⬇️
llmobs-vertex-ai	`39.98% <ø> (-0.09%)`	⬇️
platform-core	`31.53% <ø> (ø)`
platform-esbuild	`34.48% <ø> (ø)`
platform-instrumentations-misc	`48.40% <ø> (ø)`
platform-shimmer	`37.63% <ø> (ø)`
platform-unit-guardrails	`32.95% <ø> (ø)`
plugins-azure-event-hubs	`25.83% <ø> (ø)`
plugins-azure-service-bus	`25.19% <ø> (ø)`
plugins-bullmq	`44.07% <ø> (-0.20%)`	⬇️
plugins-cassandra	`37.70% <ø> (-0.10%)`	⬇️
plugins-cookie	`26.89% <ø> (ø)`
plugins-cookie-parser	`26.67% <ø> (ø)`
plugins-crypto	`26.79% <ø> (ø)`
plugins-dd-trace-api	`38.27% <ø> (-0.10%)`	⬇️
plugins-express-mongo-sanitize	`26.82% <ø> (ø)`
plugins-express-session	`26.63% <ø> (ø)`
plugins-fastify	`42.09% <ø> (-0.09%)`	⬇️
plugins-fetch	`38.26% <ø> (-0.09%)`	⬇️
plugins-fs	`38.54% <ø> (-0.10%)`	⬇️
plugins-generic-pool	`25.87% <ø> (ø)`
plugins-google-cloud-pubsub	`45.30% <ø> (-0.09%)`	⬇️
plugins-grpc	`40.81% <ø> (-0.09%)`	⬇️
plugins-handlebars	`26.86% <ø> (ø)`
plugins-hapi	`40.01% <ø> (-0.10%)`	⬇️
plugins-hono	`40.27% <ø> (-0.10%)`	⬇️
plugins-ioredis	`38.35% <ø> (-0.10%)`	⬇️
plugins-knex	`26.50% <ø> (ø)`
plugins-ldapjs	`24.36% <ø> (ø)`
plugins-light-my-request	`26.23% <ø> (ø)`
plugins-limitd-client	`32.58% <ø> (-0.10%)`	⬇️
plugins-lodash	`25.96% <ø> (ø)`
plugins-mariadb	`39.40% <ø> (-0.10%)`	⬇️
plugins-memcached	`38.07% <ø> (-0.10%)`	⬇️
plugins-microgateway-core	`39.06% <ø> (-0.10%)`	⬇️
plugins-moleculer	`40.41% <ø> (-0.09%)`	⬇️
plugins-mongodb	`39.09% <ø> (-0.10%)`	⬇️
plugins-mongodb-core	`38.92% <ø> (-0.10%)`	⬇️
plugins-mongoose	`38.78% <ø> (-0.10%)`	⬇️
plugins-multer	`26.63% <ø> (ø)`
plugins-mysql	`39.08% <ø> (-0.10%)`	⬇️
plugins-mysql2	`39.18% <ø> (-0.10%)`	⬇️
plugins-node-serialize	`26.93% <ø> (ø)`
plugins-opensearch	`37.53% <ø> (-0.10%)`	⬇️
plugins-passport-http	`26.68% <ø> (ø)`
plugins-postgres	`35.65% <ø> (-0.09%)`	⬇️
plugins-process	`26.79% <ø> (ø)`
plugins-pug	`26.89% <ø> (ø)`
plugins-redis	`38.81% <ø> (-0.10%)`	⬇️
plugins-router	`42.95% <ø> (+0.04%)`	⬆️
plugins-sequelize	`25.47% <ø> (ø)`
plugins-test-and-upstream-amqp10	`38.43% <ø> (+0.04%)`	⬆️
plugins-test-and-upstream-amqplib	`43.76% <ø> (-0.10%)`	⬇️
plugins-test-and-upstream-apollo	`38.93% <ø> (-0.09%)`	⬇️
plugins-test-and-upstream-avsc	`38.60% <ø> (-0.10%)`	⬇️
plugins-test-and-upstream-bunyan	`33.84% <ø> (-0.10%)`	⬇️
plugins-test-and-upstream-connect	`40.66% <ø> (-0.10%)`	⬇️
plugins-test-and-upstream-graphql	`40.04% <ø> (-0.10%)`	⬇️
plugins-test-and-upstream-koa	`40.25% <ø> (-0.10%)`	⬇️
plugins-test-and-upstream-protobufjs	`38.82% <ø> (-0.10%)`	⬇️
plugins-test-and-upstream-rhea	`43.92% <ø> (-0.13%)`	⬇️
plugins-undici	`39.04% <ø> (-0.09%)`	⬇️
plugins-url	`26.79% <ø> (ø)`
plugins-valkey	`38.01% <ø> (-0.25%)`	⬇️
plugins-vm	`26.79% <ø> (ø)`
plugins-winston	`34.03% <ø> (-0.10%)`	⬇️
plugins-ws	`41.76% <ø> (-0.10%)`	⬇️
profiling-macos	`39.85% <ø> (-0.10%)`	⬇️
profiling-ubuntu	`39.97% <ø> (-0.10%)`	⬇️
profiling-windows	`41.16% <ø> (-0.49%)`	⬇️
serverless-azure-functions-client	`25.54% <ø> (ø)`
serverless-azure-functions-eventhubs	`25.54% <ø> (ø)`
serverless-azure-functions-servicebus	`25.54% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-03-11T08:44:29Z

Overall package size

Self size: 4.96 MB
Deduped: 5.8 MB
No deduping: 5.8 MB

Dependency sizes

| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.0 | 81.15 kB | 815.98 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

pr-commenter · 2026-03-11T13:32:33Z

Benchmarks

Benchmark execution time: 2026-03-11 13:32:30

Comparing candidate commit a90fa92 in PR branch juan-fernandez/fix-agentless-url-issue with baseline commit f9c9c98 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 231 metrics, 29 unstable metrics.

take agentless ci vis into account

06b298b

juan-fernandez added semver-patch test-optimization labels Mar 11, 2026

juan-fernandez mentioned this pull request Mar 11, 2026

[BUG]: DD_CIVISIBILITY_AGENTLESS_ENABLED does not work if /var/run/datadog/apm.socket exists #7722

Closed

juan-fernandez marked this pull request as ready for review March 11, 2026 08:44

juan-fernandez requested a review from a team as a code owner March 11, 2026 08:44

juan-fernandez requested review from ida613 and removed request for a team March 11, 2026 08:44

This comment has been minimized.

Sign in to view

juan-fernandez added 2 commits March 11, 2026 10:01

Merge branch 'master' into juan-fernandez/fix-agentless-url-issue

4d4b656

Merge branch 'master' into juan-fernandez/fix-agentless-url-issue

a90fa92

tlhunter approved these changes Mar 11, 2026

View reviewed changes

juan-fernandez merged commit 46ef22d into master Mar 12, 2026
789 of 790 checks passed

juan-fernandez deleted the juan-fernandez/fix-agentless-url-issue branch March 12, 2026 15:05

dd-octo-sts bot pushed a commit that referenced this pull request Mar 13, 2026

Fix DD_CIVISIBILITY_AGENTLESS_ENABLED configuration (#7743)

023e44c

dd-octo-sts bot mentioned this pull request Mar 13, 2026

v5.90.0 proposal #7742

Merged

CarlesDD pushed a commit that referenced this pull request Mar 16, 2026

Fix DD_CIVISIBILITY_AGENTLESS_ENABLED configuration (#7743)

dda208f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `DD_CIVISIBILITY_AGENTLESS_ENABLED` configuration#7743

Fix `DD_CIVISIBILITY_AGENTLESS_ENABLED` configuration#7743
juan-fernandez merged 3 commits intomasterfrom
juan-fernandez/fix-agentless-url-issue

juan-fernandez commented Mar 11, 2026

Uh oh!

codecov bot commented Mar 11, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 11, 2026 •

edited

Loading

Uh oh!

This comment has been minimized.

pr-commenter bot commented Mar 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

juan-fernandez commented Mar 11, 2026

What does this PR do?

Motivation

Uh oh!

codecov bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overall package size

Uh oh!

This comment has been minimized.

pr-commenter bot commented Mar 11, 2026

Benchmarks

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Mar 11, 2026 •

edited

Loading

github-actions bot commented Mar 11, 2026 •

edited

Loading