test(agent): fix dead double-send in handleTraceRequest#7725
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a dead code path in
handleTraceRequestin the test agent helper (packages/dd-trace/test/plugins/agent.js). When the test agent returned a non-200 status, the code attempted to callres.status(400).send()— butres.status(200).send()had already been called synchronously earlier in the same function, so the error response was silently dropped. This meant test agent errors were completely invisible.Replaces the dead send with a
console.warnso test agent errors are visible in CI logs. Also removes theres._closedguard which only existed to protect the now-removedres.status(400)call.Motivation
Discovered while investigating a flaky AI Guard Windows CI timeout. The silent error swallowing made it harder to reason about test agent behavior and could mask issues with CI test reporting.