feat(process tags): add tags to runtime metrics#7717
Conversation
tlhunter
added
semver-minor
AI Generated
Overall package sizeSelf size: 4.96 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.0 | 81.15 kB | 815.98 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
This comment has been minimized.
This comment has been minimized.
BenchmarksBenchmark execution time: 2026-03-12 21:25:42 Comparing candidate commit 5921780 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 231 metrics, 29 unstable metrics. |
tlhunter
force-pushed
the
tlhunter/process-tags-completion
branch
from
e14b440 to
53e65d9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7717 +/- ##
=======================================
Coverage 80.42% 80.43%
=======================================
Files 741 741
Lines 32168 32172 +4
=======================================
+ Hits 25872 25876 +4
Misses 6296 6296 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7afe8d0f86
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
tlhunter
force-pushed
the
tlhunter/process-tags-completion
branch
from
fb5b986 to
e4ffb9f
Compare
CarlesDD
left a comment
CarlesDD
left a comment
There was a problem hiding this comment.
LGTM from a language perspective
With process tags enabled by default, the propagation hash is now included in DSM pathway hash computation. Fix the spec to read the actual service/env from the DataStreamsProcessor and use the real propagationHash.getHash() so expected hashes match at runtime. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
… hash With process tags enabled by default, the propagation hash is now included in DSM pathway hash computation. Update rhea and sns DSM tests to dynamically compute expected hashes using propagationHash.getHash(). Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
The outer before() for agent.load('rhea') does not return its Promise,
so tracer.init() (which configures propagationHash) fires asynchronously.
Switching to beforeEach ensures propagationHash is configured before
computing expected hashes.
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
generateClientConfig() is shared between runtime metrics and the user-facing CustomMetrics (tracer.dogstatsd), so injecting process tags there would silently change cardinality for all user-emitted custom metrics. Move the injection into runtime_metrics.js where it only affects runtime metrics. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This reverts commit e65b7e4.
This reverts commit 38d13e7.
tlhunter
force-pushed
the
tlhunter/process-tags-completion
branch
from
e4ffb9f to
b7f4385
Compare
tlhunter
changed the title
This reverts commit 2332572.
wantsui
left a comment
wantsui
left a comment
There was a problem hiding this comment.
LGTM in terms of functionality.
gh-worker-ownership-write-b05516
bot
removed the request for review
from a team
3 participants
What does this PR do?
adds process tags to process discoveryenables process tags by defaultMotivation
Additional Notes