feat(eslint): add no-does-not-throw rule with auto-fix#7692
Merged
Conversation
Add an ESLint rule that bans `assert.doesNotThrow()` in test files and
auto-fixes violations by extracting the callback body directly.
Per CLAUDE.md: "Never use the doesNotThrow() assertion. Instead,
execute the method directly — if it throws, the test will fail."
Auto-fix handles:
- Arrow with expression body: assert.doesNotThrow(() => expr) → expr
- Arrow/function with block body: extracts statements
- Function reference: assert.doesNotThrow(fn) → fn()
- Destructured doesNotThrow from require('assert')
Fixes all ~50 existing violations across 25 test files, including
cascading cleanups (unused assert imports, let→const).
Co-Authored-By: Claude Opus 4.6 <[email protected]>
bm1549
added
semver-patch
AI Generated
Contributor
Overall package sizeSelf size: 4.93 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.0 | 81.15 kB | 815.98 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
bm1549
added a commit
that referenced
this pull request
Mar 5, 2026
Add ESLint rules and a CI check based on recurring PR review themes: 1. eslint-no-structured-clone: bans structuredClone() in production code (not available in all supported Node.js versions) 2. eslint-prefer-assert-object-contains: detects 3+ consecutive assert.strictEqual calls on the same object and suggests using assertObjectContains instead (currently off, 143 violations) 3. check-config-completeness: validates that all DD_/OTEL_ env vars in config/index.js are registered in supported-configurations.json Note: eslint-no-object-keys-length and eslint-no-does-not-throw have been split into separate PRs (#7691 and #7692) with auto-fix support. Co-Authored-By: Claude Opus 4.6 <[email protected]>
2 tasks
BenchmarksBenchmark execution time: 2026-03-06 17:39:09 Comparing candidate commit 530fc69 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 231 metrics, 29 unstable metrics. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7692 +/- ##
=======================================
Coverage 80.31% 80.32%
=======================================
Files 739 739
Lines 31946 31960 +14
=======================================
+ Hits 25657 25671 +14
Misses 6289 6289 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BridgeAR
requested changes
Mar 6, 2026
Member
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
I like this, while we can replace the custom rule with no-restricted-syntax:
{
selector: "CallExpression:matches([callee.name='doesNotThrow'], [callee.property.name='doesNotThrow'])",
message: 'Do not use `assert.doesNotThrow()`. Write the code without the wrapper and add a comment instead.',
}
BridgeAR
previously approved these changes
Mar 6, 2026
Member
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
LGTM, just left a independent of the change suggestion
packages/dd-trace/test/appsec/iast/taint-tracking/rewriter.spec.js
Outdated
Show resolved
Hide resolved
BridgeAR
previously approved these changes
Mar 6, 2026
BridgeAR
approved these changes
Mar 6, 2026
…icted-syntax Simplifies the implementation by using the built-in ESLint no-restricted-syntax rule with an AST selector, per BridgeAR's review suggestion. The ~50 existing violations were already fixed in the previous commits, so the custom auto-fix machinery is no longer needed. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
…c.js Co-authored-by: Ruben Bridgewater <[email protected]>
The no-restricted-syntax ESLint rule now statically enforces this convention, making the manual instruction in AGENTS.md redundant. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
bm1549
force-pushed
the
brian.marks/eslint-no-does-not-throw
branch
from
85bbc95 to
530fc69
Compare
|
✨ Fix all issues with BitsAI or with Cursor
|
dd-octo-sts bot
pushed a commit
that referenced
this pull request
Mar 7, 2026
Add an ESLint rule that bans `assert.doesNotThrow()` in test files. All entries where it was used are fixed and CLAUDE.md is adjusted, since the comment is not needed anymore. --------- Co-authored-by: Claude Opus 4.6 <[email protected]> Co-authored-by: Ruben Bridgewater <[email protected]>
Merged
juan-fernandez
pushed a commit
that referenced
this pull request
Mar 10, 2026
Add an ESLint rule that bans `assert.doesNotThrow()` in test files. All entries where it was used are fixed and CLAUDE.md is adjusted, since the comment is not needed anymore. --------- Co-authored-by: Claude Opus 4.6 <[email protected]> Co-authored-by: Ruben Bridgewater <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assert.doesNotThrow()in test files (per CLAUDE.md)no-restricted-syntaxrule with an AST selector — no custom rule neededassertimports, converted 2let→constFix patterns applied
assert.doesNotThrow(() => expr)exprassert.doesNotThrow(() => { stmt1; stmt2 })stmt1stmt2assert.doesNotThrow(fn)fn()assert.doesNotThrow(obj.method)obj.method()Test plan
npm run lintpasses clean🤖 Generated with Claude Code