Skip to content

chore: drop dead profile assert helper and fix telemetry typo#7686

Merged
szegedi merged 1 commit into
masterfrom
BridgeAR/2026-03-05-address-linter-issues
Jun 30, 2026
Merged

chore: drop dead profile assert helper and fix telemetry typo#7686
szegedi merged 1 commit into
masterfrom
BridgeAR/2026-03-05-address-linter-issues

Conversation

@BridgeAR

@BridgeAR BridgeAR commented Mar 5, 2026

Copy link
Copy Markdown
Member

Summary

  1. Remove packages/dd-trace/test/asserts/profile.js. It is the only file in test/asserts/, nothing requires it, and the only profile value-type assertion still in use is the standalone helper in the profiling agent exporter spec.
  2. Fix the amont -> amount typo in both telemetry heartbeat comments.

@pr-commenter

pr-commenter Bot commented Mar 5, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-06-30 00:24:20

Comparing candidate commit c244a94 in PR branch BridgeAR/2026-03-05-address-linter-issues with baseline commit 9af881e in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 0 performance regressions! Performance is the same for 2256 metrics, 30 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:appsec-appsec-enabled-20

  • unstable execution_time [-191.855ms; +181.719ms] or [-5.169%; +4.896%]

scenario:appsec-appsec-enabled-24

  • unstable execution_time [-178.652ms; +184.691ms] or [-6.781%; +7.010%]

scenario:appsec-appsec-enabled-26

  • unstable execution_time [-211.604ms; +197.364ms] or [-8.412%; +7.846%]

scenario:appsec-appsec-enabled-with-attacks-26

  • unstable execution_time [-161.487ms; +151.463ms] or [-5.626%; +5.277%]

scenario:appsec-control-20

  • unstable execution_time [-160310.959µs; +159594.059µs] or [-9.166%; +9.125%]

scenario:appsec-control-24

  • unstable execution_time [-105858.481µs; +105930.481µs] or [-8.722%; +8.728%]

scenario:appsec-control-26

  • unstable execution_time [-110673.915µs; +112657.848µs] or [-9.176%; +9.340%]

scenario:debugger-line-probe-with-snapshot-default-24

  • unstable cpu_user_time [-1568.020ms; +708.323ms] or [-19.525%; +8.820%]
  • unstable execution_time [-1582.003ms; +706.395ms] or [-18.170%; +8.113%]
  • unstable instructions [-13.5G instructions; +6.1G instructions] or [-20.744%; +9.341%]
  • unstable throughput [-257.744op/s; +483.837op/s] or [-6.809%; +12.783%]

scenario:debugger-line-probe-with-snapshot-default-26

  • unstable cpu_user_time [-2.496s; +4.985s] or [-22.468%; +44.877%]
  • unstable execution_time [-2.532s; +5.053s] or [-21.414%; +42.734%]
  • unstable instructions [-22.1G instructions; +44.0G instructions] or [-23.668%; +47.067%]
  • unstable max_rss_usage [-5.656MB; +13.746MB] or [-3.412%; +8.292%]
  • unstable throughput [-1128.685op/s; +575.289op/s] or [-38.783%; +19.768%]

scenario:debugger-line-probe-with-snapshot-minimal-24

  • unstable cpu_user_time [-1589.344ms; +560.631ms] or [-20.059%; +7.076%]
  • unstable execution_time [-1608.574ms; +558.836ms] or [-18.719%; +6.503%]
  • unstable instructions [-13.8G instructions; +4.5G instructions] or [-21.504%; +7.016%]
  • unstable throughput [-174.303op/s; +477.706op/s] or [-4.543%; +12.450%]

scenario:debugger-line-probe-without-snapshot-26

  • unstable cpu_user_time [-3657.307ms; +2405.595ms] or [-34.595%; +22.755%]
  • unstable execution_time [-3694.126ms; +2425.329ms] or [-32.754%; +21.504%]
  • unstable instructions [-33.1G instructions; +21.5G instructions] or [-37.308%; +24.274%]
  • unstable max_rss_usage [-11.167MB; +8.417MB] or [-6.845%; +5.160%]
  • unstable throughput [-539.055op/s; +808.754op/s] or [-17.933%; +26.906%]

scenario:dogstatsd-with-tags-20

  • unstable cpu_user_time [-198.131ms; +436.307ms] or [-3.964%; +8.730%]
  • unstable execution_time [-200.644ms; +437.597ms] or [-3.959%; +8.633%]
  • unstable throughput [-150936.667op/s; +68617.504op/s] or [-9.114%; +4.143%]

scenario:plugin-graphql-long-with-depth-and-collapse-off-20

  • unstable max_rss_usage [-42.003MB; +20.742MB] or [-11.064%; +5.463%]

scenario:test-optimization-large-suite-20

  • unstable max_rss_usage [-3.356MB; +6.788MB] or [-4.229%; +8.555%]

@github-actions

github-actions Bot commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 6.42 MB
Deduped: 7.48 MB
No deduping: 7.48 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.2.0 | 104.26 kB | 843.44 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Mar 5, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 88.03% (+0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c244a94 | Docs | Datadog PR Page | Give us feedback!

@codecov

codecov Bot commented Mar 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.72%. Comparing base (9af881e) to head (c244a94).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7686   +/-   ##
=======================================
  Coverage   93.72%   93.72%           
=======================================
  Files         891      891           
  Lines       51165    51165           
  Branches    11901    11901           
=======================================
+ Hits        47953    47954    +1     
+ Misses       3212     3211    -1     
Flag Coverage Δ
aiguard 34.88% <ø> (-0.08%) ⬇️
aiguard-integration 41.79% <ø> (ø)
apm-bucket-0 34.85% <ø> (-0.08%) ⬇️
apm-bucket-1 40.34% <ø> (-0.07%) ⬇️
apm-bucket-2 37.35% <ø> (-0.07%) ⬇️
apm-capabilities-tracing 48.75% <ø> (ø)
apm-integrations-aerospike 33.13% <ø> (-0.08%) ⬇️
apm-integrations-confluentinc-kafka-javascript 40.04% <ø> (-0.08%) ⬇️
apm-integrations-couchbase 33.41% <ø> (+0.08%) ⬆️
apm-integrations-http 42.04% <ø> (-0.07%) ⬇️
apm-integrations-kafkajs 40.27% <ø> (-0.08%) ⬇️
apm-integrations-next 29.47% <ø> (-0.11%) ⬇️
apm-integrations-prisma 35.04% <ø> (-0.07%) ⬇️
apm-integrations-tedious 33.90% <ø> (-0.08%) ⬇️
appsec 57.54% <ø> (-0.06%) ⬇️
appsec-express_fastify_graphql 53.77% <ø> (-0.03%) ⬇️
appsec-integration 36.25% <ø> (ø)
appsec-kafka_ldapjs_lodash 43.59% <ø> (-0.07%) ⬇️
appsec-mongodb-core_mongoose_mysql 48.83% <ø> (-0.06%) ⬇️
appsec-next 28.01% <ø> (-0.07%) ⬇️
appsec-node-serialize_passport_postgres 48.00% <ø> (-0.11%) ⬇️
appsec-sourcing_stripe_template 45.55% <ø> (-0.06%) ⬇️
debugger 44.42% <ø> (+0.04%) ⬆️
instrumentations-bucket-0 28.16% <ø> (-0.08%) ⬇️
instrumentations-bucket-1 37.41% <ø> (-0.07%) ⬇️
instrumentations-bucket-10 40.44% <ø> (-0.07%) ⬇️
instrumentations-bucket-11 27.96% <ø> (-0.08%) ⬇️
instrumentations-bucket-12 28.67% <ø> (-0.08%) ⬇️
instrumentations-bucket-13 27.79% <ø> (-0.08%) ⬇️
instrumentations-bucket-2 30.24% <ø> (-0.07%) ⬇️
instrumentations-bucket-3 35.91% <ø> (-0.07%) ⬇️
instrumentations-bucket-4 28.07% <ø> (-0.08%) ⬇️
instrumentations-bucket-5 36.28% <ø> (-0.07%) ⬇️
instrumentations-bucket-6 38.26% <ø> (-0.08%) ⬇️
instrumentations-bucket-7 36.02% <ø> (-0.07%) ⬇️
instrumentations-bucket-8 36.96% <ø> (-0.07%) ⬇️
instrumentations-bucket-9 39.53% <ø> (-0.07%) ⬇️
instrumentations-instrumentation-couchbase 46.54% <ø> (ø)
instrumentations-integration-esbuild 24.86% <ø> (ø)
llmobs-ai_anthropic_bedrock 39.54% <ø> (-0.07%) ⬇️
llmobs-google-genai_langchain_vertex-ai 36.98% <ø> (-0.06%) ⬇️
llmobs-openai 39.59% <ø> (-0.07%) ⬇️
llmobs-sdk 43.60% <ø> (-0.08%) ⬇️
master-coverage 93.72% <ø> (?)
openfeature 37.76% <ø> (ø)
openfeature-unit 50.39% <ø> (ø)
platform-core_esbuild_instrumentations-misc 23.36% <ø> (ø)
platform-integration 47.44% <ø> (+0.01%) ⬆️
platform-shimmer_unit-guardrails_webpack 18.89% <ø> (ø)
plugins-bucket-0 36.34% <ø> (-0.07%) ⬇️
plugins-bucket-1 39.61% <ø> (ø)
plugins-bucket-11 38.47% <ø> (-0.08%) ⬇️
plugins-bucket-17 39.16% <ø> (-0.07%) ⬇️
plugins-bucket-18 42.02% <ø> (-0.07%) ⬇️
plugins-bucket-19 39.57% <ø> (-0.07%) ⬇️
plugins-bucket-20 43.26% <ø> (-0.07%) ⬇️
plugins-bucket-4 37.72% <ø> (-0.07%) ⬇️
plugins-bullmq_cassandra_cookie 39.77% <ø> (-0.07%) ⬇️
plugins-cookie-parser_crypto_dd-trace-api 33.23% <ø> (-0.08%) ⬇️
plugins-fetch_fs_generic-pool 36.06% <ø> (-0.07%) ⬇️
plugins-google-cloud-pubsub_grpc_handlebars 43.11% <ø> (-0.07%) ⬇️
plugins-hapi_hono_ioredis 37.79% <ø> (-0.07%) ⬇️
plugins-jest_knex_langgraph 32.61% <ø> (-0.08%) ⬇️
plugins-ldapjs_light-my-request_limitd-client 27.85% <ø> (-0.08%) ⬇️
plugins-lodash_mariadb_memcached 35.18% <ø> (-0.08%) ⬇️
plugins-mongodb_mongodb-core_mongoose 36.32% <ø> (-0.07%) ⬇️
plugins-multer_mysql_mysql2 35.15% <ø> (-0.08%) ⬇️
plugins-nats_node-serialize_opensearch 37.16% <ø> (-0.08%) ⬇️
plugins-passport-http_pino_postgres 35.54% <ø> (-0.08%) ⬇️
plugins-process_pug_redis 34.05% <ø> (-0.29%) ⬇️
plugins-undici_url_valkey 35.89% <ø> (-0.07%) ⬇️
plugins-vm_winston_ws 37.56% <ø> (-0.08%) ⬇️
profiling 43.62% <ø> (-0.07%) ⬇️
serverless-aws-sdk-aws-sdk 33.30% <ø> (-0.07%) ⬇️
serverless-aws-sdk-bedrockruntime 32.17% <ø> (-0.07%) ⬇️
serverless-aws-sdk-client 37.21% <ø> (ø)
serverless-aws-sdk-dynamodb 34.18% <ø> (-0.05%) ⬇️
serverless-aws-sdk-eventbridge 27.25% <ø> (-0.07%) ⬇️
serverless-aws-sdk-kinesis 37.41% <ø> (-0.07%) ⬇️
serverless-aws-sdk-lambda 34.60% <ø> (-0.07%) ⬇️
serverless-aws-sdk-s3 32.60% <ø> (-0.07%) ⬇️
serverless-aws-sdk-serverless-peer-service 39.56% <ø> (+0.01%) ⬆️
serverless-aws-sdk-sns 38.38% <ø> (-0.07%) ⬇️
serverless-aws-sdk-sqs 38.01% <ø> (-0.07%) ⬇️
serverless-aws-sdk-stepfunctions 33.19% <ø> (-0.07%) ⬇️
serverless-aws-sdk-util 47.95% <ø> (ø)
serverless-bucket-0 39.47% <ø> (ø)
serverless-lambda 34.33% <ø> (-0.09%) ⬇️
test-optimization-cucumber 52.32% <ø> (+0.11%) ⬆️
test-optimization-cypress 49.43% <ø> (+0.06%) ⬆️
test-optimization-jest 55.36% <ø> (+0.04%) ⬆️
test-optimization-mocha 53.40% <ø> (+0.04%) ⬆️
test-optimization-playwright-playwright-atr 43.33% <ø> (+0.08%) ⬆️
test-optimization-playwright-playwright-efd 43.62% <ø> (+0.08%) ⬆️
test-optimization-playwright-playwright-final-status 43.74% <ø> (+0.08%) ⬆️
test-optimization-playwright-playwright-impacted-tests 43.16% <ø> (ø)
test-optimization-playwright-playwright-reporting 43.27% <ø> (+0.08%) ⬆️
test-optimization-playwright-playwright-test-management 44.73% <ø> (+0.02%) ⬆️
test-optimization-playwright-playwright-test-span 44.52% <ø> (+0.07%) ⬆️
test-optimization-selenium 45.29% <ø> (+0.06%) ⬆️
test-optimization-testopt 48.04% <ø> (+0.08%) ⬆️
test-optimization-vitest 50.64% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BridgeAR
BridgeAR force-pushed the BridgeAR/2026-03-05-address-linter-issues branch from 7afd0ed to c05c5ff Compare May 8, 2026 00:47
@BridgeAR
BridgeAR force-pushed the BridgeAR/2026-03-05-address-linter-issues branch from c05c5ff to 7600b9a Compare June 30, 2026 00:07
1. Remove test/asserts/profile.js. Nothing requires it; the only profile
   value-type assertion in use is the standalone helper in the profiling
   agent exporter spec.
2. Fix the "amont" -> "amount" typo in both telemetry heartbeat comments.
@BridgeAR
BridgeAR force-pushed the BridgeAR/2026-03-05-address-linter-issues branch from 7600b9a to c244a94 Compare June 30, 2026 00:11
@BridgeAR BridgeAR changed the title chore: remove dead code and add error cause where needed chore: drop dead profile assert helper and fix telemetry typo Jun 30, 2026
@BridgeAR
BridgeAR marked this pull request as ready for review June 30, 2026 00:12
@BridgeAR
BridgeAR requested a review from a team as a code owner June 30, 2026 00:12
@BridgeAR
BridgeAR requested review from khanayan123 and removed request for a team June 30, 2026 00:12
@szegedi
szegedi merged commit 15462b3 into master Jun 30, 2026
919 of 920 checks passed
@szegedi
szegedi deleted the BridgeAR/2026-03-05-address-linter-issues branch June 30, 2026 15:54
dd-octo-sts Bot pushed a commit that referenced this pull request Jul 1, 2026
1. Remove test/asserts/profile.js. Nothing requires it; the only profile
   value-type assertion in use is the standalone helper in the profiling
   agent exporter spec.
2. Fix the "amont" -> "amount" typo in both telemetry heartbeat comments.
This was referenced Jul 1, 2026
rochdev pushed a commit that referenced this pull request Jul 2, 2026
1. Remove test/asserts/profile.js. Nothing requires it; the only profile
   value-type assertion in use is the standalone helper in the profiling
   agent exporter spec.
2. Fix the "amont" -> "amount" typo in both telemetry heartbeat comments.
rochdev pushed a commit that referenced this pull request Jul 2, 2026
1. Remove test/asserts/profile.js. Nothing requires it; the only profile
   value-type assertion in use is the standalone helper in the profiling
   agent exporter spec.
2. Fix the "amont" -> "amount" typo in both telemetry heartbeat comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants