chore(ci): retry flaky instrumentation-http in platform workflow#7678
Merged
chore(ci): retry flaky instrumentation-http in platform workflow#7678
Conversation
Contributor
Overall package sizeSelf size: 4.91 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.6 | 81.92 kB | 816.75 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7678 +/- ##
=======================================
Coverage 80.31% 80.31%
=======================================
Files 739 739
Lines 31946 31946
=======================================
+ Hits 25657 25659 +2
+ Misses 6289 6287 -2 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add retries (nick-fields/retry, 3 attempts) around the http instrumentation test steps to work around a flaky bug in Node.js http code. Inline the job steps instead of the shared action so only this job is affected. TODO: revert to ./.github/actions/ instrumentations/test once fixed upstream.
watson
force-pushed
the
watson/fix-flake-http
branch
from
ad02f45 to
fa33bff
Compare
juan-fernandez
approved these changes
Mar 5, 2026
BridgeAR
approved these changes
Mar 5, 2026
dd-octo-sts bot
pushed a commit
that referenced
this pull request
Mar 5, 2026
Add retries (nick-fields/retry, 3 attempts) around the http instrumentation test steps to work around a flaky bug in Node.js http code. Inline the job steps instead of the shared action so only this job is affected. TODO: revert to ./.github/actions/ instrumentations/test once fixed upstream.
Merged
juan-fernandez
pushed a commit
that referenced
this pull request
Mar 5, 2026
Add retries (nick-fields/retry, 3 attempts) around the http instrumentation test steps to work around a flaky bug in Node.js http code. Inline the job steps instead of the shared action so only this job is affected. TODO: revert to ./.github/actions/ instrumentations/test once fixed upstream.
crysmags
pushed a commit
that referenced
this pull request
Mar 6, 2026
Add retries (nick-fields/retry, 3 attempts) around the http instrumentation test steps to work around a flaky bug in Node.js http code. Inline the job steps instead of the shared action so only this job is affected. TODO: revert to ./.github/actions/ instrumentations/test once fixed upstream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds retries (3 attempts) to the instrumentation-http job in the platform workflow. The job no longer uses the shared
./.github/actions/instrumentations/testaction; its steps are inlined in.github/workflows/platform.ymland eachyarn test:instrumentations:cirun is wrapped withnick-fields/retry.Motivation
The instrumentation-http test is flaky due to a bug in Node.js http code. Retrying up to 3 times reduces CI failures from this flake until the issue is fixed upstream.
Additional Notes
Revert this change (restore the single
uses: ./.github/actions/instrumentations/teststep for theinstrumentation-httpjob) once the upstream fix is available and the test is stable.