Remove obsolete ref_protected from STS trust policies#7676
Merged
Conversation
Contributor
Overall package sizeSelf size: 4.96 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.0 | 81.15 kB | 815.98 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7676 +/- ##
=======================================
Coverage 80.42% 80.42%
=======================================
Files 741 741
Lines 32182 32182
=======================================
Hits 25883 25883
Misses 6299 6299 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2026-03-13 19:33:42 Comparing candidate commit 7be09ec in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 230 metrics, 30 unstable metrics. |
BridgeAR
approved these changes
Mar 5, 2026
The `ref_protected` OIDC claim is now universally `true` in the DataDog org due to the org-level "incompatible file paths on windows" push ruleset, making it useless as a security discriminator. Ticket: https://datadoghq.atlassian.net/browse/SINT-4732 Co-Authored-By: Claude Opus 4.6 <[email protected]>
BridgeAR
force-pushed
the
remove-ref-protected-from-sts-policies
branch
from
a169211 to
e7ecc6c
Compare
juliendoutre
approved these changes
Mar 9, 2026
dd-octo-sts bot
pushed a commit
that referenced
this pull request
Mar 18, 2026
The `ref_protected` OIDC claim is now universally `true` in the DataDog org due to the org-level "incompatible file paths on windows" push ruleset, making it useless as a security discriminator. Ticket: https://datadoghq.atlassian.net/browse/SINT-4732
Merged
juan-fernandez
pushed a commit
that referenced
this pull request
Mar 18, 2026
The `ref_protected` OIDC claim is now universally `true` in the DataDog org due to the org-level "incompatible file paths on windows" push ruleset, making it useless as a security discriminator. Ticket: https://datadoghq.atlassian.net/browse/SINT-4732
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ref_protected: "true"from dd-octo-sts trust policy claim patternsThe
ref_protectedOIDC claim is now obsolete in the DataDog org:ref_protected: truein OIDC tokens, making it useless as a security signalgitlab.ddbuild.ioreportref_protected: truedue to org-levelpushAccessLevels: 40configSince the claim is universally
true, it provides no actual filtering — only a false sense of security. Removing it has zero functional impact on policy enforcement.All other constraints (subject, ref, job_workflow_ref, project_path, pipeline_source, etc.) remain unchanged and continue to provide the real security boundaries.
Ticket: https://datadoghq.atlassian.net/browse/SINT-4732
Test plan
🤖 Generated with Claude Code