fix(benchmark): handle non-JSON workflow polling responses#7662
fix(benchmark): handle non-JSON workflow polling responses#7662juan-fernandez merged 2 commits intomasterfrom
Conversation
Made-with: Cursor
Overall package sizeSelf size: 4.89 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.6 | 81.92 kB | 816.75 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BenchmarksBenchmark execution time: 2026-03-04 10:05:34 Comparing candidate commit 13c2632 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 226 metrics, 34 unstable metrics. |
watson
left a comment
watson
left a comment
There was a problem hiding this comment.
Just a small nit, otherwise looks good 👍
Co-authored-by: Thomas Watson <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7662 +/- ##
=======================================
Coverage 80.29% 80.29%
=======================================
Files 738 738
Lines 31897 31897
=======================================
Hits 25611 25611
Misses 6286 6286 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* fix(benchmark): handle non-JSON workflow polling responses Co-authored-by: Thomas Watson <[email protected]>
* fix(benchmark): handle non-JSON workflow polling responses Co-authored-by: Thomas Watson <[email protected]>
* fix(benchmark): handle non-JSON workflow polling responses Co-authored-by: Thomas Watson <[email protected]>
2 participants
What does this PR do?
Hardens benchmark workflow polling by validating API responses before JSON parsing and retrying on transient non-JSON/non-2xx responses.
Motivation
Fix flakiness in performance and correctness tests: (01, 02, 03)
CI sometimes receives HTML/error responses from GitHub Actions APIs while polling, which caused
JSON.parsecrashes.Additional Notes
Scope is limited to
benchmark/e2e-test-optimization/benchmark-run.js.