Skip to content

Revert "chore: vendor on npm prepare instead of committing to git (#7423)"#7638

Merged
watson merged 1 commit intomasterfrom
watson/revert
Mar 2, 2026
Merged

Revert "chore: vendor on npm prepare instead of committing to git (#7423)"#7638
watson merged 1 commit intomasterfrom
watson/revert

Conversation

@watson
Copy link
Copy Markdown
Collaborator

@watson watson commented Mar 2, 2026

What does this PR do?

Revert PR #7423

Motivation

It was blocking several people, for instance failing system tests builds: https://github.com/DataDog/system-tests/actions/runs/22501109173/job/65191588666?pr=6394

Additional Notes

A proper fix can be implemented async, but reverting for now to unblock everyone.

@watson watson requested review from a team as code owners March 2, 2026 10:19
@watson watson self-assigned this Mar 2, 2026
Copy link
Copy Markdown
Collaborator Author

watson commented Mar 2, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 2, 2026

Overall package size

Self size: 4.85 MB
Deduped: 5.69 MB
No deduping: 5.69 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.6 | 81.92 kB | 816.75 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.27%. Comparing base (2608ddb) to head (924c5aa).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7638      +/-   ##
==========================================
- Coverage   80.27%   80.27%   -0.01%     
==========================================
  Files         734      734              
  Lines       31644    31644              
==========================================
- Hits        25402    25401       -1     
- Misses       6242     6243       +1     
Flag Coverage Δ
aiguard-macos 38.94% <ø> (-0.10%) ⬇️
aiguard-ubuntu 39.06% <ø> (-0.10%) ⬇️
aiguard-windows 38.79% <ø> (-0.10%) ⬇️
apm-capabilities-tracing-macos 48.51% <ø> (ø)
apm-capabilities-tracing-ubuntu 48.54% <ø> (ø)
apm-capabilities-tracing-windows 48.28% <ø> (ø)
apm-integrations-child-process 38.52% <ø> (-0.10%) ⬇️
apm-integrations-couchbase-18 37.45% <ø> (-0.10%) ⬇️
apm-integrations-couchbase-eol 37.92% <ø> (-0.10%) ⬇️
apm-integrations-oracledb 37.75% <ø> (-0.10%) ⬇️
appsec-express 55.37% <ø> (-0.07%) ⬇️
appsec-fastify 51.69% <ø> (-0.07%) ⬇️
appsec-graphql 51.87% <ø> (-0.07%) ⬇️
appsec-kafka 44.41% <ø> (-0.03%) ⬇️
appsec-ldapjs 44.04% <ø> (-0.08%) ⬇️
appsec-lodash 43.70% <ø> (-0.08%) ⬇️
appsec-macos 58.38% <ø> (-0.07%) ⬇️
appsec-mongodb-core 48.86% <ø> (-0.08%) ⬇️
appsec-mongoose 49.53% <ø> (-0.09%) ⬇️
appsec-mysql 50.90% <ø> (-0.07%) ⬇️
appsec-node-serialize 43.21% <ø> (-0.08%) ⬇️
appsec-passport 47.67% <ø> (-0.09%) ⬇️
appsec-postgres 50.66% <ø> (-0.07%) ⬇️
appsec-sourcing 42.61% <ø> (-0.08%) ⬇️
appsec-template 43.38% <ø> (-0.08%) ⬇️
appsec-ubuntu 58.46% <ø> (-0.07%) ⬇️
appsec-windows 58.22% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-bluebird 32.31% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-body-parser 40.50% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-child_process 37.84% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-cookie-parser 34.31% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-express 34.65% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-express-mongo-sanitize 34.45% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-express-session 40.12% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-fs 31.92% <ø> (-0.11%) ⬇️
instrumentations-instrumentation-generic-pool 29.74% <ø> (ø)
instrumentations-instrumentation-http 39.85% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-knex 32.32% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-mongoose 33.46% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-multer 40.24% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-mysql2 38.31% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-passport 44.03% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-passport-http 43.70% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-passport-local 44.24% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-pg 37.74% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-promise 32.24% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-promise-js 32.25% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-q 32.29% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-url 32.21% <ø> (-0.11%) ⬇️
instrumentations-instrumentation-when 32.26% <ø> (-0.10%) ⬇️
llmobs-ai 41.97% <ø> (-0.10%) ⬇️
llmobs-anthropic 40.31% <ø> (-0.09%) ⬇️
llmobs-bedrock 39.26% <ø> (-0.09%) ⬇️
llmobs-google-genai 39.84% <ø> (-0.09%) ⬇️
llmobs-langchain 39.77% <ø> (-0.08%) ⬇️
llmobs-openai 44.15% <ø> (-0.09%) ⬇️
llmobs-vertex-ai 40.10% <ø> (-0.09%) ⬇️
platform-core 31.53% <ø> (ø)
platform-esbuild 34.48% <ø> (ø)
platform-instrumentations-misc 43.94% <ø> (ø)
platform-shimmer 37.63% <ø> (ø)
platform-unit-guardrails 32.95% <ø> (ø)
plugins-azure-event-hubs 25.71% <ø> (ø)
plugins-azure-service-bus 25.07% <ø> (ø)
plugins-bullmq 43.75% <ø> (-0.09%) ⬇️
plugins-cassandra 37.79% <ø> (-0.10%) ⬇️
plugins-cookie 26.77% <ø> (ø)
plugins-cookie-parser 26.56% <ø> (ø)
plugins-crypto 26.79% <ø> (ø)
plugins-dd-trace-api 38.38% <ø> (-0.10%) ⬇️
plugins-express-mongo-sanitize 26.70% <ø> (ø)
plugins-express-session 26.51% <ø> (ø)
plugins-fastify 42.24% <ø> (-0.09%) ⬇️
plugins-fetch 38.34% <ø> (-0.10%) ⬇️
plugins-fs 38.62% <ø> (-0.10%) ⬇️
plugins-generic-pool 25.75% <ø> (ø)
plugins-google-cloud-pubsub 45.38% <ø> (-0.09%) ⬇️
plugins-grpc 40.95% <ø> (-0.09%) ⬇️
plugins-handlebars 26.75% <ø> (ø)
plugins-hapi 40.13% <ø> (-0.10%) ⬇️
plugins-hono 40.39% <ø> (-0.10%) ⬇️
plugins-ioredis 38.43% <ø> (-0.10%) ⬇️
plugins-knex 26.39% <ø> (ø)
plugins-ldapjs 24.24% <ø> (ø)
plugins-light-my-request 26.12% <ø> (ø)
plugins-limitd-client 32.60% <ø> (-0.10%) ⬇️
plugins-lodash 25.84% <ø> (ø)
plugins-mariadb 39.49% <ø> (-0.15%) ⬇️
plugins-memcached 38.18% <ø> (-0.10%) ⬇️
plugins-microgateway-core 39.18% <ø> (-0.10%) ⬇️
plugins-moleculer 40.51% <ø> (-0.10%) ⬇️
plugins-mongodb 39.20% <ø> (-0.10%) ⬇️
plugins-mongodb-core 39.04% <ø> (-0.10%) ⬇️
plugins-mongoose 38.86% <ø> (-0.10%) ⬇️
plugins-multer 26.51% <ø> (ø)
plugins-mysql 39.17% <ø> (-0.10%) ⬇️
plugins-mysql2 39.27% <ø> (-0.10%) ⬇️
plugins-node-serialize 26.81% <ø> (ø)
plugins-opensearch 37.63% <ø> (-0.10%) ⬇️
plugins-passport-http 26.57% <ø> (ø)
plugins-postgres 35.73% <ø> (-0.15%) ⬇️
plugins-process 26.79% <ø> (ø)
plugins-pug 26.77% <ø> (ø)
plugins-redis 38.90% <ø> (-0.10%) ⬇️
plugins-router 42.97% <ø> (-0.10%) ⬇️
plugins-sequelize 25.35% <ø> (ø)
plugins-test-and-upstream-amqp10 38.50% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-amqplib 43.83% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-apollo 39.03% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-avsc 38.71% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-bunyan 33.88% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-connect 40.79% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-graphql 40.14% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-koa 40.38% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-protobufjs 38.94% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-rhea 44.03% <ø> (-0.13%) ⬇️
plugins-undici 39.12% <ø> (-0.09%) ⬇️
plugins-url 26.79% <ø> (ø)
plugins-valkey 38.06% <ø> (-0.13%) ⬇️
plugins-vm 26.79% <ø> (ø)
plugins-winston 34.08% <ø> (-0.10%) ⬇️
plugins-ws 41.89% <ø> (-0.10%) ⬇️
profiling-macos 39.84% <ø> (-0.10%) ⬇️
profiling-ubuntu 39.96% <ø> (-0.10%) ⬇️
profiling-windows 41.17% <ø> (-0.10%) ⬇️
serverless-azure-functions-client 25.43% <ø> (ø)
serverless-azure-functions-eventhubs 25.43% <ø> (ø)
serverless-azure-functions-servicebus 25.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@watson watson enabled auto-merge (squash) March 2, 2026 10:24
)"

This reverts commit 2608ddb.

System tests failed: DataDog/system-tests/actions/runs/22501109173/job/65191588666?pr=6394
@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Mar 2, 2026

Benchmarks

Benchmark execution time: 2026-03-02 10:59:13

Comparing candidate commit 924c5aa in PR branch watson/revert with baseline commit 2608ddb in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 232 metrics, 28 unstable metrics.

@watson watson merged commit d7bee55 into master Mar 2, 2026
789 of 790 checks passed
@watson watson deleted the watson/revert branch March 2, 2026 11:48
dd-octo-sts bot pushed a commit that referenced this pull request Mar 3, 2026
@dd-octo-sts dd-octo-sts bot mentioned this pull request Mar 3, 2026
juan-fernandez pushed a commit that referenced this pull request Mar 5, 2026
rochdev added a commit that referenced this pull request Mar 16, 2026
rochdev added a commit that referenced this pull request Mar 17, 2026
#7789)

* Revert "Revert "chore: vendor on npm prepare instead of committing to git (#7423)" (#7638)"
dd-octo-sts bot pushed a commit that referenced this pull request Mar 17, 2026
#7789)

* Revert "Revert "chore: vendor on npm prepare instead of committing to git (#7423)" (#7638)"
juan-fernandez pushed a commit that referenced this pull request Mar 18, 2026
#7789)

* Revert "Revert "chore: vendor on npm prepare instead of committing to git (#7423)" (#7638)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants