Conversation
Contributor
Overall package sizeSelf size: 4.84 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.6 | 81.92 kB | 816.75 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7617 +/- ##
==========================================
- Coverage 80.32% 80.24% -0.08%
==========================================
Files 734 733 -1
Lines 31602 31662 +60
==========================================
+ Hits 25383 25408 +25
- Misses 6219 6254 +35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
uurien
force-pushed
the
ugaitzflaky-ssrf
branch
from
32d612a to
7b38917
Compare
tlhunter
reviewed
Feb 25, 2026
BridgeAR
reviewed
Feb 27, 2026
CarlesDD
approved these changes
Feb 27, 2026
Merged
juan-fernandez
pushed a commit
that referenced
this pull request
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Tries to fix the flaky test happening in the rasp test file
ssrf.express.plugin.spec.js.There is no easy way to reproduce the failure, but I figured out that the reason why the web root span is not found is because the trace is not complete and it is not sent to the agent.
This could happen when timeout happens before the outgoing http request finishes. That is why I made some changes in the tested controller to be sure that the outgoing request span is closed as soon as possible, calling to
res.resume()and finishing the main request when the outgoing request has finished.Motivation
Reduce flaky tests
Additional Notes
50 success executions in the CI: https://github.com/DataDog/dd-trace-js/actions/runs/22406751414/job/64868757093?pr=7617