chore(test): Fixing iast overhead controller flaky tests#7607
chore(test): Fixing iast overhead controller flaky tests#7607
Conversation
Overall package sizeSelf size: 4.78 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.6 | 81.92 kB | 816.75 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7607 +/- ##
==========================================
- Coverage 80.30% 80.30% -0.01%
==========================================
Files 733 733
Lines 31561 31565 +4
==========================================
+ Hits 25345 25348 +3
- Misses 6216 6217 +1 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2026-02-25 09:15:41 Comparing candidate commit acd366e in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 225 metrics, 35 unstable metrics. |
This comment has been minimized.
This comment has been minimized.
uurien
force-pushed
the
ugaitz/fixing-overheadcontrollerflaky
branch
from
dd209e0 to
2595587
Compare
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
LGTM, just left two suggestions.
packages/dd-trace/test/appsec/iast/overhead-controller.integration.spec.js
Outdated
Show resolved
Hide resolved
packages/dd-trace/test/appsec/iast/overhead-controller.integration.spec.js
Outdated
Show resolved
Hide resolved
uurien
force-pushed
the
ugaitz/fixing-overheadcontrollerflaky
branch
from
e058432 to
acd366e
Compare
3 participants
What does this PR do?
Tries to fix flaky test in overhead controller.
Changes the test check to do subscription to the agent before the execution of the request, seems that there is a race condition when the traces are received before the subscription. Now should be fixed.
Motivation
Additional Notes
CI with +200 success executions: https://github.com/DataDog/dd-trace-js/actions/runs/22357293612?pr=7607 (two iteration of +100)