[MLOS-459] Support enriched evalmetric event submission#7503
Merged
[MLOS-459] Support enriched evalmetric event submission#7503
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
Overall package sizeSelf size: 4.61 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.6 | 81.92 kB | 813.08 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7503 +/- ##
==========================================
+ Coverage 80.13% 80.18% +0.04%
==========================================
Files 730 731 +1
Lines 31104 31212 +108
==========================================
+ Hits 24926 25026 +100
- Misses 6178 6186 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2026-02-13 15:48:25 Comparing candidate commit 27c9b5a in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 231 metrics, 29 unstable metrics. |
gsvigruha
changed the title
sabrenner
reviewed
Feb 12, 2026
Collaborator
sabrenner
left a comment
sabrenner
left a comment
There was a problem hiding this comment.
noting for transparency on the pr that we talked briefly offline that we might also have to include an update to use the v2 endpoint of the evaluation metrics api. this should not have an impact on the existing api here
…svigruha/eval-data-model-new-fields
sabrenner
reviewed
Feb 12, 2026
BridgeAR
reviewed
Feb 13, 2026
sabrenner
reviewed
Feb 13, 2026
Collaborator
sabrenner
left a comment
sabrenner
left a comment
There was a problem hiding this comment.
just a couple more js-specific comments! thanks for attaching manual tests in the pr description 🙇
packages/dd-trace/src/llmobs/sdk.js
Outdated
Comment on lines
+444
to
+452
| if (reasoning !== undefined) { | ||
| payload.reasoning = reasoning | ||
| } | ||
| if (metadata !== undefined) { | ||
| payload.metadata = metadata | ||
| } | ||
| if (assessment !== undefined) { | ||
| payload.assessment = assessment | ||
| } |
Collaborator
There was a problem hiding this comment.
these will allow null values through (in js, null !== undefined). we can do this instead
Suggested change
| if (reasoning !== undefined) { | |
| payload.reasoning = reasoning | |
| } | |
| if (metadata !== undefined) { | |
| payload.metadata = metadata | |
| } | |
| if (assessment !== undefined) { | |
| payload.assessment = assessment | |
| } | |
| if (reasoning != null) { | |
| payload.reasoning = reasoning | |
| } | |
| if (metadata != null) { | |
| payload.metadata = metadata | |
| } | |
| if (assessment != null) { | |
| payload.assessment = assessment | |
| } |
as null == undefined
Contributor
Author
There was a problem hiding this comment.
thanks! i can never wrap my head around TS null vs undefined and == vs ===
sabrenner
previously approved these changes
Feb 13, 2026
Collaborator
sabrenner
left a comment
sabrenner
left a comment
There was a problem hiding this comment.
looks great! unless the diff is bugged on my end it looks like we still have
assessment?: stringinstead of 'pass' | 'fail' in the index.d.ts but not a blocker
Contributor
Author
|
I added |
sabrenner
approved these changes
Feb 13, 2026
dd-octo-sts bot
pushed a commit
that referenced
this pull request
Feb 14, 2026
* Add reasoning, assessment and metadata * more guards * nit * fix syntax * some unit tests * more tests * fix lint * undefined * address comments * partial revert * revert metadata * pass / fail * fix test * fix test * json * token * doh * fix message * fix doc * fixes * fix
Merged
juan-fernandez
pushed a commit
that referenced
this pull request
Feb 18, 2026
* Add reasoning, assessment and metadata * more guards * nit * fix syntax * some unit tests * more tests * fix lint * undefined * address comments * partial revert * revert metadata * pass / fail * fix test * fix test * json * token * doh * fix message * fix doc * fixes * fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds reasoning, metadata and assessment to the submitEvaluation endpoint.
Add support for JSON value type.
Motivation
Close feature gaps between the Python SDK.
Customer FR: https://datadoghq.atlassian.net/browse/MLOS-459
Test