fix(ws): avoid retaining connection span#7469
Merged
Conversation
Run ws socket setup in a store scope without the connection span so internal ws handlers don't capture and keep it alive.
Contributor
Overall package sizeSelf size: 4.58 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.6 | 81.92 kB | 813.08 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7469 +/- ##
==========================================
- Coverage 80.34% 80.31% -0.03%
==========================================
Files 731 731
Lines 31093 31140 +47
==========================================
+ Hits 24981 25011 +30
- Misses 6112 6129 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2026-02-11 15:07:29 Comparing candidate commit 7b2932d in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 231 metrics, 29 unstable metrics. |
rochdev
reviewed
Feb 10, 2026
This comment has been minimized.
This comment has been minimized.
rochdev
approved these changes
Feb 11, 2026
Member
rochdev
left a comment
rochdev
left a comment
There was a problem hiding this comment.
A few non-blocking nitpicks, but otherwise LGTM!
|
|
||
| // Bind the setSocket channel so internal ws event handlers (data, close) | ||
| // don't capture their async context. | ||
| this.addBind('tracing:ws:server:connect:setSocket', () => {}) |
Member
There was a problem hiding this comment.
Nit, but I think this would be a case where explicitly returning undefined makes the intent clearer.
Member
Author
There was a problem hiding this comment.
Our linter prohibits that. I would have to add an exception for that which is also meh
| agent.close({ ritmReset: false, wipe: true }) | ||
| }) | ||
|
|
||
| it('should not retain the connection span during socket setup', async () => { |
Member
There was a problem hiding this comment.
Nit: I'd probably reword this, as that's actually only a side effect. If a span shouldn't be active, it means that those handlers were previously in the wrong context, so that's the real problem that the test is testing for.
dd-octo-sts bot
pushed a commit
that referenced
this pull request
Feb 12, 2026
Run ws socket setup in a store scope without the connection span so internal ws handlers don't capture and keep it alive.
Merged
juan-fernandez
pushed a commit
that referenced
this pull request
Feb 12, 2026
Run ws socket setup in a store scope without the connection span so internal ws handlers don't capture and keep it alive.
BridgeAR
added a commit
that referenced
this pull request
Feb 22, 2026
Run ws socket setup in a store scope without the connection span so internal ws handlers don't capture and keep it alive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run ws socket setup in a store scope without the connection span so internal ws handlers don't capture and keep it alive.