test: fix flaky confluenctinc kafka error#7460
Merged
Conversation
The broker needs some time after creating a new topic to settle in.
Contributor
Overall package sizeSelf size: 4.58 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.6 | 81.92 kB | 813.08 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7460 +/- ##
==========================================
- Coverage 80.34% 80.33% -0.01%
==========================================
Files 731 731
Lines 31093 31093
==========================================
- Hits 24981 24980 -1
- Misses 6112 6113 +1 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2026-02-08 02:12:00 Comparing candidate commit 9fe407f in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 231 metrics, 29 unstable metrics. |
pabloerhard
reviewed
Feb 9, 2026
packages/datadog-plugin-confluentinc-kafka-javascript/test/index.spec.js
Outdated
Show resolved
Hide resolved
BridgeAR
changed the title
This comment has been minimized.
This comment has been minimized.
dd-octo-sts bot
pushed a commit
that referenced
this pull request
Feb 10, 2026
The broker needs some time after creating a new topic to settle in. The old commented error test case could not work due to expecting to catch a user error (which we should not). It is therefore removed.
Closed
bm1549
pushed a commit
that referenced
this pull request
Feb 10, 2026
The broker needs some time after creating a new topic to settle in. The old commented error test case could not work due to expecting to catch a user error (which we should not). It is therefore removed.
dd-octo-sts bot
pushed a commit
that referenced
this pull request
Feb 10, 2026
The broker needs some time after creating a new topic to settle in. The old commented error test case could not work due to expecting to catch a user error (which we should not). It is therefore removed.
Merged
juan-fernandez
pushed a commit
that referenced
this pull request
Feb 12, 2026
The broker needs some time after creating a new topic to settle in. The old commented error test case could not work due to expecting to catch a user error (which we should not). It is therefore removed.
BridgeAR
added a commit
that referenced
this pull request
Feb 22, 2026
The broker needs some time after creating a new topic to settle in. The old commented error test case could not work due to expecting to catch a user error (which we should not). It is therefore removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The broker needs some time after creating a new topic to settle in. I was able to run it 400 times in a row without error while it could theoretically still fail in some rare circumstances.
I also removed the old commented error test case. It could not work like that due to
expecting to catch a user error (which we should not).