Skip to content

fix(ws): handle removing untracked event listeners#7419

Merged
crysmags merged 1 commit intomasterfrom
crysmags/ws-eventHandler-fix
Feb 3, 2026
Merged

fix(ws): handle removing untracked event listeners#7419
crysmags merged 1 commit intomasterfrom
crysmags/ws-eventHandler-fix

Conversation

@crysmags
Copy link
Copy Markdown
Collaborator

@crysmags crysmags commented Feb 3, 2026

When calling removeListener/off with a handler that was never added to the tracked handlers it will fall back to the original handler instead of passing undefined. This prevents errors when users remove listeners that weren't added.

@crysmags crysmags requested review from a team as code owners February 3, 2026 14:26
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.39%. Comparing base (e19ce95) to head (9f38f42).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7419      +/-   ##
==========================================
- Coverage   80.39%   80.39%   -0.01%     
==========================================
  Files         732      732              
  Lines       31028    31028              
==========================================
- Hits        24945    24944       -1     
- Misses       6083     6084       +1     
Flag Coverage Δ
aiguard-macos 39.06% <ø> (-0.11%) ⬇️
aiguard-ubuntu 39.10% <ø> (-0.11%) ⬇️
aiguard-windows 38.95% <ø> (-0.11%) ⬇️
apm-capabilities-tracing-macos 48.90% <ø> (ø)
apm-capabilities-tracing-ubuntu 48.90% <ø> (ø)
apm-capabilities-tracing-windows 48.63% <ø> (ø)
apm-integrations-child-process 38.56% <ø> (-0.11%) ⬇️
apm-integrations-couchbase-18 37.43% <ø> (+0.04%) ⬆️
apm-integrations-couchbase-eol 37.92% <ø> (+0.04%) ⬆️
apm-integrations-oracledb 37.96% <ø> (-0.10%) ⬇️
appsec-express 55.37% <ø> (-0.08%) ⬇️
appsec-fastify 51.99% <ø> (-0.08%) ⬇️
appsec-graphql 52.32% <ø> (-0.07%) ⬇️
appsec-kafka 44.62% <ø> (-0.09%) ⬇️
appsec-ldapjs 44.29% <ø> (-0.09%) ⬇️
appsec-lodash 43.97% <ø> (-0.09%) ⬇️
appsec-macos 58.44% <ø> (-0.07%) ⬇️
appsec-mongodb-core 49.07% <ø> (-0.20%) ⬇️
appsec-mongoose 49.88% <ø> (-0.08%) ⬇️
appsec-mysql 51.26% <ø> (-0.08%) ⬇️
appsec-node-serialize 43.48% <ø> (-0.09%) ⬇️
appsec-passport 48.08% <ø> (-0.09%) ⬇️
appsec-postgres 51.03% <ø> (-0.10%) ⬇️
appsec-sourcing 42.82% <ø> (-0.09%) ⬇️
appsec-template 43.65% <ø> (-0.09%) ⬇️
appsec-ubuntu 58.47% <ø> (-0.07%) ⬇️
appsec-windows 58.33% <ø> (-0.07%) ⬇️
instrumentations-instrumentation-bluebird 32.25% <ø> (-0.11%) ⬇️
instrumentations-instrumentation-body-parser 40.70% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-child_process 37.86% <ø> (-0.11%) ⬇️
instrumentations-instrumentation-cookie-parser 34.49% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-express 34.83% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-express-mongo-sanitize 34.63% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-express-session 40.38% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-fs 31.85% <ø> (-0.11%) ⬇️
instrumentations-instrumentation-generic-pool 29.79% <ø> (ø)
instrumentations-instrumentation-http 39.59% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-knex 32.26% <ø> (-0.11%) ⬇️
instrumentations-instrumentation-mongoose 33.58% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-multer 40.44% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-mysql2 38.25% <ø> (-0.11%) ⬇️
instrumentations-instrumentation-passport 40.74% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-passport-http 40.71% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-passport-local 40.71% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-pg 37.77% <ø> (-0.11%) ⬇️
instrumentations-instrumentation-promise 32.18% <ø> (-0.11%) ⬇️
instrumentations-instrumentation-promise-js 32.19% <ø> (-0.11%) ⬇️
instrumentations-instrumentation-q 32.23% <ø> (-0.11%) ⬇️
instrumentations-instrumentation-url 32.15% <ø> (-0.11%) ⬇️
instrumentations-instrumentation-when 32.20% <ø> (-0.11%) ⬇️
llmobs-ai 41.38% <ø> (-0.10%) ⬇️
llmobs-anthropic 40.60% <ø> (-0.10%) ⬇️
llmobs-bedrock 39.48% <ø> (-0.09%) ⬇️
llmobs-google-genai 40.08% <0.00%> (-0.09%) ⬇️
llmobs-langchain 39.63% <ø> (-0.08%) ⬇️
llmobs-openai 44.43% <ø> (-0.09%) ⬇️
llmobs-vertex-ai 40.38% <ø> (-0.10%) ⬇️
platform-core 28.09% <ø> (ø)
platform-esbuild 31.49% <ø> (ø)
platform-instrumentations-misc 39.62% <ø> (ø)
platform-shimmer 34.83% <ø> (ø)
platform-unit-guardrails 30.37% <ø> (ø)
plugins-azure-event-hubs 22.64% <ø> (ø)
plugins-azure-service-bus 22.08% <ø> (ø)
plugins-bullmq 43.53% <ø> (-0.10%) ⬇️
plugins-cassandra 38.00% <ø> (-0.10%) ⬇️
plugins-cookie 23.69% <ø> (ø)
plugins-cookie-parser 23.50% <ø> (ø)
plugins-crypto 22.88% <ø> (ø)
plugins-dd-trace-api 38.37% <ø> (-0.11%) ⬇️
plugins-express-mongo-sanitize 23.67% <ø> (ø)
plugins-express-session 23.46% <ø> (ø)
plugins-fastify 42.50% <ø> (-0.10%) ⬇️
plugins-fetch 38.57% <ø> (-0.10%) ⬇️
plugins-fs 38.63% <ø> (-0.11%) ⬇️
plugins-generic-pool 22.68% <ø> (ø)
plugins-google-cloud-pubsub 45.70% <ø> (-0.09%) ⬇️
plugins-grpc 41.27% <ø> (-0.10%) ⬇️
plugins-handlebars 23.71% <ø> (ø)
plugins-hapi 40.40% <ø> (-0.10%) ⬇️
plugins-hono 40.60% <ø> (-0.10%) ⬇️
plugins-ioredis 38.43% <ø> (-0.11%) ⬇️
plugins-knex 23.51% <ø> (ø)
plugins-ldapjs 21.28% <ø> (ø)
plugins-limitd-client 32.55% <ø> (-0.11%) ⬇️
plugins-lodash 22.74% <ø> (ø)
plugins-mariadb 39.50% <ø> (-0.11%) ⬇️
plugins-memcached 38.17% <ø> (-0.11%) ⬇️
plugins-microgateway-core 39.41% <ø> (-0.10%) ⬇️
plugins-moleculer 40.81% <ø> (-0.10%) ⬇️
plugins-mongodb 39.52% <ø> (-0.10%) ⬇️
plugins-mongodb-core 39.09% <ø> (-0.10%) ⬇️
plugins-mongoose 39.15% <ø> (-0.10%) ⬇️
plugins-multer 23.46% <ø> (ø)
plugins-mysql 39.22% <ø> (-0.11%) ⬇️
plugins-mysql2 39.27% <ø> (-0.10%) ⬇️
plugins-node-serialize 23.73% <ø> (ø)
plugins-opensearch 37.84% <ø> (-0.10%) ⬇️
plugins-postgres 35.68% <ø> (-0.09%) ⬇️
plugins-process 22.88% <ø> (ø)
plugins-pug 23.69% <ø> (ø)
plugins-redis 38.76% <ø> (-0.11%) ⬇️
plugins-router 43.21% <ø> (-0.10%) ⬇️
plugins-sequelize 22.27% <ø> (ø)
plugins-test-and-upstream-amqp10 38.50% <ø> (-0.11%) ⬇️
plugins-test-and-upstream-amqplib 43.86% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-apollo 39.29% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-avsc 38.79% <ø> (-0.11%) ⬇️
plugins-test-and-upstream-bunyan 33.84% <ø> (-0.11%) ⬇️
plugins-test-and-upstream-connect 41.01% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-graphql 40.20% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-koa 40.65% <0.00%> (-0.10%) ⬇️
plugins-test-and-upstream-protobufjs 39.02% <ø> (-0.11%) ⬇️
plugins-test-and-upstream-rhea 44.15% <ø> (-0.10%) ⬇️
plugins-undici 39.36% <ø> (-0.10%) ⬇️
plugins-url 22.88% <ø> (ø)
plugins-valkey 38.06% <ø> (-0.11%) ⬇️
plugins-vm 22.88% <ø> (ø)
plugins-winston 34.25% <ø> (-0.10%) ⬇️
plugins-ws 40.73% <100.00%> (-0.10%) ⬇️
profiling-macos 40.01% <ø> (-0.10%) ⬇️
profiling-ubuntu 40.06% <ø> (-0.10%) ⬇️
profiling-windows 41.43% <ø> (-0.10%) ⬇️
serverless-azure-functions-client 22.88% <ø> (ø)
serverless-azure-functions-eventhubs 22.88% <ø> (ø)
serverless-azure-functions-servicebus 22.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 3, 2026

Overall package size

Self size: 4.56 MB
Deduped: 5.39 MB
No deduping: 5.39 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.3 | 76.87 kB | 808.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Feb 3, 2026

Benchmarks

Benchmark execution time: 2026-02-03 14:35:00

Comparing candidate commit 9f38f42 in PR branch crysmags/ws-eventHandler-fix with baseline commit e19ce95 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 229 metrics, 31 unstable metrics.

Copy link
Copy Markdown
Contributor

@pabloerhard pabloerhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@crysmags crysmags merged commit 76e93d7 into master Feb 3, 2026
789 of 790 checks passed
@crysmags crysmags deleted the crysmags/ws-eventHandler-fix branch February 3, 2026 18:37
@dd-octo-sts dd-octo-sts bot mentioned this pull request Feb 4, 2026
@tlhunter
Copy link
Copy Markdown
Member

tlhunter commented Feb 4, 2026

Fixes #7415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants