Conversation
Overall package sizeSelf size: 4.5 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.3 | 76.87 kB | 808.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7413 +/- ##
=======================================
Coverage 80.39% 80.39%
=======================================
Files 732 732
Lines 31027 31027
=======================================
Hits 24945 24945
Misses 6082 6082 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| "name": "pg", | ||
| "versions": ["8.7.3"] |
There was a problem hiding this comment.
As discussed: I believe this is still used
There was a problem hiding this comment.
yep, it's already back in the json
|
We could add this to our setup which is called automatically for all tests: const ORIGINAL_PROCESS_EXIT = process.exit
exports.mochaHooks = {
beforeAll () {
process.exit = (code) => {
throw new Error(`process.exit(${code}) was called during tests`)
}
},
afterAll () {
process.exit = ORIGINAL_PROCESS_EXIT
}, |
BenchmarksBenchmark execution time: 2026-02-02 23:37:37 Comparing candidate commit 5e44433 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 232 metrics, 28 unstable metrics. |
BridgeAR
left a comment
There was a problem hiding this comment.
LGTM with green CI (currently unknown due to github outage)
…7413) * added sqlite3 into externals * Added process.exit patching before mocha tests --------- Co-authored-by: Ruben Bridgewater <[email protected]>
…7413) * added sqlite3 into externals * Added process.exit patching before mocha tests --------- Co-authored-by: Ruben Bridgewater <[email protected]>
…7413) * added sqlite3 into externals * Added process.exit patching before mocha tests --------- Co-authored-by: Ruben Bridgewater <[email protected]>
…7413) * added sqlite3 into externals * Added process.exit patching before mocha tests --------- Co-authored-by: Ruben Bridgewater <[email protected]>
Please make sure your changes are properly tested!
What does this PR do?
Motivation
Additional Notes