refactor(logging): use printf-style formatting#7409
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #7409 +/- ##
=======================================
Coverage 80.56% 80.57%
=======================================
Files 731 731
Lines 31236 31233 -3
=======================================
- Hits 25166 25165 -1
+ Misses 6070 6068 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Overall package sizeSelf size: 4.49 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.3 | 76.87 kB | 808.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
This comment has been minimized.
This comment has been minimized.
watson
force-pushed
the
watson/cleanup-logs
branch
from
0304c74 to
c214f53
Compare
watson
force-pushed
the
watson/cleanup-logs
branch
2 times, most recently
from
ec78b86 to
f105a9c
Compare
Replace string concatenation and callback-style logging with printf-style formatting (%d, %s placeholders) for better performance and consistency. Merge multi-line concatenated strings into single strings with eslint max-len disables where needed to avoid unnecessary string operations.
watson
force-pushed
the
watson/cleanup-logs
branch
from
f105a9c to
3e585f2
Compare
Member
|
I don't want to prefix all of my long log lines with ignore comments... Can the AI write a rule to auto ignore line lengths for log lines? |
Collaborator
Author
|
@tlhunter maybe, but I don't think it's really a problem. Normally a log line is not that long. We have close to 500 |
tlhunter
approved these changes
Feb 2, 2026
dd-octo-sts bot
pushed a commit
that referenced
this pull request
Feb 3, 2026
Replace string concatenation and callback-style logging with printf-style formatting (%d, %s placeholders) for better performance and consistency. Merge multi-line concatenated strings into single strings with eslint max-len disables where needed to avoid unnecessary string operations.
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Feb 5, 2026
Replace string concatenation and callback-style logging with printf-style formatting (%d, %s placeholders) for better performance and consistency. Merge multi-line concatenated strings into single strings with eslint max-len disables where needed to avoid unnecessary string operations.
bm1549
pushed a commit
that referenced
this pull request
Feb 10, 2026
Replace string concatenation and callback-style logging with printf-style formatting (%d, %s placeholders) for better performance and consistency. Merge multi-line concatenated strings into single strings with eslint max-len disables where needed to avoid unnecessary string operations.
BridgeAR
pushed a commit
that referenced
this pull request
Feb 22, 2026
Replace string concatenation and callback-style logging with printf-style formatting (%d, %s placeholders) for better performance and consistency. Merge multi-line concatenated strings into single strings with eslint max-len disables where needed to avoid unnecessary string operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors logging statements across the codebase, where appropriate, to use printf-style formatting (
%d,%splaceholders) instead of string concatenation and callback-style logging.The changes also merge multi-line concatenated strings into single strings, eliminating runtime string concatenation overhead.
Motivation
Improve performance by avoiding unnecessary string operations and provides more consistent logging patterns throughout the tracer.
Additional notes
The new ESLint rule is written by AI, and I have only reviewed it briefly. But I think that's ok since it's just an ESLint rule.