chore: activate unicorn/no-array-for-each eslint rule#7403
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #7403 +/- ##
=======================================
Coverage 80.39% 80.40%
=======================================
Files 732 732
Lines 31028 31050 +22
=======================================
+ Hits 24945 24965 +20
- Misses 6083 6085 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Overall package sizeSelf size: 4.5 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.3 | 76.87 kB | 808.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
This comment has been minimized.
This comment has been minimized.
BenchmarksBenchmark execution time: 2026-02-03 03:07:28 Comparing candidate commit 6684250 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 229 metrics, 31 unstable metrics. |
tlhunter
reviewed
Feb 2, 2026
| status = 'skip' | ||
| } else { | ||
| // has to check every test in the test file | ||
| // eslint-disable-next-line unicorn/no-array-for-each |
Member
Author
There was a problem hiding this comment.
Mocha was weird. I believe they have own methods that are not behaving as the native one.
tlhunter
previously approved these changes
Feb 2, 2026
BridgeAR
force-pushed
the
BridgeAR/2026-02-01-activate-unicorn-foreach-rule
branch
from
95fce24 to
6684250
Compare
sabrenner
reviewed
Feb 3, 2026
Collaborator
sabrenner
left a comment
sabrenner
left a comment
There was a problem hiding this comment.
lgtm! just a couple of questions about some things are changing behavior/could cause regressions (although, i could be wrong for sure, but if i'm right, it seems we don't have test cases that cover them 😅). on resolving the comments im good to approve!
BridgeAR
deleted the
BridgeAR/2026-02-01-activate-unicorn-foreach-rule
branch
dd-octo-sts bot
pushed a commit
that referenced
this pull request
Feb 4, 2026
This uses autofixes with manual improvements afterwards.
Merged
BridgeAR
added a commit
that referenced
this pull request
Feb 5, 2026
This uses autofixes with manual improvements afterwards.
bm1549
pushed a commit
that referenced
this pull request
Feb 10, 2026
This uses autofixes with manual improvements afterwards.
BridgeAR
added a commit
that referenced
this pull request
Feb 22, 2026
This uses autofixes with manual improvements afterwards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses autofixes with manual improvements afterwards.