test(debugger): fix race condition in test helpers#7394
Merged
Conversation
Prevent event listeners in setupAssertionListeners from firing multiple times and overwriting trace IDs. The 'message' listener now removes itself after capturing the first valid span, and the 'debugger-input' listener uses .once() instead of .on(). This fixes flaky test failures where subsequent HTTP requests would update the traceId/spanId variables, causing assertion mismatches.
Contributor
Overall package sizeSelf size: 4.49 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.3 | 76.87 kB | 808.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
|
BenchmarksBenchmark execution time: 2026-01-30 11:44:44 Comparing candidate commit bc68e94 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 226 metrics, 34 unstable metrics. |
BridgeAR
reviewed
Jan 30, 2026
BridgeAR
approved these changes
Jan 30, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7394 +/- ##
==========================================
- Coverage 86.07% 85.72% -0.36%
==========================================
Files 510 518 +8
Lines 22102 22374 +272
==========================================
+ Hits 19025 19180 +155
- Misses 3077 3194 +117 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dd-octo-sts bot
pushed a commit
that referenced
this pull request
Jan 31, 2026
Prevent event listeners in setupAssertionListeners from firing multiple times and overwriting trace IDs. The 'message' listener now removes itself after capturing the first valid span, and the 'debugger-input' listener uses .once() instead of .on(). This fixes flaky test failures where subsequent HTTP requests would update the traceId/spanId variables, causing assertion mismatches.
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Feb 5, 2026
Prevent event listeners in setupAssertionListeners from firing multiple times and overwriting trace IDs. The 'message' listener now removes itself after capturing the first valid span, and the 'debugger-input' listener uses .once() instead of .on(). This fixes flaky test failures where subsequent HTTP requests would update the traceId/spanId variables, causing assertion mismatches.
BridgeAR
pushed a commit
that referenced
this pull request
Feb 22, 2026
Prevent event listeners in setupAssertionListeners from firing multiple times and overwriting trace IDs. The 'message' listener now removes itself after capturing the first valid span, and the 'debugger-input' listener uses .once() instead of .on(). This fixes flaky test failures where subsequent HTTP requests would update the traceId/spanId variables, causing assertion mismatches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Attempt to fix a race condition in the debugger integration test helper function
setupAssertionListenersthat was likely causing flaky test failures in CI, particularly the testDD_TRACING_ENABLED=true, DD_TRACE_128_BIT_TRACEID_GENERATION_ENABLED=false→should capture and send expected payload when a log line probe is triggered.The fix:
'message'listener now removes itself immediately after capturing the first valid span witht.agent.removeListener('message', messageListener)'debugger-input'listener now uses.once()instead of.on()since we expect exactly one debugger payload per testMotivation
The test was failing intermittently with trace ID mismatches like:
The root cause seems to be that event listeners were using
.on()and persisting across multiple events. When multiple HTTP requests occurred (from background activity or timing variations), the'message'listener would fire multiple times, updating the shared closure variables (traceId,spanId) with values from different requests. This caused assertions to compare trace IDs from mismatched requests.