ci: fix coverage reports and prevent detecting fixture files#7391
ci: fix coverage reports and prevent detecting fixture files#7391
Conversation
Our test optimization product is using fixture files that are automatically picked up by CodeCov. Instead of having to declare our coverage files in all CI scripts, this just renames these fixture files, since they are just imported to read their content. To prevent future issues, a small lint job is added that prevents names that might be detected as coverage.
Overall package sizeSelf size: 4.49 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.3 | 76.87 kB | 808.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7391 +/- ##
==========================================
- Coverage 85.86% 80.58% -5.29%
==========================================
Files 518 731 +213
Lines 22375 31234 +8859
==========================================
+ Hits 19212 25169 +5957
- Misses 3163 6065 +2902 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
BenchmarksBenchmark execution time: 2026-02-01 16:13:09 Comparing candidate commit 5e99b70 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 232 metrics, 28 unstable metrics. |
watson
left a comment
There was a problem hiding this comment.
LGTM in general, just one small thing which I think is a mistake, and two non-blocking nits.
Our test optimization product is using fixture files that are automatically picked up by CodeCov. Instead of having to declare our coverage files in all CI scripts, this just renames these fixture files, since they are just imported to read their content. To prevent future issues, a small lint job is added that prevents names that might be detected as coverage. The scripts are now way simpler due to the fix and a dynamic config is used for nyc. While this officially 'decreases' our coverage, the opposite is actually the case. We now track 9000 more lines and 200 files of which we cover 6000 lines. That is why our overall coverage drops while we actually properly handle the coverage now. All our CodeCov uploaded files are now correct and none create errors. This PR makes our coverage way more solid and is a first step towards also tracking the coverage of integration tests. Coverage is now tracked in individual folders per Node.js version and plugin name. That way CodeCov is merging the coverage instead of nyc and we never replace existing coverage.
Our test optimization product is using fixture files that are automatically picked up by CodeCov. Instead of having to declare our coverage files in all CI scripts, this just renames these fixture files, since they are just imported to read their content. To prevent future issues, a small lint job is added that prevents names that might be detected as coverage. The scripts are now way simpler due to the fix and a dynamic config is used for nyc. While this officially 'decreases' our coverage, the opposite is actually the case. We now track 9000 more lines and 200 files of which we cover 6000 lines. That is why our overall coverage drops while we actually properly handle the coverage now. All our CodeCov uploaded files are now correct and none create errors. This PR makes our coverage way more solid and is a first step towards also tracking the coverage of integration tests. Coverage is now tracked in individual folders per Node.js version and plugin name. That way CodeCov is merging the coverage instead of nyc and we never replace existing coverage.
Our test optimization product is using fixture files that are automatically picked up by CodeCov. Instead of having to declare our coverage files in all CI scripts, this just renames these fixture files, since they are just imported to read their content. To prevent future issues, a small lint job is added that prevents names that might be detected as coverage. The scripts are now way simpler due to the fix and a dynamic config is used for nyc. While this officially 'decreases' our coverage, the opposite is actually the case. We now track 9000 more lines and 200 files of which we cover 6000 lines. That is why our overall coverage drops while we actually properly handle the coverage now. All our CodeCov uploaded files are now correct and none create errors. This PR makes our coverage way more solid and is a first step towards also tracking the coverage of integration tests. Coverage is now tracked in individual folders per Node.js version and plugin name. That way CodeCov is merging the coverage instead of nyc and we never replace existing coverage.
Our test optimization product is using fixture files that are automatically picked up by CodeCov. Instead of having to declare our coverage files in all CI scripts, this just renames these fixture files, since they are just imported to read their content. To prevent future issues, a small lint job is added that prevents names that might be detected as coverage. The scripts are now way simpler due to the fix and a dynamic config is used for nyc. While this officially 'decreases' our coverage, the opposite is actually the case. We now track 9000 more lines and 200 files of which we cover 6000 lines. That is why our overall coverage drops while we actually properly handle the coverage now. All our CodeCov uploaded files are now correct and none create errors. This PR makes our coverage way more solid and is a first step towards also tracking the coverage of integration tests. Coverage is now tracked in individual folders per Node.js version and plugin name. That way CodeCov is merging the coverage instead of nyc and we never replace existing coverage.
Our test optimization product is using fixture files that are automatically picked up by CodeCov. Instead of having to declare our coverage files in all CI scripts, this just renames these fixture files, since they are just imported to read their content.
To prevent future issues, a small lint job is added that prevents names that might be detected as coverage.
The scripts are now way simpler due to the fix and a dynamic config is used for nyc.
While this officially 'decreases' our coverage, the opposite is actually the case.
We now track 9000 more lines and 200 files of which we cover 6000 lines. That is why our overall coverage drops while we actually properly handle the coverage now.
All our uploaded files are now correct and none create errors:
This PR makes our coverage way more solid and is a first step towards also tracking the coverage of integration tests.
Coverage is now tracked in individual folders per Node.js version and plugin name. That way CodeCov is merging the coverage instead of nyc and we never replace existing coverage.