Conversation
Overall package sizeSelf size: 4.46 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.3 | 76.87 kB | 808.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7379 +/- ##
==========================================
+ Coverage 86.02% 86.16% +0.13%
==========================================
Files 515 515
Lines 22245 22245
==========================================
+ Hits 19137 19168 +31
+ Misses 3108 3077 -31 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2026-01-29 14:24:28 Comparing candidate commit b3d74cc in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 230 metrics, 30 unstable metrics. |
| { | ||
| "name": "@fastify/multipart", | ||
| "versions": [">=6"] | ||
| "versions": [">=6", "9.3.0"] |
There was a problem hiding this comment.
This forces the execution of the tests with 9.3.0 version of @fastify/multipart and prevents to be skipped because it has a newer version.
There was a problem hiding this comment.
Are we still testing newer versions than 9.3 as well?
There was a problem hiding this comment.
Yes, they are. For example here: https://github.com/DataDog/dd-trace-js/actions/runs/21481537300/job/61880423233
Suspicious request blocking - multipart
with @fastify/multipart >=6 (6.0.0)
- should not block the request without an attack
- should block the request when attack is detected
with @fastify/multipart >=6 (9.4.0)
✔ should not block the request without an attack
✔ should block the request when attack is detected
with @fastify/multipart 9.3.0 (9.3.0)
✔ should not block the request without an attack
✔ should block the request when attack is detected
But without that, the 9.3.0 would be skipped, because it is not the oldest nor the latest, as it is the latest that works with fastify 3.0.0, I want to run it also
uurien
changed the title
|
3 participants
Please make sure your changes are properly tested!
What does this PR do?
Update @fastify/multipart used in tests to the latest version and skips the tests for latest version of multipart with the newest version of multipart.
Motivation
Test was failing in the automatic PR: #7372
Additional Notes