Fix: Update Opentelemety Active Functionality by bojbrook · Pull Request #7319 · DataDog/dd-trace-js

bojbrook · 2026-01-22T20:41:57Z

What does this PR do?

This PR refactors the context manager’s active() method to improve context handling between Datadog and OpenTelemetry and to fix edge cases when converting between Datadog and OpenTelemetry spans.

Motivation

This issue was reported in APMS-18328 and can be reproduced with the code below. The core problem is that retrieving and setting the active span works as expected when using the Datadog API, but fails silently when performed through the OpenTelemetry API.

function enrichSpan() {
    const ddSpan = ddTrace.scope().active();
    const otelSpan = trace.getActiveSpan();
    // 1. OTel Attempt: SILENT FAILURE
    otelSpan?.setAttribute('my.otel.attr', 'failed');

    // 2. Datadog Attempt: SUCCESS
    ddSpan?.addTags({ 'my.dd.attr': 'success' });
}

function main() {
    otelTracer.startActiveSpan('otel-span', async (span) => {
        enrichSpan();
        await sleep(1000);
        span.end();
    });

    console.log('Ending main function');
}

main();

Expected result: For this scenario we would expect both tags(attributes) to be present on the same span.

Plugin Checklist

Additional Notes

github-actions · 2026-01-22T20:42:37Z

Overall package size

Self size: 4.5 MB
Deduped: 5.33 MB
No deduping: 5.33 MB

Dependency sizes

| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.3 | 76.87 kB | 808.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

codecov · 2026-01-22T20:44:30Z

Codecov Report

❌ Patch coverage is 94.44444% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.84%. Comparing base (4a8a494) to head (8b9d3f9).
⚠️ Report is 8 commits behind head on master.

Files with missing lines	Patch %	Lines
...ages/dd-trace/src/opentelemetry/context_manager.js	94.44%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7319      +/-   ##
==========================================
- Coverage   85.86%   85.84%   -0.02%     
==========================================
  Files         518      518              
  Lines       22375    22387      +12     
==========================================
+ Hits        19212    19219       +7     
- Misses       3163     3168       +5

Flag	Coverage Δ
aiguard-macos	`99.09% <ø> (ø)`
aiguard-ubuntu	`99.09% <ø> (ø)`
aiguard-windows	`99.09% <ø> (ø)`
apm-capabilities-tracing-macos	`57.66% <94.44%> (+<0.01%)`	⬆️
apm-capabilities-tracing-ubuntu	`57.66% <94.44%> (+<0.01%)`	⬆️
apm-capabilities-tracing-windows	`57.28% <94.44%> (+0.01%)`	⬆️
apm-integrations-child-process	`99.19% <ø> (ø)`
apm-integrations-couchbase-18	`100.00% <ø> (ø)`
apm-integrations-couchbase-eol	`100.00% <ø> (ø)`
appsec-express	`62.54% <ø> (ø)`
appsec-fastify	`58.55% <ø> (ø)`
appsec-graphql	`53.40% <ø> (ø)`
appsec-kafka	`43.98% <ø> (ø)`
appsec-ldapjs	`46.04% <ø> (ø)`
appsec-lodash	`47.29% <ø> (ø)`
appsec-macos	`93.76% <ø> (ø)`
appsec-mongodb-core	`51.82% <ø> (ø)`
appsec-mongoose	`50.73% <ø> (ø)`
appsec-mysql	`54.16% <ø> (ø)`
appsec-node-serialize	`43.92% <ø> (ø)`
appsec-passport	`48.07% <ø> (ø)`
appsec-postgres	`54.51% <ø> (ø)`
appsec-sourcing	`33.80% <ø> (ø)`
appsec-template	`43.92% <ø> (ø)`
appsec-ubuntu	`93.76% <ø> (ø)`
appsec-windows	`93.76% <ø> (ø)`
llmobs-ai	`52.09% <ø> (ø)`
llmobs-anthropic	`42.73% <ø> (ø)`
llmobs-bedrock	`40.06% <ø> (ø)`
llmobs-google-genai	`45.89% <ø> (ø)`
llmobs-langchain	`50.15% <ø> (ø)`
llmobs-openai	`55.62% <ø> (ø)`
llmobs-vertex-ai	`44.48% <ø> (ø)`
platform-core	`87.23% <ø> (ø)`
platform-instrumentations-misc	`89.16% <ø> (ø)`
platform-shimmer	`98.80% <ø> (ø)`
platform-unit-guardrails	`89.47% <ø> (ø)`
profiling-macos	`70.74% <ø> (ø)`
profiling-ubuntu	`70.74% <ø> (ø)`
profiling-windows	`74.23% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pr-commenter · 2026-01-23T16:23:17Z

Benchmarks

Benchmark execution time: 2026-02-01 17:46:04

Comparing candidate commit 8b9d3f9 in PR branch bojbrook/otel-context_manager with baseline commit 4a8a494 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 233 metrics, 27 unstable metrics.

rochdev · 2026-01-27T22:18:20Z

packages/dd-trace/src/opentelemetry/context_manager.js

+        return propagation.setBaggage(store, otelBaggages)
      }
-      return context
+      return store


Isn't active supposed to always return a context? Or is a context also a plain object similar to a store so a store can be used in-place?

rochdev

Just a non-blocking question but otherwise LGTM.

bojbrook · 2026-02-02T16:15:22Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-02-02T16:15:27Z

View all feedbacks in Devflow UI.

2026-02-02 16:15:26 UTC ℹ️ Start processing command /merge

2026-02-02 16:15:32 UTC ℹ️ MergeQueue: queue is disabled

Added to the queue but the mergequeue is not enabled for now.

2026-02-02 16:18:10 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

bojbrook · 2026-02-02T16:17:50Z

/remove

gh-worker-devflow-routing-ef8351 · 2026-02-02T16:17:53Z

View all feedbacks in Devflow UI.

2026-02-02 16:17:53 UTC ℹ️ Start processing command /remove

2026-02-02 16:17:57 UTC ℹ️ Devflow: /remove

* update active function * comments --------- Co-authored-by: Thomas Watson <[email protected]>

bojbrook requested a review from a team as a code owner January 22, 2026 20:41

bojbrook added the semver-patch label Jan 22, 2026

bojbrook requested review from khanayan123 and removed request for a team January 22, 2026 20:41

bojbrook force-pushed the bojbrook/otel-context_manager branch from d90db71 to 48c1ecd Compare January 23, 2026 16:12

rochdev reviewed Jan 27, 2026

View reviewed changes

rochdev approved these changes Jan 27, 2026

View reviewed changes

bojbrook added 2 commits January 28, 2026 10:05

update active function

011d6ac

comments

ffe4213

bojbrook force-pushed the bojbrook/otel-context_manager branch from 48c1ecd to ffe4213 Compare January 28, 2026 17:06

This comment has been minimized.

Sign in to view

Merge branch 'master' into bojbrook/otel-context_manager

8b9d3f9

dd-devflow bot added the mergequeue-status: queued label Feb 2, 2026

dd-devflow bot added mergequeue-status: removed and removed mergequeue-status: queued labels Feb 2, 2026

bojbrook merged commit 60565f1 into master Feb 2, 2026
791 of 792 checks passed

bojbrook deleted the bojbrook/otel-context_manager branch February 2, 2026 16:18

BridgeAR mentioned this pull request Feb 2, 2026

[BUG]: OTel getActiveSpan().setAttributes() fails silently (Context Drift) #7194

Open

dd-octo-sts bot pushed a commit that referenced this pull request Feb 3, 2026

Fix: Update Opentelemety Active Functionality (#7319)

20b13ae

* update active function * comments --------- Co-authored-by: Thomas Watson <[email protected]>

dd-octo-sts bot mentioned this pull request Feb 3, 2026

v5.85.0 proposal #7399

Merged

BridgeAR pushed a commit that referenced this pull request Feb 5, 2026

Fix: Update Opentelemety Active Functionality (#7319)

a9462cb

* update active function * comments --------- Co-authored-by: Thomas Watson <[email protected]>

bm1549 pushed a commit that referenced this pull request Feb 10, 2026

Fix: Update Opentelemety Active Functionality (#7319)

f224564

* update active function * comments --------- Co-authored-by: Thomas Watson <[email protected]>

BridgeAR pushed a commit that referenced this pull request Feb 22, 2026

Fix: Update Opentelemety Active Functionality (#7319)

33ff0ec

* update active function * comments --------- Co-authored-by: Thomas Watson <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Update Opentelemety Active Functionality#7319

Fix: Update Opentelemety Active Functionality#7319
bojbrook merged 3 commits intomasterfrom
bojbrook/otel-context_manager

bojbrook commented Jan 22, 2026

Uh oh!

github-actions bot commented Jan 22, 2026 •

edited

Loading

Uh oh!

codecov bot commented Jan 22, 2026 •

edited

Loading

Uh oh!

pr-commenter bot commented Jan 23, 2026 •

edited

Loading

Uh oh!

rochdev Jan 27, 2026

Uh oh!

rochdev left a comment

Uh oh!

This comment has been minimized.

bojbrook commented Feb 2, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 bot commented Feb 2, 2026 •

edited

Loading

Uh oh!

bojbrook commented Feb 2, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 bot commented Feb 2, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

bojbrook commented Jan 22, 2026

What does this PR do?

Motivation

Plugin Checklist

Additional Notes

Uh oh!

github-actions bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overall package size

Uh oh!

codecov bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pr-commenter bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Uh oh!

rochdev Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

rochdev left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

bojbrook commented Feb 2, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bojbrook commented Feb 2, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Jan 22, 2026 •

edited

Loading

codecov bot commented Jan 22, 2026 •

edited

Loading

pr-commenter bot commented Jan 23, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 bot commented Feb 2, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 bot commented Feb 2, 2026 •

edited

Loading