Skip to content

fix(agent): improve fetchAgentInfo error handling#7313

Merged
BridgeAR merged 1 commit intomasterfrom
watson/agent-info-error-handling
Jan 27, 2026
Merged

fix(agent): improve fetchAgentInfo error handling#7313
BridgeAR merged 1 commit intomasterfrom
watson/agent-info-error-handling

Conversation

@watson
Copy link
Copy Markdown
Collaborator

@watson watson commented Jan 22, 2026

What does this PR do?

Don't call the callback provided to fetchAgentInfo twice if it throws

Copy link
Copy Markdown
Collaborator Author

watson commented Jan 22, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 22, 2026

Overall package size

Self size: 4.45 MB
Deduped: 5.29 MB
No deduping: 5.29 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.3 | 76.87 kB | 808.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.08%. Comparing base (6eed53f) to head (ace3b24).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7313      +/-   ##
==========================================
- Coverage   86.08%   86.08%   -0.01%     
==========================================
  Files         515      514       -1     
  Lines       22233    22229       -4     
==========================================
- Hits        19139    19135       -4     
  Misses       3094     3094              
Flag Coverage Δ
aiguard-macos 99.09% <ø> (ø)
aiguard-ubuntu 99.09% <ø> (ø)
aiguard-windows 99.09% <ø> (ø)
apm-capabilities-tracing-macos 57.88% <100.00%> (-0.01%) ⬇️
apm-capabilities-tracing-ubuntu 57.87% <100.00%> (-0.01%) ⬇️
apm-capabilities-tracing-windows 57.28% <100.00%> (-0.22%) ⬇️
apm-integrations-child-process 99.19% <ø> (ø)
apm-integrations-couchbase-18 100.00% <ø> (ø)
apm-integrations-couchbase-eol 100.00% <ø> (ø)
appsec-express 62.46% <ø> (ø)
appsec-fastify 58.48% <ø> (ø)
appsec-graphql 53.41% <ø> (ø)
appsec-kafka 43.98% <ø> (ø)
appsec-ldapjs 46.04% <ø> (ø)
appsec-lodash 47.29% <ø> (ø)
appsec-macos 93.74% <ø> (ø)
appsec-mongodb-core 51.82% <ø> (ø)
appsec-mongoose 50.73% <ø> (ø)
appsec-mysql 54.20% <ø> (ø)
appsec-node-serialize 43.92% <ø> (ø)
appsec-passport 48.10% <ø> (ø)
appsec-postgres 54.55% <ø> (ø)
appsec-sourcing 33.80% <ø> (ø)
appsec-template 43.92% <ø> (ø)
appsec-ubuntu 93.74% <ø> (ø)
appsec-windows 93.74% <ø> (ø)
llmobs-ai 52.09% <ø> (ø)
llmobs-anthropic 42.73% <ø> (ø)
llmobs-bedrock 40.06% <ø> (ø)
llmobs-google-genai 45.89% <ø> (ø)
llmobs-langchain 50.15% <ø> (ø)
llmobs-openai 55.62% <ø> (ø)
llmobs-vertex-ai 44.48% <ø> (ø)
platform-core 87.23% <ø> (ø)
platform-instrumentations-misc 73.68% <ø> (ø)
platform-shimmer 98.82% <ø> (ø)
platform-unit-guardrails 89.47% <ø> (ø)
profiling-macos 70.74% <ø> (ø)
profiling-ubuntu 70.74% <ø> (ø)
profiling-windows 74.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Jan 22, 2026

Benchmarks

Benchmark execution time: 2026-01-26 11:33:54

Comparing candidate commit 41874d1 in PR branch watson/agent-info-error-handling with baseline commit 57430de in branch watson/cache-agent-info.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 232 metrics, 28 unstable metrics.

@watson watson force-pushed the watson/agent-info-error-handling branch from a8a38c1 to 22ad173 Compare January 22, 2026 12:56
@watson watson force-pushed the watson/cache-agent-info branch from 1ca4a90 to 9cf7768 Compare January 22, 2026 12:59
@watson watson force-pushed the watson/agent-info-error-handling branch 2 times, most recently from 1ed711a to 9e7c238 Compare January 22, 2026 13:05
@watson watson force-pushed the watson/cache-agent-info branch from 9cf7768 to 5114eec Compare January 22, 2026 13:05
@datadog-official

This comment has been minimized.

@watson watson changed the base branch from watson/cache-agent-info to graphite-base/7313 January 26, 2026 11:25
@watson watson force-pushed the watson/agent-info-error-handling branch from 9e7c238 to 41874d1 Compare January 26, 2026 11:25
@watson watson force-pushed the graphite-base/7313 branch from 5114eec to 57430de Compare January 26, 2026 11:25
@watson watson changed the base branch from graphite-base/7313 to watson/cache-agent-info January 26, 2026 11:25
Base automatically changed from watson/cache-agent-info to master January 26, 2026 13:03
Don't call the callback provided to fetchAgentInfo twice if it throws
@watson watson force-pushed the watson/agent-info-error-handling branch from 41874d1 to ace3b24 Compare January 26, 2026 13:05
@watson watson marked this pull request as ready for review January 26, 2026 13:05
@watson watson requested a review from a team as a code owner January 26, 2026 13:05
@BridgeAR BridgeAR merged commit 089e8e1 into master Jan 27, 2026
786 checks passed
@BridgeAR BridgeAR deleted the watson/agent-info-error-handling branch January 27, 2026 16:25
dd-octo-sts bot pushed a commit that referenced this pull request Jan 28, 2026
Don't call the callback provided to fetchAgentInfo twice if it throws
@dd-octo-sts dd-octo-sts bot mentioned this pull request Jan 28, 2026
BridgeAR pushed a commit that referenced this pull request Jan 30, 2026
Don't call the callback provided to fetchAgentInfo twice if it throws
BridgeAR pushed a commit that referenced this pull request Feb 22, 2026
Don't call the callback provided to fetchAgentInfo twice if it throws
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants