Conversation
Overall package sizeSelf size: 4.45 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.3 | 76.87 kB | 808.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7297 +/- ##
=======================================
Coverage 86.03% 86.03%
=======================================
Files 513 513
Lines 22245 22245
=======================================
Hits 19139 19139
Misses 3106 3106 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
BenchmarksBenchmark execution time: 2026-01-22 18:08:20 Comparing candidate commit ddc986c in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 231 metrics, 29 unstable metrics. |
BridgeAR
force-pushed
the
BridgeAR/2026-01-21-fix-most-test-optimization-type-errors-in-tests
branch
from
274b8ec to
f22bf71
Compare
These are mostly passing through stdio as argument to exec, which does not support that argument. In addition, fix a couple of process.env types and add some more types to test helpers. There is one spot where `parallel` was defined was not used in the test. I just added a TODO entry for that.
BridgeAR
force-pushed
the
BridgeAR/2026-01-21-fix-most-test-optimization-type-errors-in-tests
branch
from
767e29e to
505ac3f
Compare
juan-fernandez
left a comment
juan-fernandez
left a comment
There was a problem hiding this comment.
CI seems to be failing now: https://github.com/DataDog/dd-trace-js/actions/runs/21246776002/job/61137915349?pr=7297. Is it related to the latest changes?
|
@juan-fernandez no, as the error says, it is a rate limiting: |
ah, sure, my bad |
…tion-type-errors-in-tests
BridgeAR
deleted the
BridgeAR/2026-01-21-fix-most-test-optimization-type-errors-in-tests
branch
These are mostly passing through stdio as argument to exec, which does not support that argument. In addition, fix a couple of process.env types and add some more types to test helpers. There is one spot where `parallel` was defined was not used in the test. That is removed as well as activating the no-undef eslint rule for test-optimization code. On top, the assertObjectContains helper got improved to always generate a diff in the future, even on older Node.js versions.
These are mostly passing through stdio as argument to exec, which does not support that argument. In addition, fix a couple of process.env types and add some more types to test helpers. There is one spot where `parallel` was defined was not used in the test. That is removed as well as activating the no-undef eslint rule for test-optimization code. On top, the assertObjectContains helper got improved to always generate a diff in the future, even on older Node.js versions.
These are mostly passing through stdio as argument to exec, which does not support that argument. In addition, fix a couple of process.env types and add some more types to test helpers. There is one spot where `parallel` was defined was not used in the test. That is removed as well as activating the no-undef eslint rule for test-optimization code. On top, the assertObjectContains helper got improved to always generate a diff in the future, even on older Node.js versions.
2 participants
These are mostly passing through stdio as argument to exec, which does not support that argument.
In addition, fix a couple of process.env types and add some more types to test helpers.
There is one spot where
parallelwas defined was not used in the test. I just added a TODO entry for that.I also removed unused variables.