fix tedious support now that exported classes are read-only#726
Merged
Conversation
6 tasks
brettlangdon
approved these changes
Oct 30, 2019
brettlangdon
left a comment
brettlangdon
left a comment
Member
There was a problem hiding this comment.
ugh, this is so tedious...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix
tedioussupport now that exported classes are read-only.Now that the scope manager is able to bind event emitter classes and not just individual instances, we can use that instead of the previous approach.
Motivation
Build started failing since 6.5.0 because we were trying to override classes that are now read-only on the export.