chore: remove plugin checklist from PR template#7105
Conversation
simon-id
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7105 +/- ##
==========================================
+ Coverage 85.89% 86.03% +0.13%
==========================================
Files 513 513
Lines 22219 22219
==========================================
+ Hits 19086 19117 +31
+ Misses 3133 3102 -31 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Overall package sizeSelf size: 4.45 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.3 | 76.87 kB | 808.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
This comment has been minimized.
This comment has been minimized.
CONTRIBUTING.md
Outdated
| - [ ] Unit tests. | ||
| - [ ] Integration tests. | ||
| - [ ] Benchmarks. | ||
| - [ ] TypeScript [definitions][2]. | ||
| - [ ] TypeScript [tests][3]. | ||
| - [ ] API [documentation][4]. | ||
| - [ ] CI [jobs/workflows][5]. |
There was a problem hiding this comment.
Why the [ ]? This is no longer an issue/PR
There was a problem hiding this comment.
so people that want to use the checklist can copy paste it in their description or somewhere else ;)
There was a problem hiding this comment.
If it's meant to be copied it should be a code block, otherwise it's not possible. In its current state, it just shows disabled checkboxes that can't be checked
There was a problem hiding this comment.
It's a compromise between making it look good in markdown, and making the original copyable. Either you're reading the markdown in an editor and the original copyable is there, or you're on github interface and there is literally a button to switch to the original:
There was a problem hiding this comment.
I question the usefulness of this and would probably vote to just remove this section altogether
There was a problem hiding this comment.
I'm fine with removing it. It was a request from @bengl on my original slack thread.
There was a problem hiding this comment.
I don't think he intended for people to click "edit source" to actually use it 😉
There was a problem hiding this comment.
i'll have to let him say what he intended himself, don't wanna put words into his mouth. Although, once again it's not clicking "edit source", it's clicking the file then the tab "code", which is available for all markdown files to see the original code instead of the markdown render.
There was a problem hiding this comment.
The intent of this is not to show it nicely, but to make it easy to copy into your PR. So if we want to keep it (which I still doubt the usefulness of), it should be turned into a code block. If you show it "nicely", many users will just be very confused about why they can't click the check boxes.
There was a problem hiding this comment.
I removed it completely 👍 not sure it's useful either
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
I have no strong opinion either way.
3 participants
What does this PR do?
This removes the "plugin" checklist from the PR description template, as no one really uses it much, and it's a relic of when dd-trace-js was mostly just plugins.