[APPSEC] use http endpoint on api security sampling algorithm when route is not available#7062
Merged
IlyasShabi merged 7 commits intomasterfrom Mar 12, 2026
Merged
Conversation
Contributor
Overall package sizeSelf size: 4.96 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.0 | 81.15 kB | 815.98 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7062 +/- ##
==========================================
+ Coverage 80.31% 80.42% +0.10%
==========================================
Files 739 741 +2
Lines 31946 32131 +185
==========================================
+ Hits 25657 25840 +183
- Misses 6289 6291 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IlyasShabi
changed the title
BenchmarksBenchmark execution time: 2026-03-12 10:27:10 Comparing candidate commit cc789e9 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 228 metrics, 32 unstable metrics. |
IlyasShabi
force-pushed
the
ishabi/http-endpoint-sampling-algorithm
branch
from
7567808 to
1394ac4
Compare
This comment has been minimized.
This comment has been minimized.
IlyasShabi
force-pushed
the
ishabi/http-endpoint-sampling-algorithm
branch
from
a83abbd to
29be87f
Compare
IlyasShabi
commented
Mar 5, 2026
packages/dd-trace/test/appsec/resources/api_security_sampling-app.js
Outdated
Show resolved
Hide resolved
CarlesDD
reviewed
Mar 11, 2026
Contributor
CarlesDD
left a comment
CarlesDD
left a comment
There was a problem hiding this comment.
Besides the existing comment on the PR, LGTM
Member
|
same, LGTM other than the remaining TODO |
simon-id
reviewed
Mar 12, 2026
packages/dd-trace/test/appsec/resources/api_security_sampling-app.js
Outdated
Show resolved
Hide resolved
simon-id
approved these changes
Mar 12, 2026
Member
simon-id
left a comment
simon-id
left a comment
There was a problem hiding this comment.
I committed a lint fix but LGTM now
CarlesDD
approved these changes
Mar 12, 2026
dd-octo-sts bot
pushed a commit
that referenced
this pull request
Mar 13, 2026
…ute is not available (#7062) Use http endpoint on api security sampling algorithm when route is not available
Merged
CarlesDD
pushed a commit
that referenced
this pull request
Mar 16, 2026
…ute is not available (#7062) Use http endpoint on api security sampling algorithm when route is not available
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
APPSEC-59788
Use
http.endpointfor api security sampling algorithm on schema collection when the route is not availableTasks