Skip to content

fix(debugger): don't expect probe config to contain capture object#6807

Merged
BridgeAR merged 1 commit intomasterfrom
watson/DEBUG-4611/allow-no-capture-obj
Feb 1, 2026
Merged

fix(debugger): don't expect probe config to contain capture object#6807
BridgeAR merged 1 commit intomasterfrom
watson/DEBUG-4611/allow-no-capture-obj

Conversation

@watson
Copy link
Copy Markdown
Collaborator

@watson watson commented Oct 31, 2025

What does this PR do?

Don't throw if the probe config doesn't contain a capture object when captureSnapshot: true.

Motivation

Currently, all probe config objects does contain a capture object, but in case this ever changes in the future we'll be prepared.

Plugin Checklist

Additional Notes

Copy link
Copy Markdown
Collaborator Author

watson commented Oct 31, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 31, 2025

Overall package size

Self size: 4.49 MB
Deduped: 5.33 MB
No deduping: 5.33 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.3 | 76.87 kB | 808.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.86%. Comparing base (4a8a494) to head (5622218).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6807   +/-   ##
=======================================
  Coverage   85.86%   85.86%           
=======================================
  Files         518      518           
  Lines       22375    22375           
=======================================
  Hits        19212    19212           
  Misses       3163     3163           
Flag Coverage Δ
aiguard-macos 99.09% <ø> (ø)
aiguard-ubuntu 99.09% <ø> (ø)
aiguard-windows 99.09% <ø> (ø)
apm-capabilities-tracing-macos 57.66% <ø> (ø)
apm-capabilities-tracing-ubuntu 57.66% <ø> (ø)
apm-capabilities-tracing-windows 57.27% <ø> (ø)
apm-integrations-child-process 99.19% <ø> (ø)
apm-integrations-couchbase-18 100.00% <ø> (ø)
apm-integrations-couchbase-eol 100.00% <ø> (ø)
appsec-express 62.54% <ø> (ø)
appsec-fastify 58.55% <ø> (ø)
appsec-graphql 53.40% <ø> (ø)
appsec-kafka 43.98% <ø> (ø)
appsec-ldapjs 46.04% <ø> (ø)
appsec-lodash 47.29% <ø> (ø)
appsec-macos 93.76% <ø> (ø)
appsec-mongodb-core 51.82% <ø> (ø)
appsec-mongoose 50.73% <ø> (ø)
appsec-mysql 54.16% <ø> (ø)
appsec-node-serialize 43.92% <ø> (ø)
appsec-passport 48.07% <ø> (ø)
appsec-postgres 54.51% <ø> (ø)
appsec-sourcing 33.80% <ø> (ø)
appsec-template 43.92% <ø> (ø)
appsec-ubuntu 93.76% <ø> (ø)
appsec-windows 93.76% <ø> (ø)
llmobs-ai 52.09% <ø> (ø)
llmobs-anthropic 42.73% <ø> (ø)
llmobs-bedrock 40.06% <ø> (ø)
llmobs-google-genai 45.89% <ø> (ø)
llmobs-langchain 50.15% <ø> (ø)
llmobs-openai 55.62% <ø> (ø)
llmobs-vertex-ai 44.48% <ø> (ø)
platform-core 87.23% <ø> (ø)
platform-instrumentations-misc 89.16% <ø> (ø)
platform-shimmer 98.80% <ø> (ø)
platform-unit-guardrails 89.47% <ø> (ø)
profiling-macos 70.74% <ø> (ø)
profiling-ubuntu 70.74% <ø> (ø)
profiling-windows 74.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@watson watson self-assigned this Oct 31, 2025
@watson watson added semver-patch debugger Dynamic Instrumentation & Live Debugger labels Oct 31, 2025
@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Oct 31, 2025

Benchmarks

Benchmark execution time: 2026-02-01 18:12:23

Comparing candidate commit 5622218 in PR branch watson/DEBUG-4611/allow-no-capture-obj with baseline commit 4a8a494 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 228 metrics, 32 unstable metrics.

@watson watson force-pushed the watson/DEBUG-4611/allow-no-capture-obj branch 2 times, most recently from 47fb11c to 62df394 Compare January 27, 2026 11:49
@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 bot commented Jan 27, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5622218 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@watson watson marked this pull request as ready for review January 30, 2026 14:57
@watson watson requested review from a team as code owners January 30, 2026 14:57
Don't throw if the probe config doesn't contain a `capture` object when
`captureSnapshot: true`.

Currently, all probe config objects does contain a `capture` object, but
in case this ever changes in the future we'll be prepared.
@watson watson force-pushed the watson/DEBUG-4611/allow-no-capture-obj branch from 62df394 to 5622218 Compare February 1, 2026 18:02
@BridgeAR BridgeAR enabled auto-merge (squash) February 1, 2026 18:20
@BridgeAR BridgeAR merged commit d19c433 into master Feb 1, 2026
788 of 789 checks passed
@BridgeAR BridgeAR deleted the watson/DEBUG-4611/allow-no-capture-obj branch February 1, 2026 18:25
dd-octo-sts bot pushed a commit that referenced this pull request Feb 2, 2026
…6807)

Don't throw if the probe config doesn't contain a `capture` object when
`captureSnapshot: true`.

Currently, all probe config objects does contain a `capture` object, but
in case this ever changes in the future we'll be prepared.
@dd-octo-sts dd-octo-sts bot mentioned this pull request Feb 2, 2026
BridgeAR pushed a commit that referenced this pull request Feb 5, 2026
…6807)

Don't throw if the probe config doesn't contain a `capture` object when
`captureSnapshot: true`.

Currently, all probe config objects does contain a `capture` object, but
in case this ever changes in the future we'll be prepared.
bm1549 pushed a commit that referenced this pull request Feb 10, 2026
…6807)

Don't throw if the probe config doesn't contain a `capture` object when
`captureSnapshot: true`.

Currently, all probe config objects does contain a `capture` object, but
in case this ever changes in the future we'll be prepared.
BridgeAR pushed a commit that referenced this pull request Feb 22, 2026
…6807)

Don't throw if the probe config doesn't contain a `capture` object when
`captureSnapshot: true`.

Currently, all probe config objects does contain a `capture` object, but
in case this ever changes in the future we'll be prepared.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debugger Dynamic Instrumentation & Live Debugger semver-patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants