Add appsec.enabled origin gauge metric#5794
Merged
Merged
Conversation
Contributor
Overall package sizeSelf size: 9.6 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.6.0 | 30.47 MB | 30.47 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/pprof | 5.8.0 | 12.55 MB | 12.92 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.3 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.14.0 | 120.58 kB | 841.68 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.9 | 25.11 kB | 25.11 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5794 +/- ##
==========================================
- Coverage 79.16% 78.98% -0.19%
==========================================
Files 522 518 -4
Lines 24060 23990 -70
==========================================
- Hits 19047 18948 -99
- Misses 5013 5042 +29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Datadog ReportBranch report: ✅ 0 Failed, 1253 Passed, 0 Skipped, 24m 39.11s Total Time |
BenchmarksBenchmark execution time: 2025-06-06 08:35:42 Comparing candidate commit 630d821 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1274 metrics, 49 unstable metrics. |
added 9 commits
May 30, 2025 15:46
uurien
marked this pull request as ready for review
June 5, 2025 17:31
CarlesDD
reviewed
Jun 6, 2025
| @@ -1478,6 +1473,17 @@ class Config { | |||
| 'calculated', | |||
Contributor
There was a problem hiding this comment.
Bit unrelated and it could not happen in this case but calculated is not a valid origin for telemetry
Contributor
Author
There was a problem hiding this comment.
It can't happen, but anyway, I'll protect it to unknown
CarlesDD
previously approved these changes
Jun 6, 2025
7 tasks
CarlesDD
approved these changes
Jun 6, 2025
ghost
pushed a commit
that referenced
this pull request
Jun 6, 2025
* Add appsec.enabled origin gauge metric * Fix tests * Fix test * Restore gauge metric to original * Tiny improvements * Clean * Fix lint * Add unit test in config.spec.js * Send origin=unknown when origin is not supported by the metric * Use Set instead of Array
ghost
mentioned this pull request
Merged
sabrenner
pushed a commit
that referenced
this pull request
Jun 6, 2025
* Add appsec.enabled origin gauge metric * Fix tests * Fix test * Restore gauge metric to original * Tiny improvements * Clean * Fix lint * Add unit test in config.spec.js * Send origin=unknown when origin is not supported by the metric * Use Set instead of Array
CarlesDD
added a commit
that referenced
this pull request
Nov 17, 2025
juan-fernandez
pushed a commit
that referenced
this pull request
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Send a metric in an interval when appsec is enabled show how has been enabled (RC, code, env_var)
Motivation
Have a recurrent data about saying that appsec is enabled, even when there is no request in the service.
Plugin Checklist
Additional Notes
APPSEC-57438
System tests: DataDog/system-tests#4734