Skip to content

simple benchmark helper for adding operations per second#5606

Closed
bengl wants to merge 1 commit into
masterfrom
bengl/benchmark-helper-ops
Closed

simple benchmark helper for adding operations per second#5606
bengl wants to merge 1 commit into
masterfrom
bengl/benchmark-helper-ops

Conversation

@bengl

@bengl bengl commented Apr 24, 2025

Copy link
Copy Markdown
Collaborator

Adds a benchmark helper for calculating the operations per second in a given benchmark, then sending that off to Sirun via statsd, for inclusion in the output.

@bengl
bengl requested a review from a team as a code owner April 24, 2025 04:00
@github-actions

github-actions Bot commented Apr 24, 2025

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 9.3 MB
Deduped: 102.55 MB
No deduping: 103.07 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.1 | 29.73 MB | 29.73 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/native-iast-taint-tracking | 3.3.1 | 13.99 MB | 13.99 MB | | @datadog/pprof | 5.7.1 | 9.51 MB | 9.88 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.8 | 25.08 kB | 25.08 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov

codecov Bot commented Apr 24, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.10%. Comparing base (daf4277) to head (995960f).
⚠️ Report is 1438 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5606      +/-   ##
==========================================
+ Coverage   79.04%   79.10%   +0.06%     
==========================================
  Files         512      513       +1     
  Lines       23439    23511      +72     
==========================================
+ Hits        18527    18599      +72     
  Misses       4912     4912              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Apr 24, 2025

Copy link
Copy Markdown

Datadog Report

Branch report: bengl/benchmark-helper-ops
Commit report: 1d196af
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 935 Passed, 0 Skipped, 15m 43.75s Total Time

BridgeAR
BridgeAR previously approved these changes Apr 24, 2025
@BridgeAR

Copy link
Copy Markdown
Member

The benchmark suite does not yet seem to accept this as is

@BridgeAR
BridgeAR dismissed their stale review April 24, 2025 10:15

CI failures

@BridgeAR
BridgeAR force-pushed the bengl/benchmark-helper-ops branch from 53b04a2 to 995960f Compare May 7, 2025 23:55
@github-actions

github-actions Bot commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 90 days of inactivity.
If this is still relevant, please update or comment to keep it open.
If this should be kept open indefinitely, please apply the label keep-open.
Otherwise, it will be automatically closed after 14 days.

@BridgeAR

Copy link
Copy Markdown
Member

Closing as superseded. The feature landed in benchmarking platform and I am integrating it into our startup guard to automatically report this metric as well.

@BridgeAR BridgeAR closed this Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants