Add shimmer shimmer benchmarks#5597
Merged
Merged
Conversation
bengl
marked this pull request as draft
April 21, 2025 17:13
Contributor
Overall package sizeSelf size: 9.34 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.1 | 29.73 MB | 29.73 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/native-iast-taint-tracking | 3.3.1 | 13.99 MB | 13.99 MB | | @datadog/pprof | 5.7.1 | 9.51 MB | 9.88 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.8 | 25.08 kB | 25.08 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5597 +/- ##
=======================================
Coverage 79.25% 79.25%
=======================================
Files 513 513
Lines 23412 23412
=======================================
Hits 18556 18556
Misses 4856 4856 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Datadog ReportBranch report: ✅ 0 Failed, 923 Passed, 0 Skipped, 9m 36.32s Total Time |
BenchmarksBenchmark execution time: 2025-04-23 20:48:40 Comparing candidate commit 87ca189 in PR branch Found 4 performance improvements and 5 performance regressions! Performance is the same for 938 metrics, 16 unstable metrics. scenario:plugin-q-control-18
scenario:plugin-q-control-20
scenario:plugin-q-control-22
scenario:scope-manager-async_hooks-22
scenario:scope-manager-async_local_storage-22
scenario:scope-manager-async_resource-22
scenario:scope-manager-base-20
scenario:scope-manager-base-22
|
BridgeAR
reviewed
Apr 22, 2025
BridgeAR
reviewed
Apr 22, 2025
bengl
force-pushed
the
bengl/some-shimmer-benchmarks
branch
from
April 22, 2025 18:25
578903e to
06edb8d
Compare
The "iterations" is currently set to 1 in the config. Both this and the ITERATIONS constant in each test will likely require some tweaking before this lands.
bengl
force-pushed
the
bengl/some-shimmer-benchmarks
branch
from
April 22, 2025 18:26
06edb8d to
2371a2e
Compare
BridgeAR
reviewed
Apr 22, 2025
BridgeAR
left a comment
BridgeAR
left a comment
Member
There was a problem hiding this comment.
It is rather confusing that the benchmark addition changes the performance for existing benchmarks. I can't find an explanation besides unreliable benchmarks.
BridgeAR
reviewed
Apr 23, 2025
BridgeAR
reviewed
Apr 23, 2025
bengl
marked this pull request as ready for review
April 24, 2025 02:09
BridgeAR
approved these changes
Apr 24, 2025
ghost
pushed a commit
that referenced
this pull request
Apr 25, 2025
ghost
mentioned this pull request
Merged
watson
pushed a commit
that referenced
this pull request
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "iterations" is currently set to 1 in the config. Both this and the ITERATIONS constant in each test will likely require some tweaking before this lands.