refactor(test-optimization)!: raise Cypress minimum version to 10.2.0#5397
Merged
Conversation
Contributor
Overall package sizeSelf size: 9.42 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.1 | 29.73 MB | 29.73 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/pprof | 5.8.0 | 12.55 MB | 12.92 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.8 | 25.08 kB | 25.08 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5397 +/- ##
==========================================
- Coverage 79.15% 79.15% -0.01%
==========================================
Files 520 520
Lines 23729 23729
==========================================
- Hits 18783 18782 -1
- Misses 4946 4947 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Datadog ReportBranch report: ✅ 0 Failed, 1107 Passed, 0 Skipped, 20m 44.37s Total Time |
BenchmarksBenchmark execution time: 2025-05-22 12:35:17 Comparing candidate commit 9a5da40 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1274 metrics, 49 unstable metrics. |
1 task
Mariovido
changed the title
Mariovido
previously approved these changes
May 9, 2025
juan-fernandez
force-pushed
the
juan-fernandez/cypress-breaking-changes
branch
from
May 22, 2025 10:37
23ab728 to
6dcdcfb
Compare
BSanchidrian
previously approved these changes
May 22, 2025
Mariovido
previously approved these changes
May 22, 2025
Member
|
Actually I suppose it's pretty small as is. |
juan-fernandez
dismissed stale reviews from Mariovido and BSanchidrian
via
May 22, 2025 12:23
9a5da40
tlhunter
approved these changes
May 22, 2025
Mariovido
approved these changes
May 22, 2025
ghost
pushed a commit
that referenced
this pull request
May 24, 2025
ghost
mentioned this pull request
Closed
ghost
pushed a commit
that referenced
this pull request
May 27, 2025
ghost
mentioned this pull request
Merged
watson
pushed a commit
that referenced
this pull request
Jun 4, 2025
pabloerhard
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
With this we are increasing the minimum supported version of cypress to
10.2.0. This only happens indd-trace@v6, sov5remains the same.ℹ️ Note: the breaking change is only for v6. For v5 it's a noop, so this can be merged to master and released to v5.
The breaking change is in https://github.com/DataDog/dd-trace-js/pull/5397/files#diff-3798402dbf67b035bbbfc7c49083771e489a1ef2ed5117b8fc5dbddb8f367f22R25-R32
Motivation
Get rid of really old version which forces us to use old versions of node.
Plugin Checklist