Skip to content

[DI] Improve code comment#5319

Merged
BridgeAR merged 1 commit into
masterfrom
watson/DEBUG-3526/add-missing-comment
Feb 26, 2025
Merged

[DI] Improve code comment#5319
BridgeAR merged 1 commit into
masterfrom
watson/DEBUG-3526/add-missing-comment

Conversation

@watson

@watson watson commented Feb 26, 2025

Copy link
Copy Markdown
Collaborator

What does this PR do?

Improve a code comment.

Motivation

This was lost in a refactor.

Plugin Checklist

Additional Notes

@watson
watson requested review from a team as code owners February 26, 2025 05:11
@watson watson self-assigned this Feb 26, 2025
@watson watson added semver-patch debugger Dynamic Instrumentation & Live Debugger labels Feb 26, 2025

watson commented Feb 26, 2025

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 8.79 MB
Deduped: 94.99 MB
No deduping: 95.5 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov

codecov Bot commented Feb 26, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.42%. Comparing base (a1cd027) to head (56fdc30).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5319   +/-   ##
=======================================
  Coverage   80.42%   80.42%           
=======================================
  Files         491      491           
  Lines       21847    21847           
=======================================
  Hits        17570    17570           
  Misses       4277     4277           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1

Copy link
Copy Markdown

Datadog Report

Branch report: watson/DEBUG-3526/add-missing-comment
Commit report: 4cd8c8d
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 674 Passed, 0 Skipped, 16m 50.15s Total Time

@pr-commenter

pr-commenter Bot commented Feb 26, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-02-26 05:22:45

Comparing candidate commit 56fdc30 in PR branch watson/DEBUG-3526/add-missing-comment with baseline commit a1cd027 in branch master.

Found 0 performance improvements and 5 performance regressions! Performance is the same for 910 metrics, 18 unstable metrics.

scenario:log-skip-log-22

  • 🟥 execution_time [+15.370ms; +19.731ms] or [+5.118%; +6.570%]

scenario:log-with-debug-22

  • 🟥 cpu_user_time [+13.591ms; +18.931ms] or [+5.210%; +7.256%]
  • 🟥 execution_time [+16.671ms; +20.150ms] or [+5.557%; +6.717%]

scenario:log-with-error-22

  • 🟥 cpu_user_time [+16.745ms; +22.136ms] or [+6.570%; +8.686%]
  • 🟥 execution_time [+16.058ms; +20.029ms] or [+5.445%; +6.792%]

@BridgeAR
BridgeAR merged commit 8cd547e into master Feb 26, 2025
@BridgeAR
BridgeAR deleted the watson/DEBUG-3526/add-missing-comment branch February 26, 2025 08:50
@watson watson mentioned this pull request Feb 27, 2025
watson added a commit that referenced this pull request Feb 27, 2025
watson added a commit that referenced this pull request Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debugger Dynamic Instrumentation & Live Debugger semver-patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants